Files
stopwatch/app/jobs/stopwatch_timer_tick_job.rb
T
Claude 626db60658 Timer safety: length limit, server-side saving, stop on close
- Maximum timer length setting (default 10h): a timer that runs past it
  is stopped at the limit and its entry's comment is flagged, so a
  forgotten timer can't add a night or weekend of hours
- StopwatchTimerTickJob saves a running timer's time every minute on the
  server (no browser needed) and stops it at the limit on time; open
  tabs keep saving too
- Timer updates lock the user's preference row and re-read the timer, so
  simultaneous saves (several tabs, the job) never add time twice
- Closing an issue stops timers running on it before anything else (e.g.
  billing) uses its time; deleting a time entry only stops the timer
  running on that entry
- Issue timers require a visible issue; starting again moves the timer
  instead of raising "timer is already running"
- Tests updated and extended (limit, locking, tick job, close, delete,
  visibility, issue context menu); CI runs on Redmine 7.0
- Upstream's German notes translated

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 00:13:21 -04:00

31 lines
1.3 KiB
Ruby

# Saves a running timer's time into its time entry every minute on the server, so the issue shows the
# hours live even when nobody has Redmine open, and a forgotten timer is stopped at the maximum timer
# length on time. Each start gets its own chain of jobs (identified by a token); a chain ends when the
# timer stops or is restarted. Pending jobs are lost if Redmine restarts with the default in-process
# job runner; the next start, or an open tab's once-a-minute check, keeps the time up to date meanwhile.
class StopwatchTimerTickJob < ActiveJob::Base
queue_as :default
INTERVAL = 1.minute
# Schedules the next tick, if the job backend supports delayed jobs (the :inline backend doesn't)
def self.schedule(user_id, token)
set(wait: INTERVAL).perform_later(user_id, token)
rescue NotImplementedError => e
Rails.logger.info "[Stopwatch] Server-side timer saving unavailable with this job backend: #{e.message}"
end
def perform(user_id, token)
user = User.find_by(id: user_id)
return unless user
timer = Stopwatch::Timer.new(user)
return unless timer.running? && timer.tick_token == token
timer.update
self.class.schedule(user_id, token) if timer.running? && timer.tick_token == token
rescue StandardError => e
Rails.logger.error "[Stopwatch] Timer tick failed for user ##{user_id}: #{e.class}: #{e.message}"
end
end