Files
simple-aircraft-manager-rails/test/integration/engine_data_flow_test.rb
T
rickyandClaude Opus 5.5 2d068e1a63 Interactive engine data charts: click to zoom, crosshair readout, range stats
Clicking a chart opens a viewer with higher-resolution data (new JSON
endpoint, fetched once): drag to zoom, tabs keep the zoom across metrics,
legend toggles, and min/avg/max for the visible range in monitor time.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-06 17:42:24 -05:00

116 lines
5.2 KiB
Ruby

require "test_helper"
class EngineDataFlowTest < ActionDispatch::IntegrationTest
setup do
@owner = create_user
@pilot = create_user
@other_pilot = create_user
@aircraft = create_aircraft(owner: @owner, pilot: @pilot, tail_number: "N12345", tach_time: 7149.7)
@aircraft.roles.create!(user: @other_pilot, role: "pilot")
end
def upload(name = "cgr30p.csv") = fixture_file_upload("engine_data/#{name}", "text/csv")
test "pilot logs a flight with engine data and sees the summary and charts" do
sign_in @pilot
post aircraft_flight_logs_path(@aircraft), params: { flight_log: { date: "2025-07-14", tach_out: 7149.7, tach_in: 7149.8, engine_data: upload } }
flight = @aircraft.flight_logs.last
assert flight.engine_data.attached?
get aircraft_flight_logs_path(@aircraft)
assert_includes response.body, "Engine data attached"
get aircraft_flight_log_path(@aircraft, flight)
assert_response :success
assert_includes response.body, "8m 39s"
assert_includes response.body, "7149.77 → 7149.81 (0.04)"
assert_includes response.body, "EGT (cyl 4)"
assert_includes response.body, "No (ground run)"
assert_includes response.body, "Chartkick"
refute_includes response.body, "This recording is from"
end
test "an unreadable file is rejected when logging" do
sign_in @pilot
post aircraft_flight_logs_path(@aircraft), params: { flight_log: { date: "2025-07-14", tach_time: 0.1,
engine_data: fixture_file_upload("flights.csv", "text/csv") } }
assert_response :unprocessable_entity
assert_includes response.body, "Not a recognized engine monitor file"
assert_equal 0, @aircraft.flight_logs.count
end
test "attach to and remove from an existing flight; only owners or the flight's pilot" do
flight = @aircraft.flight_logs.create!(date: Date.current, tach_time: 0.1, user: @pilot)
sign_in @other_pilot
patch engine_data_aircraft_flight_log_path(@aircraft, flight), params: { flight_log: { engine_data: upload } }
assert_redirected_to aircraft_flight_log_path(@aircraft, flight)
refute flight.reload.engine_data.attached?
get aircraft_flight_log_path(@aircraft, flight)
refute_includes response.body, "Attach engine monitor data"
sign_in @pilot
get aircraft_flight_log_path(@aircraft, flight)
assert_includes response.body, "Attach engine monitor data"
patch engine_data_aircraft_flight_log_path(@aircraft, flight), params: { flight_log: { engine_data: upload } }
assert flight.reload.engine_data.attached?
sign_in @owner
delete engine_data_aircraft_flight_log_path(@aircraft, flight)
perform_enqueued_jobs
refute flight.reload.engine_data.attached?
end
test "warns when the recording is from another aircraft" do
@aircraft.update!(tail_number: "N54321")
flight = @aircraft.flight_logs.create!(date: Date.current, tach_time: 0.1, engine_data: upload)
sign_in @owner
get aircraft_flight_log_path(@aircraft, flight)
assert_includes response.body, "This recording is from <strong>N12345</strong>"
end
test "charts open an interactive viewer fed by a JSON series" do
flight = @aircraft.flight_logs.create!(date: Date.new(2025, 7, 14), tach_time: 0.1, user: @pilot, engine_data: upload)
sign_in @other_pilot # anyone with access to the aircraft can explore the charts
get aircraft_flight_log_path(@aircraft, flight)
url = engine_data_aircraft_flight_log_path(@aircraft, flight, format: :json)
assert_select "[data-controller=engine-chart][data-engine-chart-url-value='#{url}']" do
assert_select "figure[role=button][data-action*='engine-chart#open']", minimum: 4
assert_select "figure[data-engine-chart-group-param='0'] figcaption", text: /CHT/
assert_select "dialog[data-engine-chart-target=dialog] canvas[data-engine-chart-target=canvas]"
end
get url
assert_response :success
data = response.parsed_body
assert_equal data["times"].size, data["channels"]["rpm"]["values"].size
assert_equal 0, data["times"].first
assert data["times"].each_cons(2).all? { _1 <= _2 }, "times ascend"
assert_kind_of Integer, data["started_at"]
assert_equal %w[CHT EGT RPM], data["groups"].first(3).map { _1["title"] }
cht = data["groups"].first
assert_equal %w[cht1 cht2 cht3 cht4], cht["keys"]
assert_equal "°F", cht["unit"]
data["groups"].flat_map { _1["keys"] }.each { assert data["channels"].key?(_1), "#{_1} has data" }
etag = response.headers["ETag"]
get url, headers: { "If-None-Match" => etag }
assert_response :not_modified
end
test "the series stays private to people with access to the aircraft" do
flight = @aircraft.flight_logs.create!(date: Date.new(2025, 7, 14), tach_time: 0.1, user: @pilot, engine_data: upload)
sign_in create_user
get engine_data_aircraft_flight_log_path(@aircraft, flight, format: :json)
assert_response :not_found
end
test "a flight without engine data has no series" do
flight = @aircraft.flight_logs.create!(date: Date.new(2025, 7, 14), tach_time: 0.1, user: @pilot)
sign_in @pilot
get engine_data_aircraft_flight_log_path(@aircraft, flight, format: :json)
assert_response :not_found
end
end