Files
redmine_qbo_vehicles/app/views/vehicles/_details.html.erb
T
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00

64 lines
2.0 KiB
ERB

<div class="issue">
<div class="splitcontent">
<div class="splitcontentleft">
<h4><%= t(:label_details) %>:</h4>
<table>
<tbody>
<tr>
<th><%= t(:field_customer) %></th>
<td><%= vehicle.customer ? link_to(vehicle.customer.name, customer_path(vehicle.customer)) : t(:no_customer) %></td>
</tr>
<tr>
<th><%= t(:field_vehicle) %></th>
<td><%= vehicle.to_s %></td>
</tr>
<tr>
<th><%= t(:field_vin) %></th>
<td>
<div onclick="handleCopy(event)"><%= @vin[0] if @vin %><b><%= @vin[1] if @vin %></b></div>
</td>
</tr>
<tr>
<th><%= t(:label_trim) %></th>
<td><%= vehicle.doors %> <%= t(:label_door) if vehicle.doors? %> <%= vehicle.trim %></td>
</tr>
</tbody>
</table>
</div>
<div class="splitcontentright">
<h4><%= t(:field_notes) %>:</h4>
<div class="vehicle_notes attribute">
<div class="label"><%= t(:field_notes) %>:</div>
<% if vehicle.notes.present? %>
<div class="value wiki">
<%= textilizable(vehicle, :notes) %>
</div>
<% end %>
</div>
</div>
</div>
</div>
<% mileage = vehicle.last_service_mileage %>
<% if mileage %>
<p>
<b><%= t(:label_last_service) %></b> <%= vehicle.last_service_date %>
at <%= mileage %> <%= t(:label_miles) %>
</p>
<% end %>
<div style="float: right;">
<% if User.current.allowed_to?(:edit_vehicles, nil, global: true) %>
<%= button_to t(:label_edit), edit_vehicle_path(vehicle), method: :get %>
<% end %>
<%# Vehicles with issues can't be deleted, to keep their service history %>
<% if User.current.allowed_to?(:delete_vehicles, nil, global: true) && !vehicle.issues.exists? %>
<%= button_to t(:label_delete), vehicle, method: :delete, data: { confirm: t(:warn_ru_sure) } %>
<% end %>
</div>