Commit Graph
31 Commits
Author SHA1 Message Date
Claude d987746c40 Vehicle picker on the Create issues from estimate page
redmine_qbo's Create issues page gets a Vehicle for all the issues (view hook
view_qbo_estimate_issues_form): preselected with the appointment's vehicle, else the customer's vehicle
matching the estimate's VIN. When none matches, or the estimate has no VIN, it says so, so the team can
pick one first. The chosen vehicle (or none) is what qbo_billing_build_issue puts on the issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 10:25:02 -04:00
Claude 14abda2022 Give new estimates and invoices their VIN (qbo_billing_default_vin)
The work orders' vehicle when they share one, else the customer's only vehicle with a VIN; nothing when
it's ambiguous.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 10:17:26 -04:00
Claude 7ea286b288 Take over the vehicle parts of redmine_qbo's billing
- Mileage for invoices (the Mileage issue custom field) now comes from this plugin's
  qbo_billing_issue_values answer, alongside the VIN.
- qbo_billing_vin_options: the customer's vehicles as VIN suggestions in the estimate/invoice editor.
- qbo_billing_build_issue: issues created from an estimate get the appointment's vehicle, or the
  customer's vehicle whose VIN is on the estimate.
- Vehicle checkboxes on the customer page say which New issue field they fill (data-new-issue-param).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 09:12:52 -04:00
Claude 70e55fdd45 Point billing docs at redmine_qbo
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-30 23:49:23 -04:00
Claude 2310b4b30a Invoices: VIN from work orders, one vehicle per invoice
Listens for redmine_qbo_billing's hooks: qbo_billing_issue_values gives each
work order's VIN, so the invoice's VIN box fills in when its time or
estimates are imported; qbo_billing_validate stops an invoice whose work
orders are for more than one vehicle (one vehicle per invoice).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-30 22:30:27 -04:00
Claude a0789bd495 Issue PDF: bold the last 8 of 17-character VINs
Matches the on-screen VIN: 17-character VINs show the last 8 in bold
(what dealerships ask for), older or short VINs plain. Uses
redmine_qbo's HTML values in the PDF grid when available; with an older
redmine_qbo the last 8 are set apart with a space as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:21:07 -04:00
Claude 129a9f668c VIN click-to-copy: shared snippet, last 8 bold only for 17-char VINs
- New vehicles/_vin partial used on the issue page, vehicle page and
  vehicle lists (replaces three copies of the markup, inline onclick
  handlers and a fixed id="copyLink")
- 17-character VINs show the last 8 in bold (what dealerships ask for
  when ordering parts); older or short VINs are shown plain
- Copies the VIN from a data attribute, restores the exact display
  afterwards, shows "Copied!" or "Couldn't copy", falls back when the
  Clipboard API isn't available, and supports Enter/Space; pointer
  cursor and "Click to copy" tooltip
- The copy script is written into the page by the layout hook instead
  of served as copy.js, so it can't 404 when Redmine's asset manifest
  is out of date; one listener handles every VIN on the page
- Issue PDFs split 17-character VINs before the last 8; others whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:09:27 -04:00
Claude d4684b8ae9 Fix vehicle dropdown after a customer change; drop vehicles.js
The issue form already reloads on the server when the customer changes
(redmine_qbo's updateIssueFrom), re-rendering the vehicle list for the
new customer. 0a3c734 broke that by always keeping the issue's current
vehicle in the list, so after changing the customer the previous
customer's vehicle stayed listed and selected.

- The current vehicle is only kept for an existing issue whose customer
  hasn't been changed in the form (keeps sold vehicles' history);
  otherwise only the selected customer's vehicles are offered
- Removes vehicles.js, which duplicated the form reload, its include and
  the JSON vehicle listing it used

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 19:09:47 -04:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky 5eac85351d Register vehicle field with SubtaskFieldCopier and ensure uniqueness 2026-08-26 21:19:56 -04:00
ricky 9cc2af9cec Refactor vehicle views for improved formatting and note handling 2026-08-11 18:33:16 -04:00
ricky a9d0eafa40 Add vehicle appointment hook and localization for 'Add Vehicle' label 2026-08-10 19:04:58 -04:00
ricky 35542ba1b9 Fix vehicle name fallback not applied in select by replacing pluck with model instances 2026-04-09 09:42:45 -04:00
ricky 83a5811a37 Removed InvoiceHookListener registation 2026-03-29 21:55:41 -04:00
ricky a9354026bc removed InvoiceHookListener as support has been removed from redmine_qbo 2026-03-28 00:27:59 -04:00
ricky 097276e558 Updated patches and hooks 2026-03-21 12:23:23 -04:00
ricky a67b75671e updated logging with prefix 2026-03-04 20:57:12 -05:00
ricky 5cad4a6856 added js to copy vin on click 2026-02-13 21:28:45 -05:00
ricky 5165bc20b4 Changed display format of vehicle lists 2026-02-13 07:48:36 -05:00
ricky e09990cd42 added nil check 2026-01-30 17:04:23 -05:00
ricky 5a2832b751 need to supply selcted id 2026-01-30 07:49:51 -05:00
ricky 634fd96e82 Cleaned up pdf hook 2026-01-29 23:38:55 -05:00
ricky ce624f178f Updated comment 2026-01-29 23:33:42 -05:00
ricky 808b84a346 Cleaned up issue show hook 2026-01-29 23:32:12 -05:00
ricky e4d2df889d Cleaned up issue form hook 2026-01-29 23:22:09 -05:00
ricky 715c412668 removed unused invocie variable 2026-01-29 22:55:14 -05:00
ricky e0a23bac20 Lose the hash rocket, use symbols 2026-01-29 22:52:17 -05:00
ricky 8eecdc0ddd added invoice hook listener to update invoice with VIN 2026-01-27 20:56:08 -05:00
ricky 2f49a21fed Removed legacy pfd patch 2026-01-27 20:25:08 -05:00
ricky 896d5a64ba Remove Project Level Integration 2026-01-27 18:04:32 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00