mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-17 18:40:36 -05:00
Fix access, VIN decoding, vehicle history and form bugs
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
18 files changed
+268
-130
No files matched your search
@@ -17,8 +17,12 @@ module Vehicles
|
||||
|
||||
def view_issues_form_details_bottom(context={})
|
||||
|
||||
# Load the customer's vehicles for selection in the issue form.
|
||||
vehicles = context[:issue].customer&.vehicles || []
|
||||
# Load the customer's vehicles for selection in the issue form. The vehicle already on the issue is
|
||||
# always included: after a vehicle is sold it belongs to another customer, and leaving it out
|
||||
# would blank it on the next save, dropping the issue from that vehicle's history.
|
||||
issue = context[:issue]
|
||||
vehicles = (issue.customer&.vehicles.to_a || [])
|
||||
vehicles |= [issue.vehicle] if issue.vehicle
|
||||
|
||||
context[:controller].send(:render_to_string, {
|
||||
partial: 'issues/form_hook_vehicles',
|
||||
@@ -26,8 +30,9 @@ module Vehicles
|
||||
vehicle: context[:form].select(
|
||||
:vehicle_id,
|
||||
vehicles.map { |v| [v.name, v.id] },
|
||||
selected: context[:issue].vehicle&.id,
|
||||
include_blank: true
|
||||
{ selected: context[:issue].vehicle&.id, include_blank: true },
|
||||
# vehicles.js swaps in the customer id and reloads this list when the customer changes
|
||||
{ data: { vehicles_url: customer_vehicles_path('__CUSTOMER_ID__') } }
|
||||
)
|
||||
}
|
||||
})
|
||||
|
||||
@@ -15,7 +15,8 @@ module Vehicles
|
||||
def view_layouts_base_html_head(context = {})
|
||||
safe_join([
|
||||
stylesheet_link_tag('style', plugin: :redmine_qbo_vehicles, media: :all),
|
||||
javascript_include_tag('copy', plugin: :redmine_qbo_vehicles)
|
||||
javascript_include_tag('copy', plugin: :redmine_qbo_vehicles),
|
||||
javascript_include_tag('vehicles', plugin: :redmine_qbo_vehicles)
|
||||
])
|
||||
end
|
||||
|
||||
|
||||
@@ -17,7 +17,23 @@ module Vehicles
|
||||
extend ActiveSupport::Concern
|
||||
|
||||
prepended do
|
||||
belongs_to :vehicle
|
||||
belongs_to :vehicle, optional: true
|
||||
|
||||
# The vehicle must belong to the issue's customer. Only checked when either changes, so older
|
||||
# issues with a mismatch don't block unrelated edits.
|
||||
validate :vehicle_matches_customer, if: -> { will_save_change_to_vehicle_id? || will_save_change_to_customer_id? }
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def vehicle_matches_customer
|
||||
return if vehicle_id.blank?
|
||||
|
||||
if vehicle.nil?
|
||||
errors.add(:base, ::I18n.t(:error_vehicle_not_found_for_issue))
|
||||
elsif customer_id.present? && vehicle.customer_id != customer_id
|
||||
errors.add(:base, ::I18n.t(:error_vehicle_customer_mismatch, vehicle: vehicle.to_s))
|
||||
end
|
||||
end
|
||||
|
||||
end
|
||||
|
||||
Reference in new issue
Block a user