Commit Graph
23 Commits
Author SHA1 Message Date
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky 5eac85351d Register vehicle field with SubtaskFieldCopier and ensure uniqueness 2026-08-26 21:19:56 -04:00
ricky 9cc2af9cec Refactor vehicle views for improved formatting and note handling 2026-08-11 18:33:16 -04:00
ricky a9d0eafa40 Add vehicle appointment hook and localization for 'Add Vehicle' label 2026-08-10 19:04:58 -04:00
ricky 35542ba1b9 Fix vehicle name fallback not applied in select by replacing pluck with model instances 2026-04-09 09:42:45 -04:00
ricky 83a5811a37 Removed InvoiceHookListener registation 2026-03-29 21:55:41 -04:00
ricky a9354026bc removed InvoiceHookListener as support has been removed from redmine_qbo 2026-03-28 00:27:59 -04:00
ricky 097276e558 Updated patches and hooks 2026-03-21 12:23:23 -04:00
ricky a67b75671e updated logging with prefix 2026-03-04 20:57:12 -05:00
ricky 5cad4a6856 added js to copy vin on click 2026-02-13 21:28:45 -05:00
ricky 5165bc20b4 Changed display format of vehicle lists 2026-02-13 07:48:36 -05:00
ricky e09990cd42 added nil check 2026-01-30 17:04:23 -05:00
ricky 5a2832b751 need to supply selcted id 2026-01-30 07:49:51 -05:00
ricky 634fd96e82 Cleaned up pdf hook 2026-01-29 23:38:55 -05:00
ricky ce624f178f Updated comment 2026-01-29 23:33:42 -05:00
ricky 808b84a346 Cleaned up issue show hook 2026-01-29 23:32:12 -05:00
ricky e4d2df889d Cleaned up issue form hook 2026-01-29 23:22:09 -05:00
ricky 715c412668 removed unused invocie variable 2026-01-29 22:55:14 -05:00
ricky e0a23bac20 Lose the hash rocket, use symbols 2026-01-29 22:52:17 -05:00
ricky 8eecdc0ddd added invoice hook listener to update invoice with VIN 2026-01-27 20:56:08 -05:00
ricky 2f49a21fed Removed legacy pfd patch 2026-01-27 20:25:08 -05:00
ricky 896d5a64ba Remove Project Level Integration 2026-01-27 18:04:32 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00