2026.4.2

app/controllers/items_controller.rb

@@ -100,8 +100,6 @@ class ItemsController < ApplicationController
     params.require(:item).permit(:name, :description, :sku, :unit_price, :active, :account_id, :type, :taxable)
   end
 
-  private 
-
   def log(msg)
     Rails.logger.info "[ItemsController] #{msg}"
   end

app/views/line_items/_issue_line_items.html.erb

@@ -1,39 +1,57 @@
-<% if @issue.line_items.any? %>
+<% if @issue.line_items.any? || @issue.descendant_line_items_total > 0%>
 <hr/>
 <div>
   <p><strong><%= t :label_line_items  %></strong></p>
 
-  <table class="list line-items-table">
-    <thead>
-      <tr>
-        <th style="width:70%;"><%= t :label_description %></th>
-        <th style="width:10%;"><%= t :label_qty %></th>
-        <th style="width:10%;"><%= t :label_price %></th>
-        <th style="width:10%;"><%= t :label_total %></th>
-      </tr>
-    </thead>
+  <% total = 0 %>
 
-    <tbody>
-      <% total = 0 %>
-
-      <% @issue.line_items.each do |item| %>
-        <% line_total = item.quantity.to_f * item.unit_price.to_f %>
-        <% total += line_total %>
+  <% if @issue.line_items.any?%>
 
+    <table class="list line-items-table">
+      <thead>
         <tr>
-          <td><%= h item.description %></td>
-          <td><%= item.quantity %></td>
-          <td><%= number_to_currency(item.unit_price) %></td>
-          <td><%= number_to_currency(line_total) %></td>
+          <th style="width:70%;"><%= t :label_description %></th>
+          <th style="width:10%;"><%= t :label_qty %></th>
+          <th style="width:10%;"><%= t :label_price %></th>
+          <th style="width:10%;"><%= t :label_total %></th>
+        </tr>
+      </thead>
+
+      <tbody>
+
+        <% @issue.line_items.each do |item| %>
+          <% line_total = item.quantity.to_f * item.unit_price.to_f %>
+          <% total += line_total %>
+
+          <tr>
+            <td><%= h item.description %></td>
+            <td><%= item.quantity %></td>
+            <td><%= number_to_currency(item.unit_price) %></td>
+            <td><%= number_to_currency(line_total) %></td>
+          </tr>
+        <% end %>
+      </tbody>
+
+      <% end %>
+
+      <tfoot>
+        <% if @issue.line_items.any?%>
+          <tr>
+            <td colspan="3" style="text-align:right;"><strong><%= t :label_total %></strong></td>
+            <td>
+              <strong><%= number_to_currency(total) %></strong>
+            </td>
+          </tr>
+        <% end %>
+
+      <% if @issue.descendant_line_items_total > 0 %>
+        <tr>
+          <td colspan="3" style="text-align:right;"><strong><%= t :label_running_total %></strong></td>
+          <td>
+            <strong>(<%= number_to_currency(@issue.descendant_line_items_total + total) %>)</strong>
+          </td>
         </tr>
       <% end %>
-    </tbody>
-
-    <tfoot>
-      <tr>
-        <td colspan="3" style="text-align:right;"><strong><%= t :label_total %></strong></td>
-        <td><strong><%= number_to_currency(total) %></strong></td>
-      </tr>
     </tfoot>
   </table>
 </div>

config/locales/en.yml

@@ -33,6 +33,7 @@ en:
   label_no: "No"
   label_qty: "Quantity"
   label_remove: "Remove"
+  label_running_total: "Running Total"
   label_sync_now_accounts: "Sync Accounts"
   label_sync_now_items: "Sync Items"
   label_type: "Type"

init.rb

@@ -14,7 +14,7 @@ Redmine::Plugin.register :redmine_qbo_lineitems do
   name 'Redmine QBO Line Items plugin'
   author 'Rick Barrette'
   description 'A plugin for Redmine to extend the capabilitys of the Redmine QuickBooks Online plugin to attach billable line items to an isuue'
-  version '2026.3.11'
+  version '2026.4.2'
   url 'https://github.com/rickbarrette/redmine_qbo_lineitems'
   author_url 'https://barrettefabrication.com'
   requires_redmine version_or_higher: '6.1.0'

lib/line_items/patches/issue_patch.rb

@@ -10,14 +10,65 @@
 
 module LineItems
   module Patches
-    module IssuePatch
-      extend ActiveSupport::Concern
+    module IssuePatch extend ActiveSupport::Concern
       
       prepended do
         has_many :line_items, dependent: :destroy
-        accepts_nested_attributes_for :line_items, 
-          allow_destroy: true, 
-          reject_if: proc { |attrs| attrs['description'].blank? }
+        accepts_nested_attributes_for :line_items, allow_destroy: true, reject_if: proc { |attrs| attrs['description'].blank? }
+
+        # Returns line items for immediate children
+        def children_line_items
+          LineItem.where(issue_id: self.children.pluck(:id))
+        end
+
+        # Calculates the total value of all child line items
+        def children_line_items_total
+          children_line_items.sum(:line_total)
+        end
+
+        # Returns line items for the entire tree below this issue
+        def descendant_line_items
+          LineItem.where(issue_id: self.descendants.pluck(:id))
+        end
+
+        # Calculates the total value of entire tree below this issue
+        def descendant_line_items_total
+          descendant_line_items.sum(:line_total)
+        end
+
+        def line_items_total
+          line_items.sum(:line_total)
+        end
+
+        def line_items_attributes=(attrs)
+          attrs = attrs.stringify_keys
+
+          # IDs submitted in the form
+          submitted_ids = attrs.values.map { |a| a['id'] }.compact.map(&:to_s)
+
+          # Existing IDs in DB
+          existing_ids = line_items.pluck(:id).map(&:to_s)
+
+          # Find missing ones (these would be implicitly deleted by Rails)
+          missing_ids = existing_ids - submitted_ids
+
+          # Re-add missing records so Rails doesn't delete them
+          missing_ids.each do |id|
+            attrs["preserve_#{id}"] = { 'id' => id }
+          end
+
+          # Only allow explicit deletes or valid updates/creates
+          filtered = attrs.select do |_, item_attrs|
+            item_attrs['_destroy'] == '1' ||
+              item_attrs['id'].present? ||
+              item_attrs['description'].present?
+          end
+
+          super(filtered)
+        rescue => e
+          logger.error "Error processing line items attributes: #{e.message}"
+        end
+
       end
     end
   end