mirror of
https://github.com/rickbarrette/redmine_qbo.git
synced 2026-11-17 18:20:36 -05:00
Security - Connecting to QuickBooks (authenticate/oauth_callback) and all syncs are admin-only; the OAuth state is stored and verified on callback - New "Bill issue time to QuickBooks" project permission; billing is now a POST and checks the permission and issue visibility - Estimate/invoice PDFs require a logged-in user, or a customer share link limited to the estimate and invoices attached to that issue (the old require_user check never ran) - Attachments patch keeps the share token per request instead of in Thread.current, so it can't leak into other requests Permissions and share links - customers#autocomplete and the filter_* actions are part of View customers, so non-admins can pick customers on forms - customers#view no longer goes through authorize_global; share needs the new "Share issues with customers" permission and a visible issue - Removed a check in customers#view that compared a value to itself Bugs - Subjects and customer names capitalize each word without lowercasing the rest (LED, JL, 4x4 stay as typed); subjects only when changed - Settings page shows Invoice/Estimate sync times (Item/Account models no longer exist) - customers#update shows validation errors instead of reporting success - Billing marks each activity billed once sent to QBO, so retries and token refreshes don't create duplicate TimeActivities Search - New CustomerSearchService for autocomplete and the customer search page: nicknames (Bill/William), typos, word order, partial words, accents, and phone digits in any format; ranked, with the candidate list cached until a customer changes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
122 lines
4.6 KiB
Ruby
122 lines
4.6 KiB
Ruby
#The MIT License (MIT)
|
|
#
|
|
#Copyright (c) 2016 - 2026 rick barrette
|
|
#
|
|
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
|
|
#
|
|
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
class Customer < QboBaseModel
|
|
|
|
include Redmine::Acts::Searchable
|
|
include Redmine::Acts::Event
|
|
|
|
has_many :issues
|
|
has_many :invoices
|
|
has_many :estimates
|
|
validates_presence_of :name
|
|
before_validation :normalize_phone_numbers
|
|
self.primary_key = :id
|
|
qbo_sync push: true
|
|
|
|
# Normalize the local database column :name (capitalize each word, keep acronyms like LLC as typed)
|
|
normalizes :name, with: ->(name) { RedmineQbo::TitleCase.call(name.to_s.strip) }
|
|
|
|
acts_as_searchable columns: %w[name phone_number mobile_phone_number ],
|
|
scope: ->(_context) { left_joins(:project) },
|
|
date_column: :updated_at
|
|
|
|
acts_as_event :title => Proc.new {|o| "#{o}"},
|
|
:url => Proc.new {|o| { :controller => 'customers', :action => 'show', :id => o.id} },
|
|
:type => :to_s,
|
|
:description => Proc.new {|o| "#{I18n.t :label_primary_phone}: #{o.phone_number} #{I18n.t:label_mobile_phone}: #{o.mobile_phone_number}"},
|
|
:datetime => Proc.new {|o| o.updated_at || o.created_at}
|
|
|
|
# Returns the customer's email address
|
|
def email
|
|
return details&.email_address&.address
|
|
end
|
|
|
|
# Updates the customer's email address
|
|
def email=(s)
|
|
details.email_address = s
|
|
end
|
|
|
|
# Customers are not bound by a project
|
|
# but we need to implement this method for the Redmine::Acts::Searchable interface
|
|
def project
|
|
nil
|
|
end
|
|
|
|
# returns the customer's mobile phone
|
|
def mobile_phone
|
|
return details&.mobile_phone&.free_form_number
|
|
end
|
|
|
|
# Updates the custome's mobile phone number
|
|
def mobile_phone=(n)
|
|
pn = Quickbooks::Model::TelephoneNumber.new
|
|
pn.free_form_number = n
|
|
details.mobile_phone = pn
|
|
end
|
|
|
|
# Updates Both local DB name & QBO display_name
|
|
def name=(s)
|
|
super(s)
|
|
# Write the normalized value from Active Record to QBO details
|
|
details.display_name = self.name
|
|
end
|
|
|
|
# Normalizes phone numbers by removing non-digit characters. This method is called before validation to ensure that phone numbers are stored in a consistent format, which can help with searching and integration with external systems like QuickBooks Online.
|
|
def normalize_phone_numbers
|
|
self.phone_number = phone_number.to_s.gsub(/\D/, '') if phone_number.present?
|
|
self.mobile_phone_number = mobile_phone_number.to_s.gsub(/\D/, '') if mobile_phone_number.present?
|
|
end
|
|
|
|
# Sets the notes for the customer
|
|
def notes=(s)
|
|
details.notes = s
|
|
end
|
|
|
|
# returns the customer's primary phone
|
|
def primary_phone
|
|
return details&.primary_phone&.free_form_number
|
|
end
|
|
|
|
# Updates the customer's primary phone number
|
|
def primary_phone=(n)
|
|
pn = Quickbooks::Model::TelephoneNumber.new
|
|
pn.free_form_number = n
|
|
details.primary_phone = pn
|
|
end
|
|
|
|
# Seach for customers by name or phone number
|
|
def self.search(search)
|
|
#return none if search.blank?
|
|
search = sanitize_sql_like(search)
|
|
where("name LIKE ? OR phone_number LIKE ? OR mobile_phone_number LIKE ?", "%#{search}%", "%#{search}%", "%#{search}%")
|
|
end
|
|
|
|
# Override the defult redmine seach method to rank results by id
|
|
def self.search_result_ranks_and_ids(tokens, user, project = nil, options = {})
|
|
return {} if tokens.blank?
|
|
|
|
scope = self.all
|
|
|
|
tokens.each do |token|
|
|
scope = scope.search(token)
|
|
end
|
|
|
|
ids = scope.distinct.limit(options[:limit] || 100).pluck(:id)
|
|
ids.index_with { |id| id }
|
|
end
|
|
|
|
# returns a human readable string
|
|
def to_s
|
|
last4 = phone_number&.last(4)
|
|
last4.present? ? "#{name} - #{last4}" : name.to_s
|
|
end
|
|
|
|
end |