mirror of
https://github.com/rickbarrette/redmine_qbo.git
synced 2026-11-17 18:20:36 -05:00
Security - Connecting to QuickBooks (authenticate/oauth_callback) and all syncs are admin-only; the OAuth state is stored and verified on callback - New "Bill issue time to QuickBooks" project permission; billing is now a POST and checks the permission and issue visibility - Estimate/invoice PDFs require a logged-in user, or a customer share link limited to the estimate and invoices attached to that issue (the old require_user check never ran) - Attachments patch keeps the share token per request instead of in Thread.current, so it can't leak into other requests Permissions and share links - customers#autocomplete and the filter_* actions are part of View customers, so non-admins can pick customers on forms - customers#view no longer goes through authorize_global; share needs the new "Share issues with customers" permission and a visible issue - Removed a check in customers#view that compared a value to itself Bugs - Subjects and customer names capitalize each word without lowercasing the rest (LED, JL, 4x4 stay as typed); subjects only when changed - Settings page shows Invoice/Estimate sync times (Item/Account models no longer exist) - customers#update shows validation errors instead of reporting success - Billing marks each activity billed once sent to QBO, so retries and token refreshes don't create duplicate TimeActivities Search - New CustomerSearchService for autocomplete and the customer search page: nicknames (Bill/William), typos, word order, partial words, accents, and phone digits in any format; ranked, with the candidate list cached until a customer changes Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
58 lines
2.7 KiB
Ruby
58 lines
2.7 KiB
Ruby
#The MIT License (MIT)
|
|
#
|
|
#Copyright (c) 2016 - 2026 rick barrette
|
|
#
|
|
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
|
|
#
|
|
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
class InvoicesController < ApplicationController
|
|
include AuthHelper
|
|
|
|
# PDFs: logged-in users, or a customer with a share link (limited to their issue's invoices).
|
|
# Redmine's own login check is replaced by require_login_or_customer_token for this action.
|
|
skip_before_action :check_if_login_required, only: :show
|
|
before_action :require_login_or_customer_token, only: :show
|
|
before_action :authorize_customer_invoices, only: :show
|
|
|
|
# Syncing is admin-only
|
|
before_action :require_admin, only: :sync
|
|
|
|
# Displays the invoice PDF in the browser or redirects with an error if not found.
|
|
def show
|
|
log "Processing request for #{request.original_url}"
|
|
|
|
pdf, ref = PdfService.new(entity: Invoice).fetch_pdf(doc_ids: invoice_ids)
|
|
|
|
send_data pdf, filename: "invoice #{ref}.pdf", disposition: :inline, type: "application/pdf"
|
|
|
|
rescue StandardError => e
|
|
log "Invoice PDF failure: #{e.message}"
|
|
redirect_back fallback_location: root_path, flash: { error: I18n.t(:notice_invoice_not_found) }
|
|
end
|
|
|
|
def sync
|
|
Invoice.sync
|
|
redirect_to :home, flash: { notice: I18n.t(:label_syncing) }
|
|
end
|
|
|
|
private
|
|
|
|
def invoice_ids
|
|
@invoice_ids ||= Array(params[:invoice_ids] || params[:id]).map(&:to_s).reject(&:blank?)
|
|
end
|
|
|
|
# Share-link customers may only open invoices attached to their issue
|
|
def authorize_customer_invoices
|
|
return true unless customer_token_only?
|
|
|
|
allowed = customer_token.issue&.invoice_ids.to_a.map(&:to_s)
|
|
render_403 if invoice_ids.empty? || (invoice_ids - allowed).any?
|
|
end
|
|
|
|
# Logs messages with a consistent prefix for easier debugging.
|
|
def log(msg)
|
|
Rails.logger.info "[InvoiceController] #{msg}"
|
|
end
|
|
end |