mirror of
https://github.com/rickbarrette/stopwatch.git
synced 2026-11-17 19:50:36 -05:00
Timer safety: length limit, server-side saving, stop on close
- Maximum timer length setting (default 10h): a timer that runs past it is stopped at the limit and its entry's comment is flagged, so a forgotten timer can't add a night or weekend of hours - StopwatchTimerTickJob saves a running timer's time every minute on the server (no browser needed) and stops it at the limit on time; open tabs keep saving too - Timer updates lock the user's preference row and re-read the timer, so simultaneous saves (several tabs, the job) never add time twice - Closing an issue stops timers running on it before anything else (e.g. billing) uses its time; deleting a time entry only stops the timer running on that entry - Issue timers require a visible issue; starting again moves the timer instead of raising "timer is already running" - Tests updated and extended (limit, locking, tick job, close, delete, visibility, issue context menu); CI runs on Redmine 7.0 - Upstream's German notes translated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
15 files changed
+366
-36
No files matched your search
@@ -1,12 +1,12 @@
|
||||
# weiter
|
||||
# Ideas carried over from upstream (translated from the original German notes):
|
||||
#
|
||||
# - update title / menu item after starting new entry
|
||||
# - update time entry row after context menu stop (reflect saved time)
|
||||
# - 0:60 anstelle 1:00? Redmine-bug?
|
||||
# - update title / menu item after starting a new entry
|
||||
# - update the time entry row after stopping from the context menu (show the saved time)
|
||||
# - 0:60 instead of 1:00? Redmine bug?
|
||||
#
|
||||
# - remember last activity, preselect that in 'new' form
|
||||
# - same for project, unless we are in a project context
|
||||
# - focus first field that needs an action, depending on above
|
||||
# - remember the last activity and preselect it in the 'new' form
|
||||
# - same for the project, unless we are in a project context
|
||||
# - focus the first field that needs input, depending on the above
|
||||
#
|
||||
class StopwatchTimersController < StopwatchController
|
||||
|
||||
@@ -86,6 +86,8 @@ class StopwatchTimersController < StopwatchController
|
||||
|
||||
private
|
||||
|
||||
# Saves the elapsed time into the running entry (also done every minute on the server by
|
||||
# StopwatchTimerTickJob). Safe from several tabs at once: Timer#update locks the timer record.
|
||||
def find_timer
|
||||
@timer = Stopwatch::Timer.new User.current
|
||||
@timer.update
|
||||
|
||||
Reference in new issue
Block a user