mirror of
https://github.com/rickbarrette/stopwatch.git
synced 2026-11-17 19:50:36 -05:00
Timer safety: length limit, server-side saving, stop on close
- Maximum timer length setting (default 10h): a timer that runs past it is stopped at the limit and its entry's comment is flagged, so a forgotten timer can't add a night or weekend of hours - StopwatchTimerTickJob saves a running timer's time every minute on the server (no browser needed) and stops it at the limit on time; open tabs keep saving too - Timer updates lock the user's preference row and re-read the timer, so simultaneous saves (several tabs, the job) never add time twice - Closing an issue stops timers running on it before anything else (e.g. billing) uses its time; deleting a time entry only stops the timer running on that entry - Issue timers require a visible issue; starting again moves the timer instead of raising "timer is already running" - Tests updated and extended (limit, locking, tick job, close, delete, visibility, issue context menu); CI runs on Redmine 7.0 - Upstream's German notes translated Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
15 files changed
+366
-36
No files matched your search
@@ -41,8 +41,11 @@ class StopwatchIssueTimersController < StopwatchController
|
||||
User.current.allowed_to?(:log_time, @project) or deny_access
|
||||
end
|
||||
|
||||
# Only issues the user can see (log_time on the project alone isn't enough)
|
||||
def find_issue
|
||||
@issue = Issue.find params[:issue_id]
|
||||
@issue = Issue.visible.find_by(id: params[:issue_id])
|
||||
return render_404 unless @issue
|
||||
|
||||
@project = @issue.project
|
||||
end
|
||||
end
|
||||
Reference in new issue
Block a user