mirror of
https://github.com/rickbarrette/simple-aircraft-manager-rails.git
synced 2026-11-17 15:50:36 -05:00
- Admin → Settings → Who can add aircraft: administrators only (the default) or everyone. Adding an aircraft or importing a .sam.zip makes you its Owner, so this decides who can become one. - A signing invitation from an Owner of the aircraft (or an administrator) lets the outside mechanic create an account for the invited address again, with a password or by signing in with SSO; checked when it's used. Others' signing invitations still need an existing account, and say so. - Docs: who makes accounts, the new setting. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
191 lines
7.4 KiB
Ruby
191 lines
7.4 KiB
Ruby
require "test_helper"
|
|
|
|
class SsoTest < ActionDispatch::IntegrationTest
|
|
include ActionMailer::TestHelper
|
|
SSO_ENV = { "OIDC_ISSUER" => "https://auth.example.com/application/o/sam/", "OIDC_CLIENT_ID" => "sam", "OIDC_PROVIDER_NAME" => "Authentik" }.freeze
|
|
KEYS = SSO_ENV.keys + %w[OIDC_AUTO_CREATE_USERS OIDC_TRUST_EMAIL OIDC_ADMIN_GROUP PASSWORD_LOGIN]
|
|
|
|
setup do
|
|
@saved = KEYS.to_h { [ _1, ENV[_1] ] }
|
|
SSO_ENV.each { ENV[_1] = _2 }
|
|
OmniAuth.config.test_mode = true
|
|
@user = create_user("jane@example.com")
|
|
end
|
|
|
|
teardown do
|
|
@saved.each { ENV[_1] = _2 }
|
|
OmniAuth.config.mock_auth[:oidc] = nil
|
|
OmniAuth.config.test_mode = false
|
|
end
|
|
|
|
def mock(uid: "sub-1", email: "jane@example.com", verified: true, groups: nil, name: "Jane Pilot")
|
|
raw = { "email_verified" => verified }
|
|
raw["groups"] = groups if groups
|
|
OmniAuth.config.mock_auth[:oidc] = OmniAuth::AuthHash.new(provider: "oidc", uid: uid, info: { email: email, name: name }, extra: { raw_info: raw })
|
|
end
|
|
|
|
def sso_sign_in
|
|
post "/auth/oidc"
|
|
follow_redirect! # to the callback
|
|
end
|
|
|
|
test "sign-in page offers SSO; a verified email links the existing account" do
|
|
get new_session_path
|
|
assert_select "form[action='/auth/oidc'] button", text: "Sign in with Authentik"
|
|
assert_select "input[name=password]" # password sign-in still on
|
|
|
|
mock
|
|
sso_sign_in
|
|
assert_redirected_to root_url
|
|
assert_equal "sub-1", @user.reload.sso_uid
|
|
follow_redirect!
|
|
assert_response :success
|
|
|
|
delete session_path
|
|
mock(email: "changed@example.com") # matched by subject id from now on
|
|
sso_sign_in
|
|
assert_redirected_to root_url
|
|
end
|
|
|
|
test "an unverified email doesn't link (unless trusted) and nobody is created by default" do
|
|
mock(verified: false)
|
|
sso_sign_in
|
|
assert_redirected_to new_session_path
|
|
assert_match "There's no account for jane@example.com", flash[:alert]
|
|
assert_nil @user.reload.sso_uid
|
|
|
|
ENV["OIDC_TRUST_EMAIL"] = "true"
|
|
sso_sign_in
|
|
assert_redirected_to root_url
|
|
assert_equal "sub-1", @user.reload.sso_uid
|
|
end
|
|
|
|
test "auto-created users start with no aircraft; admin group is synced only when groups are sent" do
|
|
ENV["OIDC_AUTO_CREATE_USERS"] = "true"
|
|
ENV["OIDC_ADMIN_GROUP"] = "sam-admins"
|
|
mock(uid: "sub-2", email: "new@example.com", groups: [ "sam-admins" ])
|
|
assert_difference -> { User.count } do
|
|
sso_sign_in
|
|
end
|
|
created = User.find_by!(email_address: "new@example.com")
|
|
assert_equal [ "sub-2", "Jane Pilot", true ], [ created.sso_uid, created.name, created.admin? ]
|
|
assert_empty created.aircraft_roles
|
|
|
|
delete session_path
|
|
mock(uid: "sub-2", email: "new@example.com") # no groups claim: leave admin alone
|
|
sso_sign_in
|
|
assert created.reload.admin?
|
|
delete session_path
|
|
mock(uid: "sub-2", email: "new@example.com", groups: [ "pilots" ])
|
|
sso_sign_in
|
|
refute created.reload.admin?
|
|
end
|
|
|
|
test "linking and unlinking from the profile" do
|
|
sign_in @user
|
|
get edit_profile_path
|
|
assert_select "form[action='/auth/oidc'] button", text: "Link Authentik"
|
|
mock(uid: "sub-9", email: "someone-else@example.com", verified: false)
|
|
sso_sign_in
|
|
assert_redirected_to edit_profile_path
|
|
assert_equal "sub-9", @user.reload.sso_uid
|
|
|
|
other = create_user("other@example.com")
|
|
sign_in other
|
|
sso_sign_in
|
|
assert_match "already linked to another user", flash[:alert]
|
|
assert_nil other.reload.sso_uid
|
|
|
|
sign_in @user
|
|
delete sso_link_path
|
|
assert_nil @user.reload.sso_uid
|
|
end
|
|
|
|
test "password sign-in can be turned off" do
|
|
ENV["PASSWORD_LOGIN"] = "false"
|
|
get new_session_path
|
|
assert_select "input[name=password]", 0
|
|
post session_path, params: { email_address: "jane@example.com", password: "test-password-123" }
|
|
assert_redirected_to new_session_path
|
|
assert_match "Sign in with Authentik", flash[:alert]
|
|
post passwords_path, params: { email_address: "jane@example.com" }
|
|
assert_redirected_to new_session_path
|
|
assert_enqueued_emails 0
|
|
|
|
sign_in_attempt = -> { mock; sso_sign_in }
|
|
sign_in_attempt.()
|
|
assert_redirected_to root_url
|
|
delete sso_link_path
|
|
assert_match "would lock you out", flash[:alert]
|
|
end
|
|
|
|
test "failures and a disabled provider" do
|
|
get "/auth/failure", params: { message: "invalid_credentials" }
|
|
assert_redirected_to new_session_path
|
|
assert_equal "Authentik sign-in failed (invalid credentials).", flash[:alert]
|
|
|
|
ENV["OIDC_ISSUER"] = nil
|
|
get new_session_path
|
|
assert_select "form[action='/auth/oidc']", 0
|
|
get "/auth/oidc/callback"
|
|
assert_response :not_found
|
|
end
|
|
|
|
test "signing in with SSO makes an account only from an administrator's invitation" do
|
|
ENV.delete("OIDC_AUTO_CREATE_USERS")
|
|
mock(uid: "sub-new", email: "newbie@example.com", name: "New Bie")
|
|
sso_sign_in
|
|
assert_redirected_to new_session_path
|
|
assert_not User.exists?(email_address: "newbie@example.com")
|
|
|
|
owner = create_user("owner2@example.com")
|
|
aircraft = create_aircraft(owner: owner, tail_number: "N777AB")
|
|
owners = AccessInvitation.create_for(owner, { label: "From the owner", max_uses: 1 }, [ [ aircraft, Role.for_key("pilot") ] ])
|
|
get join_path(owners.token)
|
|
assert_select "form[action='/auth/oidc']", 0
|
|
sso_sign_in
|
|
assert_not User.exists?(email_address: "newbie@example.com")
|
|
|
|
admin = create_user("boss@example.com", admin: true)
|
|
invitation = AccessInvitation.create_for(admin, { label: "Club", max_uses: 1 }, [ [ aircraft, Role.for_key("pilot") ] ])
|
|
get join_path(invitation.token)
|
|
assert_select "form[action='/auth/oidc'] button", text: "Continue with Authentik"
|
|
sso_sign_in
|
|
assert_redirected_to root_url
|
|
assert_match "Welcome! Your account is ready. N777AB: Pilot", flash[:notice]
|
|
newbie = User.find_by!(email_address: "newbie@example.com")
|
|
assert_equal "sub-new", newbie.sso_uid
|
|
assert_equal "pilot", newbie.role_for(aircraft).key
|
|
assert_equal 1, invitation.reload.uses_count
|
|
end
|
|
|
|
test "an administrator's invitation for one address makes an account only for that address" do
|
|
ENV.delete("OIDC_AUTO_CREATE_USERS")
|
|
admin = create_user("boss@example.com", admin: true)
|
|
invitation = AccessInvitation.create_for(admin, { label: "For Kim", email: "kim@example.com", max_uses: 1 }, [])
|
|
get join_path(invitation.token)
|
|
mock(uid: "sub-x", email: "someone.else@example.com")
|
|
sso_sign_in
|
|
assert_not User.exists?(email_address: "someone.else@example.com")
|
|
assert_equal 0, invitation.reload.uses_count
|
|
end
|
|
|
|
test "an Owner's signing invitation makes the mechanic's account by signing in with SSO, for its address only" do
|
|
ENV.delete("OIDC_AUTO_CREATE_USERS")
|
|
owner = create_user("owner3@example.com")
|
|
aircraft = create_aircraft(owner: owner, tail_number: "N888CD")
|
|
entry = aircraft.logbook_entries.create!(date: Date.new(2026, 10, 1), log_type: "AC", entry_type: "MAINTENANCE", aircraft_hours_at_entry: 1000, text: "Oil changed.")
|
|
invitation = entry.signing_invitations.create!(email: "mech@example.com", invited_by: owner)
|
|
|
|
get invited_signing_path(invitation.token)
|
|
mock(uid: "sub-other", email: "not.mech@example.com")
|
|
sso_sign_in
|
|
assert_not User.exists?(email_address: "not.mech@example.com")
|
|
|
|
get invited_signing_path(invitation.token)
|
|
mock(uid: "sub-mech", email: "mech@example.com", name: "Mo Mechanic")
|
|
sso_sign_in
|
|
assert_equal "sub-mech", User.find_by!(email_address: "mech@example.com").sso_uid
|
|
end
|
|
end
|