Squawks: multiple attachments, in-app photo viewer, downloads

Existing single attachments migrate to the new list. Photos open in a
full-screen viewer (swipe/arrow keys); every file has a download link.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-06 09:51:04 -05:00
1 parent 21ef577653
commit ef542ee2a5
12 files changed
+267 -13

No files matched your search

@@ -0,0 +1,93 @@
require "test_helper"
class SquawkAttachmentsTest < ActionDispatch::IntegrationTest
setup do
@owner = create_user("owner@example.com")
@pilot = create_user("pilot@example.com")
@a = create_aircraft(owner: @owner, pilot: @pilot)
end
def upload(name, type = "text/plain", body = "file #{name}")
Rack::Test::UploadedFile.new(StringIO.new(body), type, original_filename: name)
end
test "a pilot can report a squawk with several files" do
sign_in @pilot
post aircraft_squawks_path(@a), params: { squawk: { priority: 1, issue_reported: "Cracked fairing",
attachments: [ "", upload("front.jpg", "image/jpeg"), upload("notes.txt") ] } }
squawk = @a.squawks.last
assert_equal %w[front.jpg notes.txt], squawk.attachments.map { _1.filename.to_s }.sort
get aircraft_squawks_path(@a)
assert_select "[data-controller=gallery]" do
assert_select "a[data-gallery-target=item][data-action='gallery#open'][href*='front.jpg']", text: /🖼/
assert_select "a[data-gallery-target=item]", 1 # only photos open in the viewer
assert_select "a[target=_blank][href*='notes.txt']", text: /📎/
assert_select "dialog[data-gallery-target=dialog] a[data-gallery-target=download]"
end
end
test "every file has a download link that forces a download" do
@a.squawks.create!(priority: 1, issue_reported: "x", attachments: [ upload("pic.png", "image/png"), upload("log.pdf", "application/pdf") ])
sign_in @pilot
get aircraft_squawks_path(@a)
downloads = css_select("a[download]").reject { _1["data-gallery-target"] }
assert_equal %w[log.pdf pic.png], downloads.map { _1["download"] }.sort
downloads.each do |link|
get link["href"]
follow_redirect! while response.redirect?
assert_match(/\Aattachment;/, response.headers["Content-Disposition"])
end
end
test "squawks with no photos get no viewer" do
@a.squawks.create!(priority: 1, issue_reported: "x", attachments: [ upload("notes.txt") ])
sign_in @pilot
get aircraft_squawks_path(@a)
assert_select "dialog", 0
assert_select "a[download='notes.txt']"
end
test "an owner can add files and remove some in one edit" do
squawk = @a.squawks.create!(priority: 1, issue_reported: "Oil leak", attachments: [ upload("a.txt"), upload("b.txt") ])
a_file = squawk.attachments.find { _1.filename.to_s == "a.txt" }
sign_in @owner
get edit_aircraft_squawk_path(@a, squawk)
assert_select "input[type=file][multiple][name='squawk[attachments][]']"
assert_select "input[type=checkbox][name='remove_attachment_ids[]']", 2
patch aircraft_squawk_path(@a, squawk), params: { squawk: { issue_reported: "Oil leak at sump", attachments: [ "", upload("c.txt") ] },
remove_attachment_ids: [ a_file.id ] }
assert_redirected_to aircraft_squawks_path(@a)
squawk.reload
assert_equal "Oil leak at sump", squawk.issue_reported
assert_equal %w[b.txt c.txt], squawk.attachments.map { _1.filename.to_s }.sort
end
test "editing without touching files keeps them" do
squawk = @a.squawks.create!(priority: 1, issue_reported: "x", attachments: [ upload("a.txt") ])
sign_in @owner
patch aircraft_squawk_path(@a, squawk), params: { squawk: { notes: "Ordered part", attachments: [ "" ] } }
assert_equal %w[a.txt], squawk.reload.attachments.map { _1.filename.to_s }
end
test "a bad file rejects the whole edit and removes nothing" do
squawk = @a.squawks.create!(priority: 1, issue_reported: "Oil leak", attachments: [ upload("a.txt") ])
sign_in @owner
patch aircraft_squawk_path(@a, squawk), params: { squawk: { issue_reported: "Changed", attachments: [ upload("run.exe", "application/x-msdownload") ] },
remove_attachment_ids: [ squawk.attachments.first.id ] }
assert_response :unprocessable_entity
assert_match "run.exe is not an allowed file type", response.body
squawk.reload
assert_equal "Oil leak", squawk.issue_reported
assert_equal %w[a.txt], squawk.attachments.map { _1.filename.to_s }
end
test "pilots can't edit a squawk's files" do
squawk = @a.squawks.create!(priority: 1, issue_reported: "x", attachments: [ upload("a.txt") ])
sign_in @pilot
patch aircraft_squawk_path(@a, squawk), params: { remove_attachment_ids: [ squawk.attachments.first.id ], squawk: { notes: "y" } }
assert_equal 1, squawk.reload.attachments.count
end
end