Smaller aircraft photos, one-row-per-item detail cards, push diagnostics

- Aircraft photos get 192px and 960x432 copies made on upload; the header,
  share page and Fleet cards use them (and the offline copies), instead of
  the full original.
- Flight, engine data, component and major record details show one label
  and value per row on phones (wide items no longer add grid columns).
- Profile re-records this device's push subscription on every visit, and
  says why if it can't; Send test delivers now and lists each device's
  result; Google's other push hosts are accepted; turning notifications on
  shows the browser's actual error.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-14 11:55:11 -05:00
1 parent 3f314a13bb
commit d4b71d17a1
21 files changed
+234 -96

No files matched your search

+30 -7
View File
@@ -57,12 +57,14 @@ class PwaFeaturesTest < ActionDispatch::IntegrationTest
@a.picture.attach(io: StringIO.new(file_fixture_png), filename: "plane.png", content_type: "image/png")
get root_path
picture = JSON.parse(css_select("body").first["data-offline-prep-aircraft-value"]).first["picture"]
shown = css_select("img[src*='/rails/active_storage/blobs/redirect/']").first["src"]
# Links expire, so they differ; both carry the same upload id, which the saved copy is filed under.
blob_id = ->(url) { JSON.parse(Base64.decode64(CGI.unescape(url[%r{/blobs/redirect/([^/]+?)--}, 1])))["_rails"]["data"] }
assert_equal @a.picture.blob.id, blob_id.(picture)
assert_equal @a.picture.blob.id, blob_id.(shown)
pictures = JSON.parse(css_select("body").first["data-offline-prep-aircraft-value"]).first["pictures"]
shown = css_select("img[src*='/rails/active_storage/representations/redirect/']").first["src"]
# Links expire, so they differ; both carry the same upload id and size,
# which the saved copy is filed under (the thumbnail and the Fleet card).
key = ->(url) { url.match(%r{/representations/redirect/([^/]+?)--[^/]+/([^/]+)/}).then { [ JSON.parse(Base64.decode64(CGI.unescape(_1[1])))["_rails"]["data"], _1[2] ] } }
assert_equal 2, pictures.size
assert_equal [ @a.picture.blob.id ], pictures.map { key.(_1).first }.uniq
assert_includes pictures.map(&key), key.(shown)
end
test "squawks can be reported offline and are received once" do
@@ -121,13 +123,34 @@ class PwaFeaturesTest < ActionDispatch::IntegrationTest
assert_response :created
post push_subscription_path, params: { subscription: subscription_params("https://internal.example.com/b") }, as: :json
assert_response :unprocessable_entity
assert_includes response.parsed_body["error"], "internal.example.com"
assert_equal [ "https://fcm.googleapis.com/fcm/send/a" ], @owner.push_subscriptions.pluck(:endpoint)
assert_enqueued_with(job: PushNotificationJob) { post test_push_subscription_path, as: :json }
delete push_subscription_path, params: { endpoint: "https://fcm.googleapis.com/fcm/send/a" }, as: :json
assert_empty @owner.push_subscriptions.reload
end
test "the test notification is sent now and says which devices took it" do
sign_in @owner
ok = subscribe(@owner, "https://fcm.googleapis.com/fcm/send/phone")
ok.update!(user_agent: "Mozilla/5.0 (Linux; Android 16; Pixel) AppleWebKit/537.36 Chrome/142.0 Mobile Safari/537.36")
refused = subscribe(@owner, "https://web.push.apple.com/tablet")
refused.update!(user_agent: "Mozilla/5.0 (iPad; CPU OS 18_0 like Mac OS X) AppleWebKit/605.1.15 Version/18.0 Safari/604.1")
stub_request(:post, ok.endpoint).to_return(status: 201)
stub_request(:post, refused.endpoint).to_return(status: 400, body: "BadJwtToken")
post test_push_subscription_path, as: :json
devices = response.parsed_body["devices"]
assert_equal [ "Chrome · Android", nil ], devices.first.values_at("device", "error")
assert_equal "Safari · iPad", devices.last["device"]
assert_match "BadJwtToken", devices.last["error"]
end
test "Google's other push hosts are accepted" do
assert subscribe(@owner, "https://jmt17.google.com/fcm/send/x").persisted?
assert subscribe(@owner, "https://fcm.googleapis.com/wp/y").persisted?
end
test "notifications are encrypted to each device; gone devices are forgotten" do
live = subscribe(@pilot, "https://fcm.googleapis.com/fcm/send/live")
gone = subscribe(@pilot, "https://fcm.googleapis.com/fcm/send/gone")
+18
View File
@@ -74,4 +74,22 @@ class WorkflowPolishTest < ActionDispatch::IntegrationTest
get aircraft_path(@a)
assert_select "[data-controller=dismiss]", 0
end
test "aircraft pages show a small copy of the photo, made when it's uploaded" do
perform_enqueued_jobs { @a.picture.attach(io: StringIO.new(Vips::Image.black(1200, 900).jpegsave_buffer), filename: "plane.jpg", content_type: "image/jpeg") }
assert_equal 2, @a.picture.blob.variant_records.count, "both sizes are made on upload"
sign_in @owner
get aircraft_path(@a)
assert_select "img[src*='/representations/'][width='48']"
get aircraft_index_path
assert_select "img[src*='/representations/'][loading='lazy']"
end
test "a flight's details are one label and value per row" do
flight = @a.flight_logs.create!(date: Date.current, tach_out: 100, tach_in: 101, hobbs_out: 50, hobbs_in: 51, user: @owner)
sign_in @owner
get aircraft_flight_log_path(@a, flight)
assert_select "dl > div.detail-row > dt", minimum: 6
assert_select "dl dd.col-span-3", 0
end
end
+1 -1
View File
@@ -208,7 +208,7 @@ class AircraftArchiveTest < ActiveSupport::TestCase
assert_raises(RuntimeError) { importer.run }
assert_equal before[0, 2], [ Aircraft.count, Component.count ]
assert_equal 0, Aircraft.where(tail_number: "N999").count
perform_enqueued_jobs
perform_enqueued_jobs(only: ActiveStorage::PurgeJob) # (the stand-in photo isn't a real image to resize)
assert_equal before[2], ActiveStorage::Blob.count
end
end