Remove orphaned code and unused Solid Cable; simplify compliance status

- Delete methods nothing calls: BackupRun.last_good, EntrySignature#short_id,
  Sso#issuer_origin, InspectionType#effect_label and #latest_record_for,
  ApplicationHelper#airworthiness_dot, Airworthiness::Status#can_fly? and
  FlightStats#shortest_flight (tests now check red? / longest_flight)
- Routes: sessions and passwords limited to the actions that exist
- Theme toggle: drop the unused button target
- Action Cable was never used (no broadcasts or streams): async adapter in
  production, solid_cable gem, cable database and app/channels removed
- Empty system test setup removed with capybara and selenium-webdriver
- Compliance: one due_result helper for overdue / due soon; inspections use
  next_due for the date, as ADs do
- applicable_to moved into SharedRecordHistory (was identical in ADs and
  inspection types)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-13 21:04:41 -05:00
1 parent e939d29deb
commit bff6a05173
25 files changed
+34 -178

No files matched your search

-5
View File
@@ -1,5 +0,0 @@
require "test_helper"
class ApplicationSystemTestCase < ActionDispatch::SystemTestCase
driven_by :selenium, using: :headless_chrome, screen_size: [ 1400, 1400 ]
end
+1 -1
View File
@@ -37,7 +37,7 @@ class FlightStatsTest < ActiveSupport::TestCase
s = stats
assert_equal 3, s.count
assert_equal 1.8, s.average_flight
assert_equal [ 0.6, 3.5 ], [ s.shortest_flight, s.longest_flight ]
assert_equal 3.5, s.longest_flight
assert_equal 3, s.airports_visited
assert_equal [ "KOQU", 3 ], s.top_airports.first
+3 -2
View File
@@ -16,7 +16,8 @@ class InspectionRulesTest < ActiveSupport::TestCase
xpdr = type("Transponder (91.413)", recurring_months: 24, effect: "no_transponder")
done(xpdr, 3.years.ago.to_date)
aw = @a.reload.airworthiness
assert [ aw.limited?, aw.can_fly? ].all?
assert aw.limited?
assert_not aw.red?
assert_equal "No transponder", aw.label
assert_equal "LIMITED", aw.issues.sole.severity
@@ -30,7 +31,7 @@ class InspectionRulesTest < ActiveSupport::TestCase
annual = type("Annual", recurring_months: 12)
done(annual, 13.months.ago.to_date)
aw = @a.reload.airworthiness
assert_equal [ "RED", "Grounded", false ], [ aw.status, aw.label, aw.can_fly? ]
assert_equal [ "RED", "Grounded" ], [ aw.status, aw.label ]
assert_raises(AircraftGroundedError) { HoursService.new(@a).enforce_airworthiness! }
end
View File
Whitespace-only changes.