Remove orphaned code and unused Solid Cable; simplify compliance status

- Delete methods nothing calls: BackupRun.last_good, EntrySignature#short_id,
  Sso#issuer_origin, InspectionType#effect_label and #latest_record_for,
  ApplicationHelper#airworthiness_dot, Airworthiness::Status#can_fly? and
  FlightStats#shortest_flight (tests now check red? / longest_flight)
- Routes: sessions and passwords limited to the actions that exist
- Theme toggle: drop the unused button target
- Action Cable was never used (no broadcasts or streams): async adapter in
  production, solid_cable gem, cable database and app/channels removed
- Empty system test setup removed with capybara and selenium-webdriver
- Compliance: one due_result helper for overdue / due soon; inspections use
  next_due for the date, as ADs do
- applicable_to moved into SharedRecordHistory (was identical in ADs and
  inspection types)

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-13 21:04:41 -05:00
1 parent e939d29deb
commit bff6a05173
25 files changed
+34 -178

No files matched your search

+2 -10
View File
@@ -1,7 +1,4 @@
# Async adapter only works within the same process, so for manually triggering cable updates from a console,
# and seeing results in the browser, you must do so from the web console (running inside the dev process),
# not a terminal started via bin/rails console! Add "console" to any action or any ERB template view
# to make the web console appear.
# Nothing in the app uses Action Cable, so it runs in-process with no database.
development:
adapter: async
@@ -9,9 +6,4 @@ test:
adapter: test
production:
adapter: solid_cable
connects_to:
database:
writing: cable
polling_interval: 0.1.seconds
message_retention: 1.day
adapter: async
-4
View File
@@ -35,7 +35,3 @@ production:
<<: *default
database: storage/production_queue.sqlite3
migrations_paths: db/queue_migrate
cable:
<<: *default
database: storage/production_cable.sqlite3
migrations_paths: db/cable_migrate
+2 -2
View File
@@ -3,7 +3,7 @@ Rails.application.routes.draw do
# (overrides Active Storage's open endpoint at the same path).
post "rails/active_storage/direct_uploads", to: "direct_uploads#create"
resource :session do
resource :session, only: %i[new create destroy] do
get :two_factor
post :two_factor, action: :verify_two_factor
end
@@ -18,7 +18,7 @@ Rails.application.routes.draw do
get "auth/failure", to: "sso#failure"
delete "profile/sso", to: "sso#destroy", as: :sso_link
delete "profile/sessions", to: "profiles#sign_out_others", as: :other_sessions
resources :passwords, param: :token
resources :passwords, param: :token, only: %i[new create edit update]
resource :setup, only: %i[new create], controller: "setup"
resource :profile, only: %i[edit update]
resources :certificates, path: "profile/certificates", controller: "user_certificates", only: %i[create update destroy]