mirror of
https://github.com/rickbarrette/simple-aircraft-manager-rails.git
synced 2026-11-17 23:50:36 -05:00
Remove orphaned code and unused Solid Cable; simplify compliance status
- Delete methods nothing calls: BackupRun.last_good, EntrySignature#short_id, Sso#issuer_origin, InspectionType#effect_label and #latest_record_for, ApplicationHelper#airworthiness_dot, Airworthiness::Status#can_fly? and FlightStats#shortest_flight (tests now check red? / longest_flight) - Routes: sessions and passwords limited to the actions that exist - Theme toggle: drop the unused button target - Action Cable was never used (no broadcasts or streams): async adapter in production, solid_cable gem, cable database and app/channels removed - Empty system test setup removed with capybara and selenium-webdriver - Compliance: one due_result helper for overdue / due soon; inspections use next_due for the date, as ADs do - applicable_to moved into SharedRecordHistory (was identical in ADs and inspection types) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
e939d29deb
commit
bff6a05173
25 files changed
+34
-178
No files matched your search
@@ -30,12 +30,6 @@ class AirworthinessDirective < ApplicationRecord
|
||||
find_by("upper(replace(name, ' ', '')) = ?", normalize_number(number).delete(" "))
|
||||
end
|
||||
|
||||
def self.applicable_to(aircraft)
|
||||
direct = joins(:aircraft).where(aircraft: { id: aircraft.id }).select(:id)
|
||||
via_component = joins(:components).where(components: { aircraft_id: aircraft.id }).select(:id)
|
||||
where(id: direct).or(where(id: via_component))
|
||||
end
|
||||
|
||||
def to_s = name
|
||||
|
||||
# [url, label] for this AD's document, when we have its link (DRS Excel
|
||||
|
||||
@@ -1,5 +1,4 @@
|
||||
class BackupRun < ApplicationRecord
|
||||
scope :latest_first, -> { order(created_at: :desc) }
|
||||
def self.latest = latest_first.first
|
||||
def self.last_good = where(ok: true).latest_first.first
|
||||
end
|
||||
@@ -15,6 +15,15 @@ module SharedRecordHistory
|
||||
before_destroy { linked_aircraft_ids.each { |id| history!(id, "destroy", attributes.except(*IGNORED)) } }
|
||||
end
|
||||
|
||||
class_methods do
|
||||
# Records that apply to the aircraft directly, or to one of its components.
|
||||
def applicable_to(aircraft)
|
||||
direct = joins(:aircraft).where(aircraft: { id: aircraft.id }).select(:id)
|
||||
via_component = joins(:components).where(components: { aircraft_id: aircraft.id }).select(:id)
|
||||
where(id: direct).or(where(id: via_component))
|
||||
end
|
||||
end
|
||||
|
||||
# Aircraft this record applies to, directly or through a component.
|
||||
def linked_aircraft_ids = (aircraft_ids + components.map(&:aircraft_id)).compact.uniq
|
||||
|
||||
|
||||
@@ -26,7 +26,6 @@ class EntrySignature < ApplicationRecord
|
||||
|
||||
def imported? = origin.present?
|
||||
def certificate_label = UserCertificate::SHORT_LABELS.fetch(certificate_kind, certificate_kind)
|
||||
def short_id = content_digest.first(12)
|
||||
|
||||
def compute_seal
|
||||
payload = [ logbook_entry_id, user_id, signer_name, certificate_kind, certificate_number, statement,
|
||||
|
||||
@@ -28,15 +28,7 @@ class InspectionType < ApplicationRecord
|
||||
|
||||
scope :ordered, -> { order(:name) }
|
||||
|
||||
# Applies to the aircraft directly, or to one of its components.
|
||||
def self.applicable_to(aircraft)
|
||||
direct = joins(:aircraft).where(aircraft: { id: aircraft.id }).select(:id)
|
||||
via_component = joins(:components).where(components: { aircraft_id: aircraft.id }).select(:id)
|
||||
where(id: direct).or(where(id: via_component))
|
||||
end
|
||||
|
||||
def to_s = name
|
||||
def effect_label = EFFECTS[effect]
|
||||
def limitation = LIMITATIONS[effect]
|
||||
def advisory? = effect == "advisory"
|
||||
|
||||
@@ -46,8 +38,6 @@ class InspectionType < ApplicationRecord
|
||||
InspectionRecord.for_aircraft(aircraft).where(inspection_type_id: [ id, *satisfied_by.ids ])
|
||||
end
|
||||
|
||||
def latest_record_for(aircraft) = records_for(aircraft).recent_first.first
|
||||
|
||||
def due_rule
|
||||
{ hours: recurring_hours.to_f, months: recurring_months, days: recurring_days } if recurring?
|
||||
end
|
||||
|
||||
@@ -33,13 +33,4 @@ module Sso
|
||||
ENV["APP_URL"].presence&.chomp("/") ||
|
||||
"#{ENV.fetch('FORCE_SSL', 'true') == 'true' ? 'https' : 'http'}://#{ENV.fetch('APP_HOST', 'localhost:3000')}"
|
||||
end
|
||||
|
||||
# Origin of the provider, for the CSP form-action list (the sign-in POST
|
||||
# redirects there).
|
||||
def issuer_origin
|
||||
uri = URI.parse(ENV["OIDC_ISSUER"].to_s)
|
||||
uri.host && "#{uri.scheme}://#{uri.host}#{":#{uri.port}" unless uri.port == uri.default_port}"
|
||||
rescue URI::InvalidURIError
|
||||
nil
|
||||
end
|
||||
end
|
||||
@@ -3,14 +3,14 @@
|
||||
class SystemInfo
|
||||
KEY_GEMS = %w[
|
||||
puma thruster propshaft importmap-rails turbo-rails stimulus-rails tailwindcss-rails tailwindcss-ruby
|
||||
solid_queue solid_cache solid_cable sqlite3 chartkick commonmarker anthropic
|
||||
solid_queue solid_cache sqlite3 chartkick commonmarker anthropic
|
||||
omniauth omniauth_openid_connect rubyzip roo pdf-reader bcrypt
|
||||
].freeze
|
||||
|
||||
# Where the source lives; APP_REPOSITORY_URL overrides it for a fork.
|
||||
REPOSITORY_URL = ENV["APP_REPOSITORY_URL"].presence || "https://github.com/rickbarrette/simple-aircraft-manager-rails"
|
||||
|
||||
DATABASES = { "Main" => :primary, "Cache" => :cache, "Jobs" => :queue, "Cable" => :cable }.freeze
|
||||
DATABASES = { "Main" => :primary, "Cache" => :cache, "Jobs" => :queue }.freeze
|
||||
|
||||
# The release version, YYYY.MM.N (the repository's VERSION file).
|
||||
def version
|
||||
|
||||
Reference in new issue
Block a user