mirror of
https://github.com/rickbarrette/simple-aircraft-manager-rails.git
synced 2026-11-17 23:50:36 -05:00
Restore thumbnails for photos recorded without dimensions
Photos uploaded before image processing was installed are marked analyzed with no width, so the "unreadable image" check showed them as file links. Every resizable image gets a thumbnail again; one that can't be read still falls back to the original when resizing fails. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
908c943e21
commit
a2672b99a3
4 files changed
+17
-20
No files matched your search
@@ -75,13 +75,18 @@ class MalformedInputTest < ActionDispatch::IntegrationTest
|
||||
assert_response :unprocessable_entity
|
||||
end
|
||||
|
||||
test "an image that can't be read is shown as the file, never resized" do
|
||||
@a.picture.attach(io: StringIO.new("GIF89a not really"), filename: "broken.gif", content_type: "image/gif")
|
||||
@a.picture.blob.update!(metadata: { identified: true, analyzed: true }) # analysis found no dimensions
|
||||
assert_kind_of ActiveStorage::Attached::One, @a.picture_for(:thumb)
|
||||
test "photos measured without dimensions (uploaded before image processing) still get thumbnails" do
|
||||
jpeg = Vips::Image.black(400, 300).jpegsave_buffer
|
||||
@a.picture.attach(io: StringIO.new(jpeg), filename: "old.jpg", content_type: "image/jpeg")
|
||||
@a.picture.blob.update!(metadata: { identified: true, analyzed: true }) # as older uploads were recorded
|
||||
get aircraft_path(@a)
|
||||
assert_response :success
|
||||
assert_select "img[src*='/representations/']", 0
|
||||
assert_select "img[src*='/representations/']"
|
||||
|
||||
squawk = @a.squawks.create!(issue_reported: "Leak", reported_by: @owner)
|
||||
squawk.attachments.attach(io: StringIO.new(jpeg), filename: "PXL_1.jpg", content_type: "image/jpeg")
|
||||
squawk.attachments.first.blob.update!(metadata: { identified: true, analyzed: true })
|
||||
get aircraft_squawks_path(@a)
|
||||
assert_select "a[data-gallery-target=item] img[src*='/representations/']"
|
||||
end
|
||||
|
||||
test "if resizing a photo fails anyway, the original is sent instead of an error" do
|
||||
|
||||
Reference in new issue
Block a user