mirror of
https://github.com/rickbarrette/simple-aircraft-manager-rails.git
synced 2026-11-17 23:50:36 -05:00
Fix nav/com and navigation database template citations
- "Swapping a tray-mounted nav/com unit" cited Part 43 Appendix A (c)(32), which doesn't exist; the item is (c)(31). Its wording now names that paragraph's conditions (self-contained, panel-mounted, tray-mounted, manufacturer's instructions, operational check before use). - "Updating the navigation database" called itself preventive maintenance under (c)(31). 14 CFR 43.3(k) says such an update isn't maintenance: it's now an Other entry citing 43.3(k), with no certificate type. - Built-in templates now take their entry type from the YAML (it was always Maintenance). - A migration fixes copies already in the database where an admin hasn't changed the text; edited ones are left alone. - Test: every built-in template is valid and cites an existing Appendix A paragraph. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
acb8b87ca3
commit
6697e835c8
5 files changed
+77
-7
No files matched your search
@@ -0,0 +1,31 @@
|
||||
require "test_helper"
|
||||
|
||||
class LogbookTemplateTest < ActiveSupport::TestCase
|
||||
test "every built-in template is valid and cites an existing Appendix A paragraph" do
|
||||
LogbookTemplate.defaults.each do |d|
|
||||
template = LogbookTemplate.new(d)
|
||||
assert template.valid?, "#{d['name']}: #{template.errors.full_messages.to_sentence}"
|
||||
# Part 43 Appendix A paragraph (c) runs from (1) to (31).
|
||||
d.values_at("reference", "text").join(" ").scan(/\(c\)\((\d+)\)/).flatten.each do |n|
|
||||
assert_includes 1..31, n.to_i, "#{d['name']} cites Appendix A (c)(#{n})"
|
||||
end
|
||||
end
|
||||
end
|
||||
|
||||
test "the tray-mounted nav/com swap cites (c)(31)" do
|
||||
LogbookTemplate.restore_defaults!
|
||||
swap = LogbookTemplate.find_by!(name: "Swapping a tray-mounted nav/com unit")
|
||||
assert_equal "Part 43 App. A (c)(31)", swap.reference
|
||||
assert_includes swap.text, "paragraph (c)(31)"
|
||||
assert_equal "PILOT", swap.certificate_type
|
||||
end
|
||||
|
||||
test "a navigation database update is recorded as a note, not preventive maintenance" do
|
||||
LogbookTemplate.restore_defaults!
|
||||
update = LogbookTemplate.find_by!(name: "Updating the navigation database")
|
||||
assert_equal "14 CFR 43.3(k)", update.reference
|
||||
assert_equal "OTHER", update.entry_type
|
||||
assert_nil update.certificate_type
|
||||
assert_not_includes update.text, "Preventive maintenance"
|
||||
end
|
||||
end
|
||||
Reference in new issue
Block a user