mirror of
https://github.com/rickbarrette/simple-aircraft-manager-rails.git
synced 2026-11-17 23:50:36 -05:00
Email test button and sign-in by emailed link
- Admin -> About: Email card (delivery, server, encryption, login name, From; never the password) and a "Send test email" button that sends immediately and shows the SMTP error if it fails - SMTP: implicit TLS on port 465 (or SMTP_TLS=true), auth only with a username, 10-15 s timeouts - "Email me a sign-in link": single-use (spent by any later sign-in via a monotonic users.last_signed_in_at), 15-minute expiry, confirm step so mail scanners can't use it up, same answer for unknown addresses, rate limited, off when PASSWORD_LOGIN=false - Admin -> Users shows last sign-in Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
1 parent
2b0a2f1949
commit
4f548f3874
23 files changed
+275
-12
No files matched your search
@@ -1,7 +1,20 @@
|
||||
class Admin::AboutController < ApplicationController
|
||||
before_action :require_admin!
|
||||
rate_limit to: 5, within: 1.minute, only: :test_email, with: -> { redirect_to admin_about_path, alert: "Try again in a minute." }
|
||||
|
||||
def show
|
||||
@info = SystemInfo.new
|
||||
end
|
||||
|
||||
# Sends right away (not via the job queue) so problems show up here.
|
||||
def test_email
|
||||
unless MailSettings.configured?
|
||||
return redirect_to admin_about_path, alert: "Email isn't set up yet: set SMTP_ADDRESS (and SMTP_PORT, SMTP_USERNAME, SMTP_PASSWORD, MAIL_FROM)."
|
||||
end
|
||||
AdminMailer.test_email(current_user).deliver_now
|
||||
redirect_to admin_about_path, notice: "Test email sent to #{current_user.email_address}. If it doesn't arrive, check the spam folder."
|
||||
rescue StandardError => e # SMTP, DNS, TLS and timeout errors alike
|
||||
Rails.logger.warn("[test email] #{e.class}: #{e.message}")
|
||||
redirect_to admin_about_path, alert: "Sending failed: #{e.class.name.demodulize}: #{e.message.to_s.squish.truncate(240)}"
|
||||
end
|
||||
end
|
||||
@@ -50,6 +50,7 @@ module Authentication
|
||||
end
|
||||
|
||||
def start_new_session_for(user)
|
||||
user.update_column(:last_signed_in_at, Time.current)
|
||||
user.sessions.create!(user_agent: request.user_agent, ip_address: request.remote_ip).tap do |session|
|
||||
Current.session = session
|
||||
cookies.signed.permanent[:session_id] = { value: session.id, httponly: true, same_site: :lax }
|
||||
|
||||
@@ -0,0 +1,43 @@
|
||||
# Sign in with a link sent by email instead of a password.
|
||||
#
|
||||
# Opening the link shows a confirm button rather than signing in straight
|
||||
# away: mail scanners that pre-open links would otherwise use up the one-time
|
||||
# link (and sign themselves in).
|
||||
class SignInLinksController < ApplicationController
|
||||
allow_unauthenticated_access
|
||||
before_action :require_email_sign_in
|
||||
before_action :set_user_by_token, only: %i[show consume]
|
||||
rate_limit to: 5, within: 15.minutes, only: :create, with: -> { redirect_to new_sign_in_link_path, alert: "Try again later." }
|
||||
rate_limit to: 20, within: 15.minutes, only: :consume, with: -> { redirect_to new_session_path, alert: "Try again later." }
|
||||
|
||||
def new
|
||||
end
|
||||
|
||||
def create
|
||||
if (user = User.find_by(email_address: params[:email_address].to_s))
|
||||
SessionsMailer.sign_in_link(user).deliver_later
|
||||
end
|
||||
# Same answer either way, so this can't be used to find accounts.
|
||||
redirect_to new_session_path, notice: "If there's an account for that address, a sign-in link is on its way. It works once, for 15 minutes."
|
||||
end
|
||||
|
||||
def show
|
||||
end
|
||||
|
||||
def consume
|
||||
reset_session # fresh session id after signing in
|
||||
start_new_session_for @user # also spends the link
|
||||
redirect_to root_path, notice: "Signed in."
|
||||
end
|
||||
|
||||
private
|
||||
|
||||
def require_email_sign_in
|
||||
redirect_to new_session_path, alert: "Sign in with #{Sso.label}." unless Sso.password_login?
|
||||
end
|
||||
|
||||
def set_user_by_token
|
||||
@user = User.find_by_token_for(:email_sign_in, params[:token].to_s)
|
||||
redirect_to new_sign_in_link_path, alert: "That sign-in link has expired or was already used. Get a new one below." unless @user
|
||||
end
|
||||
end
|
||||
Reference in new issue
Block a user