Markdown notes and a phone-friendly layout

- Notes render GitHub-flavored Markdown (commonmarker, sanitized), with a
  Write/Preview editor; overview shows a plain-text excerpt
- Phone header collapses into a menu; aircraft sections use a dropdown
- Tables stack into labelled cards under 640px (opt out with .table-keep)
- Fix horizontal overflow on overview and logbook; bigger touch targets;
  16px inputs to stop iOS zoom

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This commit is contained in:
rickyandClaude Opus 5.5 committed 2026-11-06 21:18:23 -05:00
1 parent 1c6c2f88c0
commit 230a569b77
19 files changed
+331 -15

No files matched your search

+22
View File
@@ -0,0 +1,22 @@
require "test_helper"
class MarkdownHelperTest < ActionView::TestCase
test "renders GitHub-flavored Markdown and keeps single line breaks" do
html = markdown("**Hangar** code 1234\nGate on the left\n\n- [x] Oil\n- [ ] Tires\n\n| A | B |\n|---|---|\n| 1 | 2 |")
assert_includes html, "<strong>Hangar</strong> code 1234<br>"
assert_includes html, '<input type="checkbox" checked="" disabled="">'
assert_includes html, "<td>1</td>"
assert_match(/\A<div class="markdown">/, html)
end
test "drops raw HTML and script links; links open in a new tab" do
html = markdown("<script>alert(1)</script>\n\nSee <img src=x onerror=alert(1)> [bad](javascript:alert(1)) https://example.com")
refute_match(/<script|<img|onerror|javascript:/i, html)
assert_includes html, '<a target="_blank" rel="noopener nofollow" href="https://example.com">'
end
test "excerpts are plain text" do
assert_equal "Oil leak at the sump Check it", markdown_excerpt("# Oil leak\nat the *sump*\n\n- Check it")
assert_equal "", markdown_excerpt(nil)
end
end
+39
View File
@@ -0,0 +1,39 @@
require "test_helper"
class NotesMarkdownTest < ActionDispatch::IntegrationTest
setup do
@owner = create_user
@pilot = create_user
@a = create_aircraft(owner: @owner, pilot: @pilot)
end
test "notes render Markdown on the notes tab, overview and share links" do
note = @a.notes.create!(text: "## Hangar\n**Code** 1234\n\n- [ ] Return key", public: true, user: @owner)
sign_in @pilot
get aircraft_notes_path(@a)
assert_select ".markdown h2", "Hangar"
assert_select ".markdown strong", "Code"
get aircraft_path(@a)
assert_includes response.body, "Hangar Code 1234 Return key"
token = @a.share_tokens.create!(privilege: "status")
get shared_path(token.token)
assert_select ".markdown strong", "Code"
assert note
end
test "the editor has Write/Preview tabs and the preview renders server-side" do
sign_in @pilot # pilots can add notes, so they can preview them too
get new_aircraft_note_path(@a)
assert_select "[data-controller=markdown-editor][data-markdown-editor-url-value='#{preview_aircraft_notes_path(@a)}']"
assert_select "textarea[name='aircraft_note[text]'][data-markdown-editor-target=input]"
post preview_aircraft_notes_path(@a), params: { text: "*hi* <script>x</script>" }
assert_response :success
assert_includes response.body, "<em>hi</em>"
refute_includes response.body, "<script"
sign_in create_user
post preview_aircraft_notes_path(@a), params: { text: "x" }
assert_response :not_found
end
end
+26
View File
@@ -0,0 +1,26 @@
require "test_helper"
class PhoneLayoutTest < ActionDispatch::IntegrationTest
setup do
@user = create_user("owner@example.com", admin: true)
@a = create_aircraft(owner: @user)
sign_in @user
end
test "phones get a compact header with one menu, and a section menu instead of the tab strip" do
get aircraft_components_path(@a)
assert_select "header nav.sm\\:hidden summary[aria-label=Menu]"
assert_select "header nav.sm\\:hidden form[action='#{session_path}']" # sign out lives in the menu
assert_select "header nav.sm\\:hidden a[href='#{admin_users_path}']"
assert_select "details.md\\:hidden summary", text: /Section\s*Components/
assert_select "details.md\\:hidden nav a[aria-current=page]", "Components"
assert_select "details.md\\:hidden nav a", count: 14
assert_select "nav.md\\:flex a.tab-active", "Components" # wider screens keep the tabs
end
test "wide grids opt out of the stacked phone table" do
@a.oil_analyses.create!(sample_date: Date.current, elements: { iron: 30 })
get aircraft_oil_analyses_path(@a)
assert_select "table.table.table-keep", 1
end
end