mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-17 18:40:36 -05:00
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
52 lines
1.5 KiB
ERB
52 lines
1.5 KiB
ERB
<% if vehicles.present? %>
|
|
|
|
<% vehicles.each do |vehicle| %>
|
|
<div class="row">
|
|
|
|
<div class="container">
|
|
|
|
<% if show_checkbox %>
|
|
<%= check_box_tag "vehicle_ids[]", vehicle.id, false, onchange: "updateLink()", data: { url: vehicle_path(vehicle).html_safe, text: vehicle.to_s }, class: "vehicle-checkbox appointment checkbox" %>
|
|
<% else %>
|
|
<div class='checkbox'>
|
|
</div>
|
|
<% end %>
|
|
|
|
<div class='label-main'>
|
|
<%= link_to vehicle.to_s, vehicle_path(vehicle) %>
|
|
</div>
|
|
|
|
<div class="label-sub">
|
|
<div onclick="handleCopy(event)"><%= vehicle.vin.scan(/.{1,9}/)[0] if vehicle.vin %><b><%=vehicle.vin.scan(/.{1,9}/)[1] if vehicle.vin%></b></div>
|
|
<% if show_customer %>
|
|
<%= vehicle.customer %>
|
|
<% end %>
|
|
|
|
<%
|
|
mileage = vehicle.last_service_mileage
|
|
%>
|
|
|
|
<% if mileage %>
|
|
<br/>
|
|
<b><%= t(:label_last_service) %></b> <%= vehicle.last_service_date %>
|
|
at <%= mileage %> <%= t(:label_miles) %>
|
|
<% end %>
|
|
|
|
</div>
|
|
<br/>
|
|
|
|
</div>
|
|
|
|
</div>
|
|
<% end %>
|
|
|
|
<div class="actions">
|
|
<%= will_paginate vehicles, param_name: (local_assigns[:page_param] || :page) %>
|
|
</div>
|
|
|
|
<%=t(:label_matching)%> <%= vehicles.respond_to?(:total_entries) ? vehicles.total_entries : vehicles.size %> <%=t(:field_vehicles) %>
|
|
|
|
<% else %>
|
|
<p><%=t(:label_no_vehicles)%> <%= params[:search] %>.</p>
|
|
<% end %>
|