Files
redmine_qbo_vehicles/app/controllers/vehicles_controller.rb
T
Claude d4684b8ae9 Fix vehicle dropdown after a customer change; drop vehicles.js
The issue form already reloads on the server when the customer changes
(redmine_qbo's updateIssueFrom), re-rendering the vehicle list for the
new customer. 0a3c734 broke that by always keeping the issue's current
vehicle in the list, so after changing the customer the previous
customer's vehicle stayed listed and selected.

- The current vehicle is only kept for an existing issue whose customer
  hasn't been changed in the form (keeps sold vehicles' history);
  otherwise only the selected customer's vehicles are offered
- Removes vehicles.js, which duplicated the form reload, its include and
  the JSON vehicle listing it used

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 19:09:47 -04:00

116 lines
4.3 KiB
Ruby

#The MIT License (MIT)
#
#Copyright (c) 2016 - 2026 rick barrette
#
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
#
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
#
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
class VehiclesController < ApplicationController
# Checks the vehicle permissions declared in init.rb (also requires login)
before_action :authorize_global
before_action :find_vehicle, only: [:show, :status, :edit, :update, :destroy]
# How long to wait before the status check may queue another VIN decode for the same vehicle
DECODE_REQUEST_THROTTLE = 5.minutes
def allowed_params
params.require(:vehicle).permit(:year, :make, :model, :customer_id, :notes, :vin)
end
# Vehicles for one customer, or search results
def index
if params[:customer_id].present?
@customer = Customer.find_by(id: params[:customer_id])
return render_404 unless @customer
@vehicles = @customer.vehicles.order(:year, :make, :model).paginate(page: params[:page])
return
end
if params[:search].present?
@vehicles = Vehicle.search_all(params[:search]).paginate(page: params[:page])
redirect_to @vehicles.first if @vehicles.total_entries == 1
end
end
# Form for a new vehicle, pre-filled with the customer when coming from a customer or appointment
def new
@vehicle = Vehicle.new(customer: Customer.find_by(id: params[:customer_id]))
end
def create
@vehicle = Vehicle.new(allowed_params)
if @vehicle.save
flash[:notice] = t :notice_vehicle_created
redirect_to @vehicle
else
# A duplicate VIN: point to the vehicle that already has it
@existing_vehicle = Vehicle.find_by(vin: @vehicle.vin) if @vehicle.errors.of_kind?(:vin, :taken)
render :new, status: :unprocessable_entity
end
end
def show
@vin = @vehicle.vin.scan(/.{1,9}/) if @vehicle.vin
@issues = @vehicle.issues
.joins(:status)
.includes(:estimate, :invoices, :status, :project, :tracker, :priority)
.order(id: :desc)
@open_issues = @issues.reject { |i| i.status.is_closed }
@closed_issues = @issues.select { |i| i.status.is_closed }
flash.now[:error] = t :alert_no_customer if @vehicle.customer.nil?
end
# Used by the polling script on the vehicle page while the VIN is being decoded
def status
# Queue a decode if it never happened (e.g. the job was lost), at most once per throttle window
if !@vehicle.vin_decoded? && @vehicle.error.blank?
key = "redmine_qbo_vehicles/vin_decode_requested/#{@vehicle.id}"
unless Rails.cache.exist?(key)
Rails.cache.write(key, true, expires_in: DECODE_REQUEST_THROTTLE)
VehicleVinDecodeJob.perform_later(@vehicle.id)
end
end
render json: { decoded: @vehicle.vin_decoded, error: @vehicle.error }
end
def edit
end
def update
if @vehicle.update(allowed_params)
flash[:notice] = t :notice_vehicle_updated
redirect_to @vehicle
else
render :edit, status: :unprocessable_entity
end
end
# Vehicles with issues can't be deleted (see Vehicle has_many :issues), to keep their history
def destroy
if @vehicle.destroy
flash[:notice] = t :notice_vehicle_deleted
redirect_to @vehicle.customer ? customer_path(@vehicle.customer) : vehicles_path
else
flash[:error] = t(:alert_vehicle_has_issues)
redirect_to @vehicle
end
end
private
def find_vehicle
@vehicle = Vehicle.find(params[:id])
rescue ActiveRecord::RecordNotFound
render_404
end
end