mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-17 18:40:36 -05:00
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
110 lines
3.1 KiB
ERB
110 lines
3.1 KiB
ERB
<h2><%=t(:field_vehicle)%> #<%=@vehicle.id%></h2>
|
|
|
|
<% unless @vehicle.vin_decoded? %>
|
|
<div id="vin-status" class="flash <%= @vehicle.error ? "error" : "notice" %>">
|
|
<% if @vehicle.error%>
|
|
<%= @vehicle.error %>
|
|
<% else %>
|
|
<%= t :notice_decoding_vin %>
|
|
<% end %>
|
|
</div>
|
|
<% end %>
|
|
|
|
<%= render partial: 'vehicles/details', locals: {vehicle: @vehicle} %>
|
|
|
|
<div class="splitcontent">
|
|
<div class="splitcontentleft">
|
|
<h4><%=t(:label_estimates)%>:</h4>
|
|
<%= render partial: 'estimates/list', locals: {estimates: @vehicle.estimates} %>
|
|
</div>
|
|
|
|
<div class="splitcontentleft">
|
|
<h4><%=t(:label_invoices)%>:</h4>
|
|
<%= render partial: 'invoices/list', locals: {invoices: @vehicle.invoices} %>
|
|
</div>
|
|
</div>
|
|
|
|
<h3><%=@open_issues.count%> <%=t(:label_open_issues)%></h3>
|
|
|
|
<%= render partial: 'issues/list_simple', locals: {issues: @open_issues} %>
|
|
|
|
<h3><%=@closed_issues.count%> <%=t(:label_closed_issues)%></h3>
|
|
|
|
<%= render partial: 'issues/list_simple', locals: {issues: (@closed_issues)} %>
|
|
|
|
<script>
|
|
(function() {
|
|
const statusUrl = <%= raw status_vehicle_path(@vehicle).to_json %>;
|
|
const timedOutMessage = <%= raw l(:notice_vin_decode_timed_out).to_json %>;
|
|
const checkFailedMessage = <%= raw l(:error_vin_status_check_failed).to_json %>;
|
|
const alreadyDecoded = <%= @vehicle.vin_decoded? ? 'true' : 'false' %>;
|
|
|
|
if (alreadyDecoded) return;
|
|
|
|
const interval = 3000;
|
|
let attempts = 0;
|
|
const maxAttempts = 40;
|
|
|
|
const statusEl = document.getElementById("vin-status");
|
|
|
|
const checkStatus = () => {
|
|
fetch(statusUrl, {
|
|
headers: { 'Accept': 'application/json' },
|
|
credentials: 'same-origin'
|
|
})
|
|
.then(res => {
|
|
if (!res.ok) throw new Error('HTTP ' + res.status);
|
|
return res.json();
|
|
})
|
|
.then(data => {
|
|
|
|
// SUCCESS → reload
|
|
if (data.decoded) {
|
|
window.location.reload();
|
|
return;
|
|
}
|
|
|
|
// ERROR → stop + show message
|
|
if (data.error) {
|
|
clearInterval(timer);
|
|
|
|
if (statusEl) {
|
|
statusEl.classList.remove("notice");
|
|
statusEl.classList.add("error");
|
|
statusEl.textContent = data.error;
|
|
}
|
|
|
|
console.warn("VIN decode failed:", data.error);
|
|
return;
|
|
}
|
|
|
|
// continue polling
|
|
attempts++;
|
|
if (attempts >= maxAttempts) {
|
|
clearInterval(timer);
|
|
|
|
if (statusEl) {
|
|
statusEl.classList.remove("notice");
|
|
statusEl.classList.add("warning");
|
|
statusEl.textContent = timedOutMessage;
|
|
}
|
|
|
|
console.warn("VIN decode polling timed out");
|
|
}
|
|
})
|
|
.catch(err => {
|
|
clearInterval(timer);
|
|
|
|
if (statusEl) {
|
|
statusEl.classList.remove("notice");
|
|
statusEl.classList.add("error");
|
|
statusEl.textContent = checkFailedMessage;
|
|
}
|
|
|
|
console.error("Polling error:", err);
|
|
});
|
|
};
|
|
|
|
const timer = setInterval(checkStatus, interval);
|
|
})();
|
|
</script> |