mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-17 18:40:36 -05:00
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
73 lines
2.1 KiB
ERB
73 lines
2.1 KiB
ERB
<div class="row">
|
|
<div class="span6 columns">
|
|
<fieldset>
|
|
|
|
<%= form_for @vehicle do |f| %>
|
|
<%= error_messages_for 'vehicle' %>
|
|
|
|
<% if @existing_vehicle %>
|
|
<p class="flash warning">
|
|
<%= l(:text_vin_already_on_file) %>
|
|
<%= link_to @existing_vehicle.to_s, vehicle_path(@existing_vehicle) %>
|
|
</p>
|
|
<% end %>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:field_customer)%>:
|
|
<div class="input">
|
|
<%= f.text_field :customer, class: "customer-name", autocomplete: "off", value: @vehicle.customer&.name, required: true,data: { autocomplete_url: "/customers/autocomplete" } %>
|
|
<%= f.hidden_field :customer_id, id: "customer_id" %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:label_year)%>:
|
|
<div class="input">
|
|
<%= f.number_field :year, autocomplete: "off" %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:label_make)%>:
|
|
<div class="input">
|
|
<%= f.text_field :make, autocomplete: "off" %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:label_model)%>:
|
|
<div class="input">
|
|
<%= f.text_field :model, autocomplete: "off" %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:field_vin)%>:
|
|
<div class="input">
|
|
<%= f.text_field :vin , autofocus: true %>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="clearfix">
|
|
<%=t(:field_notes)%>:
|
|
<div class="input">
|
|
<p>
|
|
<%= f.text_area :notes,
|
|
rows: 8,
|
|
class: 'wiki-edit',
|
|
style: 'width: 95%;',
|
|
id: 'vehicle_notes' %>
|
|
<%= wikitoolbar_for 'vehicle_notes' %>
|
|
</p>
|
|
</div>
|
|
</div>
|
|
|
|
<div class="actions">
|
|
<%= f.submit %>
|
|
</div>
|
|
<% end %>
|
|
|
|
</fieldset>
|
|
</div>
|
|
</div>
|