mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-18 02:40:37 -05:00
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
69 lines
3.1 KiB
Ruby
69 lines
3.1 KiB
Ruby
#The MIT License (MIT)
|
|
#
|
|
#Copyright (c) 2016 - 2026 rick barrette
|
|
#
|
|
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
|
|
#
|
|
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
class VehicleVinDecodeJob < ApplicationJob
|
|
queue_as :default
|
|
# Network trouble is retried; if it never succeeds, the error is shown on the vehicle page
|
|
retry_on VinDecoder::TransientError, wait: 2.minutes, attempts: 5 do |job, error|
|
|
vehicle_id = job.arguments.first
|
|
vehicle_id = vehicle_id.id if vehicle_id.respond_to?(:id)
|
|
Vehicle.find_by(id: vehicle_id)&.update_columns(error: error.message.to_s.truncate(255), vin_decoded: false)
|
|
end
|
|
|
|
# Takes a vehicle id (jobs queued by older versions may pass the Vehicle itself, which still works)
|
|
def perform(vehicle_or_id)
|
|
vehicle_id = vehicle_or_id.respond_to?(:id) ? vehicle_or_id.id : vehicle_or_id
|
|
log "Looking up VIN for vehicle ##{vehicle_id}"
|
|
vehicle = Vehicle.find_by(id: vehicle_id)
|
|
return unless vehicle&.vin.present?
|
|
result = VinDecoder.call(vehicle.vin)
|
|
|
|
unless result.success?
|
|
log "Failed to decode vin"
|
|
save_decode(vehicle, vin_decoded: false, error: result.error.to_s.truncate(255))
|
|
return
|
|
end
|
|
|
|
details = result.data
|
|
|
|
save_decode(vehicle,
|
|
year: details.year.presence || vehicle.year,
|
|
make: details.make.presence || vehicle.make,
|
|
model: details.model.presence || vehicle.model,
|
|
doors: details.doors.presence || vehicle.doors,
|
|
trim: details.trim.presence || vehicle.trim,
|
|
name: build_name(vehicle, details),
|
|
vin_decoded: true,
|
|
error: nil
|
|
)
|
|
end
|
|
|
|
private
|
|
|
|
# Saves decode results without validations: a vehicle whose customer was deleted in QuickBooks
|
|
# would otherwise fail "customer must exist" and lose its decoded details.
|
|
def save_decode(vehicle, attributes)
|
|
vehicle.assign_attributes(attributes)
|
|
vehicle.save(validate: false)
|
|
end
|
|
|
|
def build_name(vehicle, details)
|
|
if details.year && details.make && details.model
|
|
suffix = vehicle.vin.to_s[9..]
|
|
"#{details.year} #{details.make} #{details.model} - #{suffix}"
|
|
else
|
|
vehicle.vin
|
|
end
|
|
end
|
|
|
|
def log(msg)
|
|
Rails.logger.info "[VehicleVinDecodeJob] #{msg}"
|
|
end
|
|
end |