Commit Graph
8 Commits
Author SHA1 Message Date
Claude d7368388b6 Vehicle page: Edit and Delete in the contextual area instead of buttons
Moves Edit and Delete from buttons under the vehicle details to
Redmine's standard top-right contextual area (pencil and trash icons,
"e" access key, Redmine's delete confirmation). Same permissions; Delete
still only shows for vehicles without issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 23:11:03 -04:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky c38bced329 record errors and decode existing vins on migration 2026-03-26 07:51:38 -04:00
ricky 89dc3cd5f4 moved vin decoding into a job 2026-03-25 22:30:02 -04:00
ricky 28957c5dff fixed eager loading issue 2026-03-04 20:57:29 -05:00
ricky adcc116841 Add estimates and invoices sections to vehicle details view 2026-01-31 12:46:41 -05:00
ricky e0a23bac20 Lose the hash rocket, use symbols 2026-01-29 22:52:17 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00