Commit Graph
12 Commits
Author SHA1 Message Date
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky df41436e61 Implement global permissions for vehicle actions and update version to 2026.9.0 2026-09-08 22:56:47 -04:00
ricky 9cc2af9cec Refactor vehicle views for improved formatting and note handling 2026-08-11 18:33:16 -04:00
ricky 9d101fef38 Add last service date and mileage methods to Vehicle model and update views 2026-08-11 18:07:43 -04:00
ricky 7158a8b02c Add fallback for last service date and introduce 'unknown' label 2026-08-08 14:30:11 -04:00
ricky 16e3d79ea8 Added last serviced date & mileage to vehicle details 2026-08-03 08:30:53 -04:00
ricky f163f6518b Use DIV and not A for vin element 2026-02-20 19:46:55 -05:00
ricky ed38584ab2 updated js to copy clicked link text. Also don't need id tags any more. 2026-02-16 21:32:00 -05:00
ricky 5cad4a6856 added js to copy vin on click 2026-02-13 21:28:45 -05:00
ricky b02a40827d Added flash notification for deleted customers. 2026-02-13 08:01:02 -05:00
ricky a30d8f56d8 added nil check for customer (if a customer is deleted after a merge) 2026-02-11 19:43:52 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00