The appointment page's Add Vehicle link (shown when the appointment has none)
now carries the appointment and a back_url. Creating the vehicle calls a new
:controller_vehicles_new_after_save hook; this plugin's listener sets the
vehicle on that appointment (same customer, no vehicle yet, user may edit
appointments) and the form redirects back to the appointment. The calendar
plugin is unchanged.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Access
- VIN decode status (polled by the vehicle page) is part of View
vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
require_user)
Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes
VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
(was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
was deleted in QBO still get decoded
Bugs
- Failed create/update re-render the form with errors (create used to
redirect to a possibly missing vehicle); duplicate VINs link to the
vehicle on file
- New vehicle without a customer, unknown customer ids and missing
vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
one query per vehicle, using a configurable mileage field (plugin
settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM