Commit Graph
7 Commits
Author SHA1 Message Date
rickyandClaude Opus 5.5 ce6c7a7046 Show the vehicle by name in issue history
The history showed the vehicle as an id number. It now shows its name, for existing
entries too.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-03 21:53:14 -05:00
rickyandClaude Opus 5.5 2074ec65b9 Fill the vehicle into issue subjects (<VEHICLE>)
An issue subject containing the placeholder (e.g. an issue template's "Frame Evaluation // <VEHICLE>") gets
the issue's vehicle when it's saved with one: on creation, or the first save after a vehicle is added
(journaled like any subject change). The placeholder is a plugin setting, "Vehicle in subjects": <VEHICLE>
by default (also for settings saved before it existed), blank turns it off.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
2026-11-02 18:23:07 -05:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky 097276e558 Updated patches and hooks 2026-03-21 12:23:23 -04:00
ricky 2f49a21fed Removed legacy pfd patch 2026-01-27 20:25:08 -05:00
ricky 896d5a64ba Remove Project Level Integration 2026-01-27 18:04:32 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00