Commit Graph
14 Commits
Author SHA1 Message Date
Claude 129a9f668c VIN click-to-copy: shared snippet, last 8 bold only for 17-char VINs
- New vehicles/_vin partial used on the issue page, vehicle page and
  vehicle lists (replaces three copies of the markup, inline onclick
  handlers and a fixed id="copyLink")
- 17-character VINs show the last 8 in bold (what dealerships ask for
  when ordering parts); older or short VINs are shown plain
- Copies the VIN from a data attribute, restores the exact display
  afterwards, shows "Copied!" or "Couldn't copy", falls back when the
  Clipboard API isn't available, and supports Enter/Space; pointer
  cursor and "Click to copy" tooltip
- The copy script is written into the page by the layout hook instead
  of served as copy.js, so it can't 404 when Redmine's asset manifest
  is out of date; one listener handles every VIN on the page
- Issue PDFs split 17-character VINs before the last 8; others whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:09:27 -04:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky a9d0eafa40 Add vehicle appointment hook and localization for 'Add Vehicle' label 2026-08-10 19:04:58 -04:00
ricky 7158a8b02c Add fallback for last service date and introduce 'unknown' label 2026-08-08 14:30:11 -04:00
ricky bdfad0d020 Added translation for Vehicle 2026-08-06 16:22:27 -04:00
ricky 16e3d79ea8 Added last serviced date & mileage to vehicle details 2026-08-03 08:30:53 -04:00
ricky 89dc3cd5f4 moved vin decoding into a job 2026-03-25 22:30:02 -04:00
ricky 452568e8b3 fixed search label 2026-02-21 08:45:42 -05:00
ricky 6db87dd551 search for a vehicle by vin, make, model, or year, plus sql sanitization 2026-02-21 08:33:59 -05:00
ricky 92cc7222fb feat(i18n): sort en.yml and fix typos
Alphabetized keys for better maintainability.

Fixed spelling errors in customer and vehicle keys/values.

Corrected "QuickBooks Online" branding.
2026-02-13 22:25:43 -05:00
ricky b02a40827d Added flash notification for deleted customers. 2026-02-13 08:01:02 -05:00
ricky 717a61b024 Updated flash notices to use locale 2026-01-30 19:49:48 -05:00
ricky db3c8be03d removed label_no_customers 2026-01-27 21:07:59 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00