redmine_qbo now handles QuickBooks custom fields generically; this plugin claims the fields named like
VIN and Mileage (Vehicles::QboFields) and supplies their behaviour:
- qbo_billing_issue_values keyed by field id; qbo_billing_field_options (the customer's vehicles for the
VIN box) and qbo_billing_field_defaults (the work orders' VIN and highest mileage) replace the VIN hooks.
- Editor script (view_qbo_estimate_form_bottom): VINs in capitals; importing time or estimates fills the
VIN from the work orders' vehicle (or an estimate's own VIN), warns about several vehicles, and fills
the highest mileage. The several-vehicle and missing-VIN-field texts moved here.
- qbo_calendar_appointment_params: an appointment added from an estimate gets the vehicle with its VIN.
- The estimate's VIN is read through redmine_qbo's generic custom_field_value.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
- Vehicles::EstimateVehicle.vin uses RedmineQboBilling::EstimateWriter.vin_for, which includes
QuickBooks' newer custom fields; the local estimate's details don't, so the VIN never matched and
issues created from an estimate got no vehicle.
- qbo_billing_default_vin only answers for work orders (no customer-vehicle fallback), so new
estimates and invoices start blank.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
redmine_qbo's Create issues page gets a Vehicle for all the issues (view hook
view_qbo_estimate_issues_form): preselected with the appointment's vehicle, else the customer's vehicle
matching the estimate's VIN. When none matches, or the estimate has no VIN, it says so, so the team can
pick one first. The chosen vehicle (or none) is what qbo_billing_build_issue puts on the issues.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
- Mileage for invoices (the Mileage issue custom field) now comes from this plugin's
qbo_billing_issue_values answer, alongside the VIN.
- qbo_billing_vin_options: the customer's vehicles as VIN suggestions in the estimate/invoice editor.
- qbo_billing_build_issue: issues created from an estimate get the appointment's vehicle, or the
customer's vehicle whose VIN is on the estimate.
- Vehicle checkboxes on the customer page say which New issue field they fill (data-new-issue-param).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Listens for redmine_qbo_billing's hooks: qbo_billing_issue_values gives each
work order's VIN, so the invoice's VIN box fills in when its time or
estimates are imported; qbo_billing_validate stops an invoice whose work
orders are for more than one vehicle (one vehicle per invoice).
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Matches the on-screen VIN: 17-character VINs show the last 8 in bold
(what dealerships ask for), older or short VINs plain. Uses
redmine_qbo's HTML values in the PDF grid when available; with an older
redmine_qbo the last 8 are set apart with a space as before.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
- New vehicles/_vin partial used on the issue page, vehicle page and
vehicle lists (replaces three copies of the markup, inline onclick
handlers and a fixed id="copyLink")
- 17-character VINs show the last 8 in bold (what dealerships ask for
when ordering parts); older or short VINs are shown plain
- Copies the VIN from a data attribute, restores the exact display
afterwards, shows "Copied!" or "Couldn't copy", falls back when the
Clipboard API isn't available, and supports Enter/Space; pointer
cursor and "Click to copy" tooltip
- The copy script is written into the page by the layout hook instead
of served as copy.js, so it can't 404 when Redmine's asset manifest
is out of date; one listener handles every VIN on the page
- Issue PDFs split 17-character VINs before the last 8; others whole
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
The issue form already reloads on the server when the customer changes
(redmine_qbo's updateIssueFrom), re-rendering the vehicle list for the
new customer. 0a3c734 broke that by always keeping the issue's current
vehicle in the list, so after changing the customer the previous
customer's vehicle stayed listed and selected.
- The current vehicle is only kept for an existing issue whose customer
hasn't been changed in the form (keeps sold vehicles' history);
otherwise only the selected customer's vehicles are offered
- Removes vehicles.js, which duplicated the form reload, its include and
the JSON vehicle listing it used
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Access
- VIN decode status (polled by the vehicle page) is part of View
vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
require_user)
Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes
VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
(was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
was deleted in QBO still get decoded
Bugs
- Failed create/update re-render the form with errors (create used to
redirect to a possibly missing vehicle); duplicate VINs link to the
vehicle on file
- New vehicle without a customer, unknown customer ids and missing
vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
one query per vehicle, using a configurable mileage field (plugin
settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM