Commit Graph
42 Commits
Author SHA1 Message Date
Claude 53991ed087 Add Vehicle from an appointment sets it there and returns
The appointment page's Add Vehicle link (shown when the appointment has none)
now carries the appointment and a back_url. Creating the vehicle calls a new
:controller_vehicles_new_after_save hook; this plugin's listener sets the
vehicle on that appointment (same customer, no vehicle yet, user may edit
appointments) and the form redirects back to the appointment. The calendar
plugin is unchanged.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-11-01 13:11:41 -05:00
Claude 70f4ce7e4a Own the QuickBooks VIN and Mileage fields
redmine_qbo now handles QuickBooks custom fields generically; this plugin claims the fields named like
VIN and Mileage (Vehicles::QboFields) and supplies their behaviour:

- qbo_billing_issue_values keyed by field id; qbo_billing_field_options (the customer's vehicles for the
  VIN box) and qbo_billing_field_defaults (the work orders' VIN and highest mileage) replace the VIN hooks.
- Editor script (view_qbo_estimate_form_bottom): VINs in capitals; importing time or estimates fills the
  VIN from the work orders' vehicle (or an estimate's own VIN), warns about several vehicles, and fills
  the highest mileage. The several-vehicle and missing-VIN-field texts moved here.
- qbo_calendar_appointment_params: an appointment added from an estimate gets the vehicle with its VIN.
- The estimate's VIN is read through redmine_qbo's generic custom_field_value.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 11:34:28 -04:00
Claude d987746c40 Vehicle picker on the Create issues from estimate page
redmine_qbo's Create issues page gets a Vehicle for all the issues (view hook
view_qbo_estimate_issues_form): preselected with the appointment's vehicle, else the customer's vehicle
matching the estimate's VIN. When none matches, or the estimate has no VIN, it says so, so the team can
pick one first. The chosen vehicle (or none) is what qbo_billing_build_issue puts on the issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 10:25:02 -04:00
Claude 7ea286b288 Take over the vehicle parts of redmine_qbo's billing
- Mileage for invoices (the Mileage issue custom field) now comes from this plugin's
  qbo_billing_issue_values answer, alongside the VIN.
- qbo_billing_vin_options: the customer's vehicles as VIN suggestions in the estimate/invoice editor.
- qbo_billing_build_issue: issues created from an estimate get the appointment's vehicle, or the
  customer's vehicle whose VIN is on the estimate.
- Vehicle checkboxes on the customer page say which New issue field they fill (data-new-issue-param).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-31 09:12:52 -04:00
Claude 9583bf52a8 Vehicle new/edit pages in Redmine's form style
- labelled_form_for with a "box tabular" form, like core Redmine forms:
  labels on the left, required fields (customer, VIN) marked with *
- Breadcrumb headings ("Vehicles » vehicle"), Create/Save buttons and a
  Cancel link (back to the vehicle, or the customer for new vehicles)
- Field order: customer, VIN, year, make, model, notes; the VIN field
  is limited to 17 characters and keeps focus
- Keeps redmine_qbo's customer autocomplete and the duplicate-VIN link

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 23:16:23 -04:00
Claude d7368388b6 Vehicle page: Edit and Delete in the contextual area instead of buttons
Moves Edit and Delete from buttons under the vehicle details to
Redmine's standard top-right contextual area (pencil and trash icons,
"e" access key, Redmine's delete confirmation). Same permissions; Delete
still only shows for vehicles without issues.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 23:11:03 -04:00
Claude 7901edeec1 VIN click-to-copy fills its cell, like the Mileage copy
The VIN was inline-block, so only its text was clickable; the Mileage
value on issues is clickable across the whole value cell. Same font,
size, colour and "Copied!" feedback as before.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:33:12 -04:00
Claude 129a9f668c VIN click-to-copy: shared snippet, last 8 bold only for 17-char VINs
- New vehicles/_vin partial used on the issue page, vehicle page and
  vehicle lists (replaces three copies of the markup, inline onclick
  handlers and a fixed id="copyLink")
- 17-character VINs show the last 8 in bold (what dealerships ask for
  when ordering parts); older or short VINs are shown plain
- Copies the VIN from a data attribute, restores the exact display
  afterwards, shows "Copied!" or "Couldn't copy", falls back when the
  Clipboard API isn't available, and supports Enter/Space; pointer
  cursor and "Click to copy" tooltip
- The copy script is written into the page by the layout hook instead
  of served as copy.js, so it can't 404 when Redmine's asset manifest
  is out of date; one listener handles every VIN on the page
- Issue PDFs split 17-character VINs before the last 8; others whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:09:27 -04:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky feb357b9a4 Fix syntax error in permission check for adding vehicles 2026-09-09 21:39:59 -04:00
ricky df41436e61 Implement global permissions for vehicle actions and update version to 2026.9.0 2026-09-08 22:56:47 -04:00
ricky b2f65f90b6 Dynamically update the new issue link with vehicle id 2026-08-17 21:05:09 -04:00
ricky 9cc2af9cec Refactor vehicle views for improved formatting and note handling 2026-08-11 18:33:16 -04:00
ricky 9d101fef38 Add last service date and mileage methods to Vehicle model and update views 2026-08-11 18:07:43 -04:00
ricky a9d0eafa40 Add vehicle appointment hook and localization for 'Add Vehicle' label 2026-08-10 19:04:58 -04:00
ricky 7158a8b02c Add fallback for last service date and introduce 'unknown' label 2026-08-08 14:30:11 -04:00
ricky 16e3d79ea8 Added last serviced date & mileage to vehicle details 2026-08-03 08:30:53 -04:00
ricky c38bced329 record errors and decode existing vins on migration 2026-03-26 07:51:38 -04:00
ricky 89dc3cd5f4 moved vin decoding into a job 2026-03-25 22:30:02 -04:00
ricky ea73878c71 renamed issue_customer_id to customer_id 2026-03-19 18:07:36 -04:00
ricky 8ec60c8cd7 updated to new autocomplete 2026-03-19 10:20:50 -04:00
ricky 28957c5dff fixed eager loading issue 2026-03-04 20:57:29 -05:00
ricky 4b8b3c3495 Update search form ID for consistency 2026-02-21 19:06:23 -05:00
ricky b2c1bebea3 show_checkbox: true 2026-02-21 14:07:03 -05:00
ricky 2bd13a819b Removed unneeded BR 2026-02-21 14:00:34 -05:00
ricky 452568e8b3 fixed search label 2026-02-21 08:45:42 -05:00
ricky 6db87dd551 search for a vehicle by vin, make, model, or year, plus sql sanitization 2026-02-21 08:33:59 -05:00
ricky f163f6518b Use DIV and not A for vin element 2026-02-20 19:46:55 -05:00
ricky a89f9881a6 added show_customer and show_checkbox options to vehicle list 2026-02-16 22:01:31 -05:00
ricky ed38584ab2 updated js to copy clicked link text. Also don't need id tags any more. 2026-02-16 21:32:00 -05:00
ricky 4bcccbd2f1 Fixed formatting, missing </b> 2026-02-13 22:31:59 -05:00
ricky 92cc7222fb feat(i18n): sort en.yml and fix typos
Alphabetized keys for better maintainability.

Fixed spelling errors in customer and vehicle keys/values.

Corrected "QuickBooks Online" branding.
2026-02-13 22:25:43 -05:00
ricky 82e25314f3 removed unused spans 2026-02-13 21:38:34 -05:00
ricky 5cad4a6856 added js to copy vin on click 2026-02-13 21:28:45 -05:00
ricky b02a40827d Added flash notification for deleted customers. 2026-02-13 08:01:02 -05:00
ricky 5165bc20b4 Changed display format of vehicle lists 2026-02-13 07:48:36 -05:00
ricky a30d8f56d8 added nil check for customer (if a customer is deleted after a merge) 2026-02-11 19:43:52 -05:00
ricky f649d4e902 added checkbox for appointment link javascript 2026-02-09 21:44:23 -05:00
ricky 2db17f3675 Fixed display of vehcile notes 2026-02-05 14:07:24 -05:00
ricky adcc116841 Add estimates and invoices sections to vehicle details view 2026-01-31 12:46:41 -05:00
ricky e0a23bac20 Lose the hash rocket, use symbols 2026-01-29 22:52:17 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00