Commit Graph
37 Commits
Author SHA1 Message Date
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky b021ca9f7d Bump version to 2026.9.1 2026-09-09 21:40:23 -04:00
ricky df41436e61 Implement global permissions for vehicle actions and update version to 2026.9.0 2026-09-08 22:56:47 -04:00
ricky 849dcabff7 Bump version to 2026.8.2 2026-08-26 21:23:06 -04:00
ricky 05bbcb43db Version 2026.8.1 2026-08-12 08:42:33 -04:00
ricky fe81cb6ff8 Version 2026.8.0 2026-08-10 19:36:43 -04:00
ricky 6da0972476 2026.4.1 2026-04-09 09:43:04 -04:00
ricky cc94401a1f 2026.4.0 2026-04-09 09:32:00 -04:00
ricky 35bd41d289 2026.3.4 2026-03-28 00:28:11 -04:00
ricky ba313dfd02 2026.3.3 2026-03-26 08:11:43 -04:00
ricky 030340b35e 2026.3.2 2026-03-22 14:28:04 -04:00
ricky 097276e558 Updated patches and hooks 2026-03-21 12:23:23 -04:00
ricky ea73878c71 renamed issue_customer_id to customer_id 2026-03-19 18:07:36 -04:00
ricky 8ec60c8cd7 updated to new autocomplete 2026-03-19 10:20:50 -04:00
ricky 9a1678d353 2026.3.0 2026-03-04 21:00:43 -05:00
ricky e0fc07141c 2026.2.8 2026-02-25 22:13:18 -05:00
ricky 4f2ae19460 2026.2.7 2026-02-22 19:13:20 -05:00
ricky 550601b5c9 Merge branch 'dev' 2026-02-21 19:09:29 -05:00
ricky 85cd02b16a 2026.2.6 2026-02-21 19:07:06 -05:00
ricky d6138843f8 Started to extend redmine's search 2026-02-21 09:22:04 -05:00
ricky a709fecd0c 2026.2.5 2026-02-21 08:34:33 -05:00
ricky a73b6cd438 2026.2.4 2026-02-20 19:48:55 -05:00
ricky dba8381913 2026.2.3 2026-02-14 18:56:22 -05:00
ricky 12fb8b47ef 2026.2.2 2026-02-13 08:01:39 -05:00
ricky f30d735e52 2026.2.1 2026-02-11 19:45:08 -05:00
ricky d22fcd4f66 2026.2.0 2026-02-09 21:52:40 -05:00
ricky d37933fe82 2026.1.7
Added vehicle estimates & invoices to vehicle page
2026-01-31 13:00:19 -05:00
ricky 48deb3b7c8 2026.1.6 2026-01-30 21:32:56 -05:00
ricky a932551b96 2026.1.5 2026-01-30 17:08:39 -05:00
ricky ad8aa8e2e8 use locale 2026-01-30 08:07:11 -05:00
ricky 707abc00a9 Use symbols 2026-01-30 08:05:57 -05:00
ricky 1199af0886 2026.1.4 2026-01-30 07:50:26 -05:00
ricky 6fc2db5d73 2026.1.3 2026-01-30 07:21:11 -05:00
ricky e0a23bac20 Lose the hash rocket, use symbols 2026-01-29 22:52:17 -05:00
ricky 2f960c65f0 Version 2026.1.2 2026-01-27 21:09:14 -05:00
ricky 896d5a64ba Remove Project Level Integration 2026-01-27 18:04:32 -05:00
ricky 68c1ec01fa Inital Commit 2026-01-26 23:24:10 -05:00