Commit Graph
107 Commits
Author SHA1 Message Date
Claude 129a9f668c VIN click-to-copy: shared snippet, last 8 bold only for 17-char VINs
- New vehicles/_vin partial used on the issue page, vehicle page and
  vehicle lists (replaces three copies of the markup, inline onclick
  handlers and a fixed id="copyLink")
- 17-character VINs show the last 8 in bold (what dealerships ask for
  when ordering parts); older or short VINs are shown plain
- Copies the VIN from a data attribute, restores the exact display
  afterwards, shows "Copied!" or "Couldn't copy", falls back when the
  Clipboard API isn't available, and supports Enter/Space; pointer
  cursor and "Click to copy" tooltip
- The copy script is written into the page by the layout hook instead
  of served as copy.js, so it can't 404 when Redmine's asset manifest
  is out of date; one listener handles every VIN on the page
- Issue PDFs split 17-character VINs before the last 8; others whole

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 20:09:27 -04:00
Claude d4684b8ae9 Fix vehicle dropdown after a customer change; drop vehicles.js
The issue form already reloads on the server when the customer changes
(redmine_qbo's updateIssueFrom), re-rendering the vehicle list for the
new customer. 0a3c734 broke that by always keeping the issue's current
vehicle in the list, so after changing the customer the previous
customer's vehicle stayed listed and selected.

- The current vehicle is only kept for an existing issue whose customer
  hasn't been changed in the form (keeps sold vehicles' history);
  otherwise only the selected customer's vehicles are offered
- Removes vehicles.js, which duplicated the form reload, its include and
  the JSON vehicle listing it used

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-29 19:09:47 -04:00
ricky 133322460e 2026.10.0 2026.10.0 2026-10-28 23:26:20 -04:00
Claude 3f0455c6d5 Replace nhtsa_vin gem with a built-in NHTSA vPIC client
The nhtsa_vin gem is unmaintained (last release 2019, source repository
gone). VinDecoder now calls NHTSA's free vPIC DecodeVinValues endpoint
directly with Net::HTTP and JSON from the standard library.

- Same fields as before (year, make, model, trim, doors), plus body
  class, engine and NHTSA's warning text
- Sends the year on file as NHTSA's model-year hint
- Decodes NHTSA flags with a warning (e.g. wrong check digit) still count
  as decoded; no make/model is a final failure with NHTSA's explanation
- Network errors, timeouts, bad responses and HTTP 403/429/5xx raise
  TransientError, so the job retries
- Makes are title-cased from NHTSA's capitals, keeping short
  abbreviations (GMC, RAM, BMW)
- Removes the gem from the Gemfile

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:20:24 -04:00
Claude 0a3c73482a Fix access, VIN decoding, vehicle history and form bugs
Access
- VIN decode status (polled by the vehicle page) is part of View
  vehicles; it was admin-only, so staff saw "Error checking VIN status"
- Customer page only lists vehicles to users with View vehicles
- Controller relies on authorize_global (drops redmine_qbo's
  require_user)

Vehicle history
- Vehicles with issues can't be deleted (restrict_with_error), so their
  service history is never lost; sold vehicles move by changing customer
- The issue form always offers the issue's current vehicle, so editing
  an old issue after the vehicle was sold no longer blanks it
- Issues must use a vehicle owned by their customer, checked only when
  the vehicle or customer changes, so historical issues are untouched
- The issue form's vehicle list refreshes when the customer changes

VIN decoding
- Status checks queue at most one re-decode per vehicle per 5 minutes
  (was one every 3 seconds while pending) and pass the id the job expects
- Network failures are retried by the job; an invalid VIN or no match is
  recorded as final; the error is recorded once retries run out
- Decode results save without validations, so vehicles whose customer
  was deleted in QBO still get decoded

Bugs
- Failed create/update re-render the form with errors (create used to
  redirect to a possibly missing vehicle); duplicate VINs link to the
  vehicle on file
- New vehicle without a customer, unknown customer ids and missing
  vehicles no longer raise; real errors aren't masked as 404s
- last_service_date no longer fails without a service; last service is
  one query per vehicle, using a configurable mileage field (plugin
  settings; defaults to a field named Mileage)
- Search works on PostgreSQL (year matched exactly, not with LIKE),
  includes the vehicle name, and matches multi-word queries
- Missing "estimates" label, stray && in the appointment hook, notes
  field id, hard-coded English messages, shared page parameter
- Vehicle labels that lived only in redmine_qbo are now in this plugin

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 23:04:46 -04:00
ricky b021ca9f7d Bump version to 2026.9.1 2026.9.1 2026-09-09 21:40:23 -04:00
ricky feb357b9a4 Fix syntax error in permission check for adding vehicles 2026-09-09 21:39:59 -04:00
ricky df41436e61 Implement global permissions for vehicle actions and update version to 2026.9.0 2026.9.0 2026-09-08 22:56:47 -04:00
ricky 849dcabff7 Bump version to 2026.8.2 2026.8.2 2026-08-26 21:23:06 -04:00
ricky 5eac85351d Register vehicle field with SubtaskFieldCopier and ensure uniqueness 2026-08-26 21:19:56 -04:00
ricky b2f65f90b6 Dynamically update the new issue link with vehicle id 2026-08-17 21:05:09 -04:00
ricky 05bbcb43db Version 2026.8.1 2026.8.1 2026-08-12 08:42:33 -04:00
ricky 9cc2af9cec Refactor vehicle views for improved formatting and note handling 2026-08-11 18:33:16 -04:00
ricky 9d101fef38 Add last service date and mileage methods to Vehicle model and update views 2026-08-11 18:07:43 -04:00
ricky fe81cb6ff8 Version 2026.8.0 2026.8.0 2026-08-10 19:36:43 -04:00
ricky a9d0eafa40 Add vehicle appointment hook and localization for 'Add Vehicle' label 2026-08-10 19:04:58 -04:00
ricky 7158a8b02c Add fallback for last service date and introduce 'unknown' label 2026-08-08 14:30:11 -04:00
ricky bdfad0d020 Added translation for Vehicle 2026-08-06 16:22:27 -04:00
ricky 16e3d79ea8 Added last serviced date & mileage to vehicle details 2026-08-03 08:30:53 -04:00
ricky 6da0972476 2026.4.1 2026.4.1 2026-04-09 09:43:04 -04:00
ricky 35542ba1b9 Fix vehicle name fallback not applied in select by replacing pluck with model instances 2026-04-09 09:42:45 -04:00
ricky cc94401a1f 2026.4.0 2026.4.0 2026-04-09 09:32:00 -04:00
ricky 6012434de2 Display year/make/model if name is blank 2026-04-09 09:31:31 -04:00
ricky 83a5811a37 Removed InvoiceHookListener registation 2026-03-29 21:55:41 -04:00
ricky 35bd41d289 2026.3.4 2026.3.4 2026-03-28 00:28:11 -04:00
ricky a9354026bc removed InvoiceHookListener as support has been removed from redmine_qbo 2026-03-28 00:27:59 -04:00
ricky f9102c1a5d update vehicles in batches 2026-03-26 22:10:32 -04:00
ricky 0aef1d0c2b Build vehicle name 2026-03-26 12:45:17 -04:00
ricky ba313dfd02 2026.3.3 2026.3.3 2026-03-26 08:11:43 -04:00
ricky c38bced329 record errors and decode existing vins on migration 2026-03-26 07:51:38 -04:00
ricky 8503c48944 show all vehicles if search is blank 2026-03-26 07:21:05 -04:00
ricky 44bfb69e22 check if vin is changed to prevent loops 2026-03-26 07:20:19 -04:00
ricky 89dc3cd5f4 moved vin decoding into a job 2026-03-25 22:30:02 -04:00
ricky 030340b35e 2026.3.2 2026.3.2 2026-03-22 14:28:04 -04:00
ricky 097276e558 Updated patches and hooks 2026-03-21 12:23:23 -04:00
ricky ea73878c71 renamed issue_customer_id to customer_id 2026-03-19 18:07:36 -04:00
ricky 8ec60c8cd7 updated to new autocomplete 2026-03-19 10:20:50 -04:00
ricky 9cb38cfbb1 updaed readme 2026-03-07 13:29:13 -05:00
ricky 9a1678d353 2026.3.0 2026.3.0 2026-03-04 21:00:43 -05:00
ricky 28957c5dff fixed eager loading issue 2026-03-04 20:57:29 -05:00
ricky a67b75671e updated logging with prefix 2026-03-04 20:57:12 -05:00
ricky 492ff000bf Don't copy the text Copied! 2026-02-26 13:26:45 -05:00
ricky e0fc07141c 2026.2.8 2026.2.8 2026-02-25 22:13:18 -05:00
ricky 3e6c2672e0 removed duplicate comment 2026-02-25 22:12:48 -05:00
ricky 71bde3a249 Enhance search_result_ranks_and_ids method to rank results by ID and streamline query handling 2026-02-25 22:12:14 -05:00
ricky 4f2ae19460 2026.2.7 2026-02-22 19:13:20 -05:00
ricky 9ee792cbd8 Refactor vehicle model: streamline search functionality using built in modules 2026-02-22 13:19:28 -05:00
ricky ae7ccbf4b0 display VIN & Customer on search event_description 2026-02-21 19:20:28 -05:00
ricky 550601b5c9 Merge branch 'dev' 2026.2.6 2026-02-21 19:09:29 -05:00
ricky 85cd02b16a 2026.2.6 2026-02-21 19:07:06 -05:00