From e0a23bac20829de0ea50bf707091e1f5b3bffab1 Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Thu, 29 Jan 2026 22:52:17 -0500 Subject: [PATCH] Lose the hash rocket, use symbols --- app/controllers/vehicles_controller.rb | 4 ++-- app/views/customers/_show_hook.html.erb | 2 +- app/views/vehicles/_form.html.erb | 14 +++++++------- app/views/vehicles/_search.html.erb | 4 ++-- app/views/vehicles/edit.html.erb | 2 +- app/views/vehicles/index.html.erb | 4 ++-- app/views/vehicles/new.html.erb | 2 +- app/views/vehicles/show.html.erb | 6 +++--- config/routes.rb | 2 +- init.rb | 6 +++--- lib/vehicles/hooks/customer_show_hook_listener.rb | 2 +- lib/vehicles/hooks/issues_form_hook_listener.rb | 4 ++-- lib/vehicles/hooks/issues_show_hook_listener.rb | 2 +- 13 files changed, 27 insertions(+), 27 deletions(-) diff --git a/app/controllers/vehicles_controller.rb b/app/controllers/vehicles_controller.rb index 25fe322..dfdd0a4 100644 --- a/app/controllers/vehicles_controller.rb +++ b/app/controllers/vehicles_controller.rb @@ -23,7 +23,7 @@ class VehiclesController < ApplicationController def index if params[:customer_id] begin - @vehicles = Customer.find_by_id(params[:customer_id]).vehicles.paginate(:page => params[:page]) + @vehicles = Customer.find_by_id(params[:customer_id]).vehicles.paginate(page: params[:page]) rescue ActiveRecord::RecordNotFound render_404 end @@ -31,7 +31,7 @@ class VehiclesController < ApplicationController # search for a vehicle by vin if params[:search] - @vehicles = Vehicle.search(params[:search]).paginate(:page => params[:page]) + @vehicles = Vehicle.search(params[:search]).paginate(page: params[:page]) if only_one_non_zero?(@vehicles) redirect_to @vehicles.first end diff --git a/app/views/customers/_show_hook.html.erb b/app/views/customers/_show_hook.html.erb index 718f81e..ca9210c 100644 --- a/app/views/customers/_show_hook.html.erb +++ b/app/views/customers/_show_hook.html.erb @@ -1,5 +1,5 @@

<%=t(:field_vehicles)%>:

-<%= render :partial => 'vehicles/list', :locals => { :vehicles => customer.vehicles.paginate(:page => params[:page]) } %> +<%= render partial: 'vehicles/list', locals: { vehicles: customer.vehicles.paginate(page: params[:page]) } %>
<%= button_to t(:button_new_vehice), new_customer_vehicle_path(customer), method: :get %>
\ No newline at end of file diff --git a/app/views/vehicles/_form.html.erb b/app/views/vehicles/_form.html.erb index 8e85442..82a5fdf 100644 --- a/app/views/vehicles/_form.html.erb +++ b/app/views/vehicles/_form.html.erb @@ -6,43 +6,43 @@
<%=t(:field_customer)%>:
- <%= f.autocomplete_field :customer, autocomplete_customer_name_customers_path, :value => @customer.name, :update_elements => {:id => '#customer_id', :value => '#issue_customer'}, :required => true %> - <%= f.hidden_field :customer_id, :id => "customer_id", :value => @customer.id %> + <%= f.autocomplete_field :customer, autocomplete_customer_name_customers_path, value: @customer.name, update_elements: {id: '#customer_id', value: '#issue_customer'}, required: true %> + <%= f.hidden_field :customer_id, id: "customer_id", value: @customer.id %>
<%=t(:label_year)%>:
- <%= f.number_field :year, :autocomplete => "off" %> + <%= f.number_field :year, autocomplete: "off" %>
<%=t(:label_make)%>:
- <%= f.text_field :make, :autocomplete => "off" %> + <%= f.text_field :make, autocomplete: "off" %>
<%=t(:label_model)%>:
- <%= f.text_field :model, :autocomplete => "off" %> + <%= f.text_field :model, autocomplete: "off" %>
<%=t(:field_vin)%>:
- <%= f.text_field :vin , :autofocus => true %> + <%= f.text_field :vin , autofocus: true %>
<%=t(:field_notes)%>:
- <%= f.text_area :notes, :cols => 60, :rows => 10, :no_label => true %> + <%= f.text_area :notes, cols: 60, rows: 10, no_label: true %>
diff --git a/app/views/vehicles/_search.html.erb b/app/views/vehicles/_search.html.erb index ba79ae2..27ba490 100644 --- a/app/views/vehicles/_search.html.erb +++ b/app/views/vehicles/_search.html.erb @@ -1,4 +1,4 @@ -<%= form_tag(vehicles_path, :method => "get", id: "search-form") do %> - <%= text_field_tag :search, params[:search], placeholder: t(:label_search_vin), :autocomplete => "off" %> +<%= form_tag(vehicles_path, method: "get", id: "search-form") do %> + <%= text_field_tag :search, params[:search], placeholder: t(:label_search_vin), autocomplete: "off" %> <%= submit_tag t(:label_search) %> <% end %> diff --git a/app/views/vehicles/edit.html.erb b/app/views/vehicles/edit.html.erb index 9490f6b..e27b1d1 100644 --- a/app/views/vehicles/edit.html.erb +++ b/app/views/vehicles/edit.html.erb @@ -1,3 +1,3 @@

<%=t(:label_edit_customer_vehicle)%>


-<%= render :partial => 'vehicles/form' %> +<%= render partial: 'vehicles/form' %> diff --git a/app/views/vehicles/index.html.erb b/app/views/vehicles/index.html.erb index 224e813..347de63 100644 --- a/app/views/vehicles/index.html.erb +++ b/app/views/vehicles/index.html.erb @@ -1,4 +1,4 @@ -

<%=t(:label_cusomer_vehicles)%> <%= render :partial => 'vehicles/search' %>

+

<%=t(:label_cusomer_vehicles)%> <%= render partial: 'vehicles/search' %>


-<%= render :partial => 'vehicles/list', locals: {vehicles: @vehicles} %> +<%= render partial: 'vehicles/list', locals: {vehicles: @vehicles} %> diff --git a/app/views/vehicles/new.html.erb b/app/views/vehicles/new.html.erb index b99af4d..ea9c7b1 100644 --- a/app/views/vehicles/new.html.erb +++ b/app/views/vehicles/new.html.erb @@ -1,3 +1,3 @@

<%=t(:label_new_vehicle)%>


-<%= render :partial => 'vehicles/form' %> +<%= render partial: 'vehicles/form' %> diff --git a/app/views/vehicles/show.html.erb b/app/views/vehicles/show.html.erb index d440c20..26e6595 100644 --- a/app/views/vehicles/show.html.erb +++ b/app/views/vehicles/show.html.erb @@ -1,11 +1,11 @@

<%=t(:field_vehicle)%> #<%=@vehicle.id%>

-<%= render :partial => 'vehicles/details', locals: {vehicle: @vehicle} %> +<%= render partial: 'vehicles/details', locals: {vehicle: @vehicle} %>

<%=@issues.open.count%> <%=t(:label_open_issues)%>

-<%= render :partial => 'issues/list_simple', locals: {issues: @issues.open} %> +<%= render partial: 'issues/list_simple', locals: {issues: @issues.open} %>

<%=@closed_issues.count%> <%=t(:label_closed_issues)%>

-<%= render :partial => 'issues/list_simple', locals: {issues: (@closed_issues)} %> +<%= render partial: 'issues/list_simple', locals: {issues: (@closed_issues)} %> diff --git a/config/routes.rb b/config/routes.rb index 0108a51..bd428b2 100644 --- a/config/routes.rb +++ b/config/routes.rb @@ -11,7 +11,7 @@ # Nest Vehicles under customers resources :customers do resources :vehicles - get :autocomplete_customer_name, :on => :collection + get :autocomplete_customer_name, on: :collection end #allow for just vehicles too diff --git a/init.rb b/init.rb index 8d6b493..2203d32 100644 --- a/init.rb +++ b/init.rb @@ -17,7 +17,7 @@ Redmine::Plugin.register :redmine_qbo_vehicles do version '2026.1.1' url 'https://github.com/rickbarrette/redmine_qbo_vehicles' author_url 'https://barrettefabrication.com' - requires_redmine :version_or_higher => '6.1.0' + requires_redmine version_or_higher: '6.1.0' # Ensure redmine_qbo is installed begin @@ -30,10 +30,10 @@ Redmine::Plugin.register :redmine_qbo_vehicles do Issue.safe_attributes 'vehicle_id' # Permissions for security - permission :view_vehicles, :vehicles => :new, :public => false + permission :view_vehicles, vehicles: :new, public: false # Register top menu items - menu :top_menu, :vehicles, { :controller => :vehicles, :action => :index }, :caption => 'Vehicles', :if => Proc.new { User.current.logged? } + menu :top_menu, :vehicles, { controller: :vehicles, action: :index }, caption: 'Vehicles', if: Proc.new { User.current.logged? } end diff --git a/lib/vehicles/hooks/customer_show_hook_listener.rb b/lib/vehicles/hooks/customer_show_hook_listener.rb index 073fc60..2084d2c 100644 --- a/lib/vehicles/hooks/customer_show_hook_listener.rb +++ b/lib/vehicles/hooks/customer_show_hook_listener.rb @@ -19,7 +19,7 @@ module Vehicles # Pass all prebuilt form components to our partial context[:controller].send(:render_to_string, { - :partial => 'customers/show_hook', locals: { customer: context[:customer] } + partial: 'customers/show_hook', locals: { customer: context[:customer] } }) end diff --git a/lib/vehicles/hooks/issues_form_hook_listener.rb b/lib/vehicles/hooks/issues_form_hook_listener.rb index db26c46..45f22c6 100644 --- a/lib/vehicles/hooks/issues_form_hook_listener.rb +++ b/lib/vehicles/hooks/issues_form_hook_listener.rb @@ -36,11 +36,11 @@ module Vehicles end # Generate the drop down list of vehicles - vehicle = f.select :vehicle_id, vehicles, :selected => selected_vehicle, include_blank: true + vehicle = f.select :vehicle_id, vehicles, selected: selected_vehicle, include_blank: true # Pass all prebuilt form components to our partial context[:controller].send(:render_to_string, { - :partial => 'issues/form_hook_vehicles', + partial: 'issues/form_hook_vehicles', locals: { vehicle: vehicle } diff --git a/lib/vehicles/hooks/issues_show_hook_listener.rb b/lib/vehicles/hooks/issues_show_hook_listener.rb index 4ef32b2..f0ea4a8 100644 --- a/lib/vehicles/hooks/issues_show_hook_listener.rb +++ b/lib/vehicles/hooks/issues_show_hook_listener.rb @@ -30,7 +30,7 @@ module Vehicles split_vin = vin.scan(/.{1,9}/) if vin context[:controller].send(:render_to_string, { - :partial => 'issues/show_issue_view_right', + partial: 'issues/show_issue_view_right', locals: { vehicle: vehicle, split_vin: split_vin,