From c38bced329d8b74431c9d6b6f0f1fd9770b9d43c Mon Sep 17 00:00:00 2001
From: Rick Barrette <rickbarrette@gmail.com>
Date: Thu, 26 Mar 2026 07:51:38 -0400
Subject: [PATCH] record errors and decode existing vins on migration

---
 app/controllers/vehicles_controller.rb        | 12 +++-
 app/jobs/vehicle_vin_decode_job.rb            |  5 +-
 app/views/vehicles/show.html.erb              | 60 +++++++++++++++----
 ...exes.rb => 004_add_polling_and_indexes.rb} |  7 ++-
 4 files changed, 69 insertions(+), 15 deletions(-)
 rename db/migrate/{004_add_indexes.rb => 004_add_polling_and_indexes.rb} (88%)

diff --git a/app/controllers/vehicles_controller.rb b/app/controllers/vehicles_controller.rb
index d184c01..a5b4f33 100644
--- a/app/controllers/vehicles_controller.rb
+++ b/app/controllers/vehicles_controller.rb
@@ -76,10 +76,20 @@ class VehiclesController < ApplicationController
     end
   end
 
+  # used by the polling JS in vehicle#show
   def status
     vehicle = Vehicle.find(params[:id])
+
+    # decode the vin if it hasn't been done for some reason
+    unless vehicle.vin_decoded
+      if vehicle.error.nil?
+        VehicleVinDecodeJob.perform_later(vehicle)
+      end
+    end
+    
     render json: {
-      decoded: vehicle.vin_decoded
+      decoded: vehicle.vin_decoded,
+      error: vehicle.error
     }
   end
 
diff --git a/app/jobs/vehicle_vin_decode_job.rb b/app/jobs/vehicle_vin_decode_job.rb
index b021ce3..5371fb2 100644
--- a/app/jobs/vehicle_vin_decode_job.rb
+++ b/app/jobs/vehicle_vin_decode_job.rb
@@ -20,7 +20,7 @@ class VehicleVinDecodeJob < ApplicationJob
     
     unless result.success?
       log "Failed to decode vin"
-      vehicle.update(vin_decoded: false)
+      vehicle.update(vin_decoded: false, error: result.error)
       return
     end
 
@@ -33,7 +33,8 @@ class VehicleVinDecodeJob < ApplicationJob
       doors: details.doors.presence || vehicle.doors,
       trim: details.trim.presence || vehicle.trim,
       name: vehicle.to_s,
-      vin_decoded: true
+      vin_decoded: true,
+      error: nil
     )
   end
 
diff --git a/app/views/vehicles/show.html.erb b/app/views/vehicles/show.html.erb
index ea7b0b8..146f145 100644
--- a/app/views/vehicles/show.html.erb
+++ b/app/views/vehicles/show.html.erb
@@ -1,8 +1,12 @@
 <h2><%=t(:field_vehicle)%> #<%=@vehicle.id%></h2>
 
 <% unless @vehicle.vin_decoded? %>
-  <div id="vin-status" class="flash notice">
-    <%= t :notice_decoding_vin %>
+  <div id="vin-status" class="flash <%= @vehicle.error ? "error" : "notice" %>">
+    <% if @vehicle.error%>
+      <%= @vehicle.error %>
+    <% else %>
+      <%= t :notice_decoding_vin %>
+    <% end %>
   </div>
 <% end %>
 
@@ -35,9 +39,11 @@
 
     if (alreadyDecoded) return;
 
-    const interval = 3000; // 3 seconds
+    const interval = 3000;
     let attempts = 0;
-    const maxAttempts = 40; // ~2 minutes
+    const maxAttempts = 40;
+
+    const statusEl = document.getElementById("vin-status");
 
     const checkStatus = () => {
       fetch(`/vehicles/${vehicleId}/status`, {
@@ -45,22 +51,54 @@
       })
         .then(res => res.json())
         .then(data => {
+
+          // SUCCESS → reload
           if (data.decoded) {
             window.location.reload();
-          } else {
-            attempts++;
-            if (attempts >= maxAttempts) {
-              clearInterval(timer);
-              console.warn("VIN decode polling timed out");
+            return;
+          }
+
+          // ERROR → stop + show message
+          if (data.error) {
+            clearInterval(timer);
+
+            if (statusEl) {
+              statusEl.classList.remove("notice");
+              statusEl.classList.add("error");
+              statusEl.textContent = data.error;
             }
+
+            console.warn("VIN decode failed:", data.error);
+            return;
+          }
+
+          // continue polling
+          attempts++;
+          if (attempts >= maxAttempts) {
+            clearInterval(timer);
+
+            if (statusEl) {
+              statusEl.classList.remove("notice");
+              statusEl.classList.add("warning");
+              statusEl.textContent = "VIN decode timed out. Please refresh or try again.";
+            }
+
+            console.warn("VIN decode polling timed out");
           }
         })
         .catch(err => {
-          console.error("Polling error:", err);
           clearInterval(timer);
+
+          if (statusEl) {
+            statusEl.classList.remove("notice");
+            statusEl.classList.add("error");
+            statusEl.textContent = "Error checking VIN status.";
+          }
+
+          console.error("Polling error:", err);
         });
     };
 
     const timer = setInterval(checkStatus, interval);
   })();
-</script>
+</script>
\ No newline at end of file
diff --git a/db/migrate/004_add_indexes.rb b/db/migrate/004_add_polling_and_indexes.rb
similarity index 88%
rename from db/migrate/004_add_indexes.rb
rename to db/migrate/004_add_polling_and_indexes.rb
index 37fb7c6..7f0abf9 100644
--- a/db/migrate/004_add_indexes.rb
+++ b/db/migrate/004_add_polling_and_indexes.rb
@@ -8,15 +8,20 @@
 #
 #THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
 
-class AddIndexes < ActiveRecord::Migration[7.0]
+class AddPollingAndIndexes < ActiveRecord::Migration[7.0]
   
   def change
     add_column :vehicles, :vin_decoded, :boolean, default: false, null: false
+    add_column :vehicles, :error, :string
     add_index :vehicles, :vin_decoded
     add_index :vehicles, :vin, unique: true
     add_index :vehicles, :make
     add_index :vehicles, :model
     add_index :vehicles, :year
+
+    Vehicle.all.each do |v|
+      VehicleVinDecodeJob.perform_later(v.id)
+    end
   end
 
 end