From 14abda2022e1d2d0c5ed56a42eb51bb9db2bc375 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 31 Oct 2026 10:17:26 -0400 Subject: [PATCH] Give new estimates and invoices their VIN (qbo_billing_default_vin) The work orders' vehicle when they share one, else the customer's only vehicle with a VIN; nothing when it's ambiguous. Co-Authored-By: Claude Opus 5.5 Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM --- README.md | 2 +- lib/vehicles/hooks/billing_hook_listener.rb | 16 ++++++++++++++++ 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/README.md b/README.md index 4287d1e..bd5251b 100644 --- a/README.md +++ b/README.md @@ -19,7 +19,7 @@ The goal of this project is to enable vehicle tracking for customer vehicles wit * **Asset Tracking:** Adds vehicles owned by customers to the system. * **Issue Association:** Allows these vehicles to be attached directly to Redmine issues for better service tracking. * **Invoices (redmine_qbo 2026.11.0+):** importing a work order's time or estimate fills the invoice's VIN box with its vehicle's VIN and the mileage box with the highest value of the work orders' **Mileage** issue custom field (Redmine's own custom field named "Mileage"), and an invoice whose work orders are for more than one vehicle isn't saved (one vehicle per invoice). -* **Estimates (redmine_qbo 2026.11.0+):** the VIN box suggests the customer's vehicles (one vehicle fills it in), and issues created from an estimate get the appointment's vehicle, or else the customer's vehicle whose VIN is on the estimate. +* **Estimates (redmine_qbo 2026.11.0+):** the VIN box suggests the customer's vehicles, and a new estimate or invoice starts with the VIN of its work orders' vehicle (or of the customer's only vehicle), and issues created from an estimate get the appointment's vehicle, or else the customer's vehicle whose VIN is on the estimate. * **Customer page:** ticking a vehicle adds it to the New issue link. ## Installation diff --git a/lib/vehicles/hooks/billing_hook_listener.rb b/lib/vehicles/hooks/billing_hook_listener.rb index 466690e..9fba680 100644 --- a/lib/vehicles/hooks/billing_hook_listener.rb +++ b/lib/vehicles/hooks/billing_hook_listener.rb @@ -34,6 +34,22 @@ module Vehicles customer.vehicles.select { |v| v.vin.present? }.map { |v| { vin: v.vin, name: v.to_s } } end + # The VIN a new estimate or invoice starts with: the work orders' vehicle when they share one, else the + # customer's only vehicle with a VIN. Nothing when it's ambiguous (work orders for several vehicles, or a + # customer with several and no work orders); the VIN box's suggestions still list them. + def qbo_billing_default_vin(context = {}) + vins = Array(context[:issues]).filter_map { |issue| issue.respond_to?(:vehicle) ? issue.vehicle&.vin.presence : nil } + .map(&:upcase).uniq + return vins.first if vins.size == 1 + return nil if vins.size > 1 + + customer = context[:customer] + return nil unless customer.respond_to?(:vehicles) + + with_vin = customer.vehicles.select { |v| v.vin.present? } + with_vin.first.vin if with_vin.size == 1 + end + # Issues created from an estimate get a vehicle: the one passed in (e.g. redmine_qbo_calendar's # appointment vehicle), or the customer's vehicle whose VIN is on the estimate def qbo_billing_build_issue(context = {})