mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-18 02:40:37 -05:00
Fix access, VIN decoding, vehicle history and form bugs
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
18 files changed
+268
-130
No files matched your search
+20
-1
@@ -39,4 +39,23 @@ en:
|
||||
notice_decoding_vin: "Decoding VIN… this page will update automatically."
|
||||
notice_vehicle_created: "Vehicle was successfully created."
|
||||
notice_vehicle_deleted: "Vehicle was successfully deleted."
|
||||
notice_vehicle_updated: "Vehicle was successfully updated."
|
||||
notice_vehicle_updated: "Vehicle was successfully updated."
|
||||
|
||||
# Vehicle labels previously only defined in redmine_qbo
|
||||
field_customer: "Customer"
|
||||
label_delete: "Delete"
|
||||
label_door: "Door"
|
||||
label_estimates: "Estimates"
|
||||
label_invoices: "Invoices"
|
||||
label_matching: "Matching"
|
||||
label_trim: "Trim"
|
||||
warn_ru_sure: "Are you sure?"
|
||||
|
||||
alert_vehicle_has_issues: "This vehicle has issues, so it can't be deleted (that would lose its service history). If it was sold, change its customer instead."
|
||||
error_vehicle_customer_mismatch: "Vehicle %{vehicle} belongs to a different customer. Pick one of this customer's vehicles."
|
||||
error_vehicle_not_found_for_issue: "The selected vehicle no longer exists."
|
||||
error_vin_status_check_failed: "Error checking VIN status."
|
||||
label_mileage_custom_field: "Mileage field"
|
||||
notice_vin_decode_timed_out: "VIN decode timed out. Please refresh or try again."
|
||||
text_mileage_custom_field_info: "Issue custom field used for \"Last serviced\" mileage. Leave blank to use a field named Mileage."
|
||||
text_vin_already_on_file: "A vehicle with this VIN is already on file:"
|
||||
Reference in new issue
Block a user