mirror of
https://github.com/rickbarrette/redmine_qbo_vehicles.git
synced 2026-11-18 02:40:37 -05:00
Fix access, VIN decoding, vehicle history and form bugs
Access - VIN decode status (polled by the vehicle page) is part of View vehicles; it was admin-only, so staff saw "Error checking VIN status" - Customer page only lists vehicles to users with View vehicles - Controller relies on authorize_global (drops redmine_qbo's require_user) Vehicle history - Vehicles with issues can't be deleted (restrict_with_error), so their service history is never lost; sold vehicles move by changing customer - The issue form always offers the issue's current vehicle, so editing an old issue after the vehicle was sold no longer blanks it - Issues must use a vehicle owned by their customer, checked only when the vehicle or customer changes, so historical issues are untouched - The issue form's vehicle list refreshes when the customer changes VIN decoding - Status checks queue at most one re-decode per vehicle per 5 minutes (was one every 3 seconds while pending) and pass the id the job expects - Network failures are retried by the job; an invalid VIN or no match is recorded as final; the error is recorded once retries run out - Decode results save without validations, so vehicles whose customer was deleted in QBO still get decoded Bugs - Failed create/update re-render the form with errors (create used to redirect to a possibly missing vehicle); duplicate VINs link to the vehicle on file - New vehicle without a customer, unknown customer ids and missing vehicles no longer raise; real errors aren't masked as 404s - last_service_date no longer fails without a service; last service is one query per vehicle, using a configurable mileage field (plugin settings; defaults to a field named Mileage) - Search works on PostgreSQL (year matched exactly, not with LIKE), includes the vehicle name, and matches multi-word queries - Missing "estimates" label, stray && in the appointment hook, notes field id, hard-coded English messages, shared page parameter - Vehicle labels that lived only in redmine_qbo are now in this plugin Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
18 files changed
+268
-130
No files matched your search
@@ -1,6 +1,6 @@
|
||||
<% if User.current.allowed_to?(:add_vehicles, nil, global: true) %>
|
||||
<% if appointment.customer.present? %>
|
||||
<% unless appointment.vehicle.present? &&%>
|
||||
<% unless appointment.vehicle.present? %>
|
||||
<p>
|
||||
<%= link_to new_vehicle_path(customer_id: appointment.customer_id), class: 'icon icon-add' do %>
|
||||
<%= l(:label_add_vehicle) %>
|
||||
|
||||
@@ -1,7 +1,10 @@
|
||||
<% if User.current.allowed_to?(:view_vehicles, nil, global: true) %>
|
||||
<h4><%=t(:field_vehicles)%>:</h4>
|
||||
<%= render partial: 'vehicles/list', locals: { vehicles: customer.vehicles.paginate(page: params[:page]), show_customer: false, show_checkbox: true } %>
|
||||
<%# Own page parameter so this list doesn't page together with the other lists on the customer page %>
|
||||
<%= render partial: 'vehicles/list', locals: { vehicles: customer.vehicles.paginate(page: params[:vehicles_page]), show_customer: false, show_checkbox: true, page_param: :vehicles_page } %>
|
||||
<div style="float: right;">
|
||||
<% if User.current.allowed_to?(:add_vehicles, nil, global: true) %>
|
||||
<%= button_to t(:button_new_vehicle), new_customer_vehicle_path(customer), method: :get %>
|
||||
<% end %>
|
||||
</div>
|
||||
</div>
|
||||
<% end %>
|
||||
@@ -0,0 +1,9 @@
|
||||
<div class="box tabular">
|
||||
<p>
|
||||
<label for="settings_mileage_custom_field_id"><%= l(:label_mileage_custom_field) %></label>
|
||||
<%= select_tag 'settings[mileage_custom_field_id]',
|
||||
options_from_collection_for_select(IssueCustomField.sorted, :id, :name, settings['mileage_custom_field_id'].to_i),
|
||||
include_blank: true, id: 'settings_mileage_custom_field_id' %>
|
||||
<em class="info"><%= l(:text_mileage_custom_field_info) %></em>
|
||||
</p>
|
||||
</div>
|
||||
@@ -57,7 +57,8 @@
|
||||
<% if User.current.allowed_to?(:edit_vehicles, nil, global: true) %>
|
||||
<%= button_to t(:label_edit), edit_vehicle_path(vehicle), method: :get %>
|
||||
<% end %>
|
||||
<% if User.current.allowed_to?(:delete_vehicles, nil, global: true) %>
|
||||
<%# Vehicles with issues can't be deleted, to keep their service history %>
|
||||
<% if User.current.allowed_to?(:delete_vehicles, nil, global: true) && !vehicle.issues.exists? %>
|
||||
<%= button_to t(:label_delete), vehicle, method: :delete, data: { confirm: t(:warn_ru_sure) } %>
|
||||
<% end %>
|
||||
</div>
|
||||
@@ -3,11 +3,20 @@
|
||||
<fieldset>
|
||||
|
||||
<%= form_for @vehicle do |f| %>
|
||||
<%= error_messages_for 'vehicle' %>
|
||||
|
||||
<% if @existing_vehicle %>
|
||||
<p class="flash warning">
|
||||
<%= l(:text_vin_already_on_file) %>
|
||||
<%= link_to @existing_vehicle.to_s, vehicle_path(@existing_vehicle) %>
|
||||
</p>
|
||||
<% end %>
|
||||
|
||||
<div class="clearfix">
|
||||
<%=t(:field_customer)%>:
|
||||
<div class="input">
|
||||
<%= f.text_field :customer, class: "customer-name", autocomplete: "off", value: @customer.name, required: true,data: { autocomplete_url: "/customers/autocomplete" } %>
|
||||
<%= f.hidden_field :customer_id, id: "customer_id", value: @customer.id %>
|
||||
<%= f.text_field :customer, class: "customer-name", autocomplete: "off", value: @vehicle.customer&.name, required: true,data: { autocomplete_url: "/customers/autocomplete" } %>
|
||||
<%= f.hidden_field :customer_id, id: "customer_id" %>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
@@ -47,8 +56,8 @@
|
||||
rows: 8,
|
||||
class: 'wiki-edit',
|
||||
style: 'width: 95%;',
|
||||
id: 'customer_appointment_description' %>
|
||||
<%= wikitoolbar_for 'customer_appointment_description' %>
|
||||
id: 'vehicle_notes' %>
|
||||
<%= wikitoolbar_for 'vehicle_notes' %>
|
||||
</p>
|
||||
</div>
|
||||
</div>
|
||||
|
||||
@@ -41,10 +41,10 @@
|
||||
<% end %>
|
||||
|
||||
<div class="actions">
|
||||
<%= will_paginate vehicles %>
|
||||
<%= will_paginate vehicles, param_name: (local_assigns[:page_param] || :page) %>
|
||||
</div>
|
||||
|
||||
<%=t(:label_matching)%> <%=vehicles.count%> <%=t(:field_vehicles) %>
|
||||
<%=t(:label_matching)%> <%= vehicles.respond_to?(:total_entries) ? vehicles.total_entries : vehicles.size %> <%=t(:field_vehicles) %>
|
||||
|
||||
<% else %>
|
||||
<p><%=t(:label_no_vehicles)%> <%= params[:search] %>.</p>
|
||||
|
||||
@@ -1,3 +1,3 @@
|
||||
<h1><%=t(:label_edit_customer_vehicle)%></h1>
|
||||
<h2><%=t(:label_edit_customer_vehicle)%></h2>
|
||||
<br/>
|
||||
<%= render partial: 'vehicles/form' %>
|
||||
@@ -14,7 +14,7 @@
|
||||
|
||||
<div class="splitcontent">
|
||||
<div class="splitcontentleft">
|
||||
<h4><%=t(:estimates)%>:</h4>
|
||||
<h4><%=t(:label_estimates)%>:</h4>
|
||||
<%= render partial: 'estimates/list', locals: {estimates: @vehicle.estimates} %>
|
||||
</div>
|
||||
|
||||
@@ -34,7 +34,9 @@
|
||||
|
||||
<script>
|
||||
(function() {
|
||||
const vehicleId = <%= @vehicle.id %>;
|
||||
const statusUrl = <%= raw status_vehicle_path(@vehicle).to_json %>;
|
||||
const timedOutMessage = <%= raw l(:notice_vin_decode_timed_out).to_json %>;
|
||||
const checkFailedMessage = <%= raw l(:error_vin_status_check_failed).to_json %>;
|
||||
const alreadyDecoded = <%= @vehicle.vin_decoded? ? 'true' : 'false' %>;
|
||||
|
||||
if (alreadyDecoded) return;
|
||||
@@ -46,10 +48,14 @@
|
||||
const statusEl = document.getElementById("vin-status");
|
||||
|
||||
const checkStatus = () => {
|
||||
fetch(`/vehicles/${vehicleId}/status`, {
|
||||
headers: { 'Accept': 'application/json' }
|
||||
fetch(statusUrl, {
|
||||
headers: { 'Accept': 'application/json' },
|
||||
credentials: 'same-origin'
|
||||
})
|
||||
.then(res => res.json())
|
||||
.then(res => {
|
||||
if (!res.ok) throw new Error('HTTP ' + res.status);
|
||||
return res.json();
|
||||
})
|
||||
.then(data => {
|
||||
|
||||
// SUCCESS → reload
|
||||
@@ -80,7 +86,7 @@
|
||||
if (statusEl) {
|
||||
statusEl.classList.remove("notice");
|
||||
statusEl.classList.add("warning");
|
||||
statusEl.textContent = "VIN decode timed out. Please refresh or try again.";
|
||||
statusEl.textContent = timedOutMessage;
|
||||
}
|
||||
|
||||
console.warn("VIN decode polling timed out");
|
||||
@@ -92,7 +98,7 @@
|
||||
if (statusEl) {
|
||||
statusEl.classList.remove("notice");
|
||||
statusEl.classList.add("error");
|
||||
statusEl.textContent = "Error checking VIN status.";
|
||||
statusEl.textContent = checkFailedMessage;
|
||||
}
|
||||
|
||||
console.error("Polling error:", err);
|
||||
|
||||
Reference in new issue
Block a user