The issue form gets the editor's line table (numbered rows, borderless inputs until worked on,
hover delete, billed pill), its buttons, totals and phone cards. The issue page keeps Redmine's
list table, with amounts right-aligned and labelled cards on phones.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
create_estimate(custom_fields:) gets whatever other plugins give for the issue through redmine_qbo's
issue values hook (e.g. redmine_qbo_vehicles: VIN and mileage), instead of naming a VIN and mileage.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
The QuickBooks product/service list and income accounts (models, syncs,
admin pages, routes, settings) now live in redmine_qbo_billing, which this
plugin requires. The closing-an-issue estimate is written through
RedmineQboBilling::EstimateWriter.create_estimate, so estimate building isn't
duplicated; it now also gets the customer email, VIN, default message and
expiration date.
Migrations: 002 now only links line items to items (skipped where the column
exists). 003 and 004 are removed; billing's migrations find the existing
items and accounts tables and leave them alone, so nothing is dropped.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
Permissions
- Item catalog and accounts pages, and their syncs, are admin-only (they
push to / pull from QuickBooks); shown in the Administration layout
- Item autocomplete is allowed with Add or Edit line items
- Permissions now map to real actions (they pointed at a non-existent
line_items controller); line_items_attributes is only accepted from
users with a line item permission
- Line item changes are checked on the server: adding, editing and
deleting each need their permission, and billed lines (already on a
QBO estimate) can't be changed or removed
Bugs
- Billing on close now runs from an Issue after_commit, so closing via
bulk edit or the context menu bills too (replaces the save hook);
the job takes an issue id
- Full sync runs Accounts before Items, and item sync no longer fails
when an item has no income account or its account hasn't synced
- New QBO items default to Non-inventory in the default income account
(the account ref was being assigned to the item type)
- Choosing a blank account on an item no longer raises; set_default
handles no selection
- Item autocomplete escapes item names, SKUs and descriptions (they were
inserted into the page as HTML)
- Items list showed "translation missing" for Yes/No
Polish
- Fractional quantities allowed (0.5 hrs, 2.5 qts)
- Billed lines show a Billed badge and are read-only; remove button only
where allowed; add button only with Add line items
- Removed dead code (Item belongs_to :issue, Item#ref, no-op in new,
swallowed errors); validation failures return 422
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM