Commit Graph
10 Commits
Author SHA1 Message Date
Claude 39f6b64049 Polish: permissions, billed-line locking, sync and billing fixes
Permissions
- Item catalog and accounts pages, and their syncs, are admin-only (they
  push to / pull from QuickBooks); shown in the Administration layout
- Item autocomplete is allowed with Add or Edit line items
- Permissions now map to real actions (they pointed at a non-existent
  line_items controller); line_items_attributes is only accepted from
  users with a line item permission
- Line item changes are checked on the server: adding, editing and
  deleting each need their permission, and billed lines (already on a
  QBO estimate) can't be changed or removed

Bugs
- Billing on close now runs from an Issue after_commit, so closing via
  bulk edit or the context menu bills too (replaces the save hook);
  the job takes an issue id
- Full sync runs Accounts before Items, and item sync no longer fails
  when an item has no income account or its account hasn't synced
- New QBO items default to Non-inventory in the default income account
  (the account ref was being assigned to the item type)
- Choosing a blank account on an item no longer raises; set_default
  handles no selection
- Item autocomplete escapes item names, SKUs and descriptions (they were
  inserted into the page as HTML)
- Items list showed "translation missing" for Yes/No

Polish
- Fractional quantities allowed (0.5 hrs, 2.5 qts)
- Billed lines show a Billed badge and are read-only; remove button only
  where allowed; add button only with Add line items
- Removed dead code (Item belongs_to :issue, Item#ref, no-op in new,
  swallowed errors); validation failures return 422

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 22:37:41 -04:00
ricky 9820646857 allow math on unit price field 2026-03-18 22:02:53 -04:00
ricky 4367c77393 updaed locale 2026-03-17 20:49:58 -04:00
ricky 8c0ce8ce48 updated locale 2026-03-17 20:45:21 -04:00
ricky 9fd1f4fb7d removed back link 2026-03-17 20:37:58 -04:00
ricky cca822c570 better display flags 2026-03-17 20:35:40 -04:00
ricky 6bf5575f9c Updated views for items and accounts 2026-03-17 19:18:03 -04:00
ricky 24e3e4ba82 Added taxable flag 2026-03-17 12:25:58 -04:00
ricky f81fe0ef87 Added accounts to allow for assinging income account to items, and selecting default income account. Also added item type selection 2026-03-16 22:59:54 -04:00
ricky 4f8e5d9b2c implemented some basic CRUD for QBO Items 2026-03-11 23:39:24 -04:00