Polish: permissions, billed-line locking, sync and billing fixes

Permissions
- Item catalog and accounts pages, and their syncs, are admin-only (they
  push to / pull from QuickBooks); shown in the Administration layout
- Item autocomplete is allowed with Add or Edit line items
- Permissions now map to real actions (they pointed at a non-existent
  line_items controller); line_items_attributes is only accepted from
  users with a line item permission
- Line item changes are checked on the server: adding, editing and
  deleting each need their permission, and billed lines (already on a
  QBO estimate) can't be changed or removed

Bugs
- Billing on close now runs from an Issue after_commit, so closing via
  bulk edit or the context menu bills too (replaces the save hook);
  the job takes an issue id
- Full sync runs Accounts before Items, and item sync no longer fails
  when an item has no income account or its account hasn't synced
- New QBO items default to Non-inventory in the default income account
  (the account ref was being assigned to the item type)
- Choosing a blank account on an item no longer raises; set_default
  handles no selection
- Item autocomplete escapes item names, SKUs and descriptions (they were
  inserted into the page as HTML)
- Items list showed "translation missing" for Yes/No

Polish
- Fractional quantities allowed (0.5 hrs, 2.5 qts)
- Billed lines show a Billed badge and are read-only; remove button only
  where allowed; add button only with Add line items
- Removed dead code (Item belongs_to :issue, Item#ref, no-op in new,
  swallowed errors); validation failures return 422

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
Claude committed 2026-10-28 22:37:41 -04:00
1 parent f0d6b08a3d
commit 39f6b64049
20 files changed
+182 -138

No files matched your search

+11 -7
View File
@@ -27,14 +27,18 @@ Redmine::Plugin.register :redmine_qbo_lineitems do
raise 'Please install the redmine_qbo plugin (https://github.com/rickbarrette/redmine_qbo)'
end
# Add safe attributes for core models
Issue.safe_attributes :line_items_attributes
# Line items can be submitted with an issue only by users who may add, edit or delete them.
# Which changes are applied is checked per line in Issue#line_items_attributes= (see IssuePatch).
Issue.safe_attributes :line_items_attributes, if: lambda { |_issue, user|
%i[add_line_items edit_line_items delete_line_items].any? { |p| user.allowed_to?(p, nil, global: true) }
}
# Global Permissions
permission :view_line_items, { line_items: [:index, :show] }, global: true
permission :add_line_items, { line_items: [:new, :create] }, global: true
permission :edit_line_items, { line_items: [:edit, :update] }, global: true
permission :delete_line_items, { line_items: [:destroy] }, global: true
# Global Permissions. Line items live on issues; these control what users can do with them there.
# Managing the QBO item catalog, accounts and syncs is admin-only.
permission :view_line_items, {}, global: true
permission :add_line_items, { items: [:autocomplete] }, global: true
permission :edit_line_items, { items: [:autocomplete] }, global: true
permission :delete_line_items, {}, global: true
end
RedmineQboLineItems.setup