mirror of
https://github.com/rickbarrette/redmine_qbo_lineitems.git
synced 2026-11-17 19:20:36 -05:00
Polish: permissions, billed-line locking, sync and billing fixes
Permissions - Item catalog and accounts pages, and their syncs, are admin-only (they push to / pull from QuickBooks); shown in the Administration layout - Item autocomplete is allowed with Add or Edit line items - Permissions now map to real actions (they pointed at a non-existent line_items controller); line_items_attributes is only accepted from users with a line item permission - Line item changes are checked on the server: adding, editing and deleting each need their permission, and billed lines (already on a QBO estimate) can't be changed or removed Bugs - Billing on close now runs from an Issue after_commit, so closing via bulk edit or the context menu bills too (replaces the save hook); the job takes an issue id - Full sync runs Accounts before Items, and item sync no longer fails when an item has no income account or its account hasn't synced - New QBO items default to Non-inventory in the default income account (the account ref was being assigned to the item type) - Choosing a blank account on an item no longer raises; set_default handles no selection - Item autocomplete escapes item names, SKUs and descriptions (they were inserted into the page as HTML) - Items list showed "translation missing" for Yes/No Polish - Fractional quantities allowed (0.5 hrs, 2.5 qts) - Billed lines show a Billed badge and are read-only; remove button only where allowed; add button only with Add line items - Removed dead code (Item belongs_to :issue, Item#ref, no-op in new, swallowed errors); validation failures return 422 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
20 files changed
+182
-138
No files matched your search
@@ -61,17 +61,17 @@
|
||||
|
||||
});
|
||||
|
||||
// Custom rendering of autocomplete suggestions
|
||||
// Custom rendering of autocomplete suggestions. Values are set with .text() so item names,
|
||||
// SKUs and descriptions from QuickBooks can never be interpreted as HTML.
|
||||
ac.autocomplete("instance")._renderItem = function(ul, item) {
|
||||
return $("<li>")
|
||||
.append(
|
||||
"<div class='autocomplete-item'>" +
|
||||
"<div class='item-name'>" + item.name + "</div>" +
|
||||
"<div class='item-sku'>" + item.sku + "</div>" +
|
||||
"<div class='item-description'>" + item.description + "</div>" +
|
||||
"</div>"
|
||||
)
|
||||
.appendTo(ul);
|
||||
let $box = $("<div>").addClass("autocomplete-item");
|
||||
$("<div>").addClass("item-name").text(item.name || "").appendTo($box);
|
||||
if (item.sku) {
|
||||
$("<div>").addClass("item-sku").text(item.sku).appendTo($box);
|
||||
}
|
||||
$("<div>").addClass("item-description").text(item.description || "").appendTo($box);
|
||||
|
||||
return $("<li>").append($box).appendTo(ul);
|
||||
};
|
||||
|
||||
});
|
||||
|
||||
@@ -73,4 +73,19 @@
|
||||
justify-content: flex-end;
|
||||
}
|
||||
|
||||
}
|
||||
}
|
||||
/* Billed line items are locked: they're already on a QuickBooks estimate */
|
||||
.line-item.billed input {
|
||||
background-color: #f6f6f6;
|
||||
}
|
||||
.line-item-billed-badge {
|
||||
display: inline-block;
|
||||
margin-left: 6px;
|
||||
padding: 1px 6px;
|
||||
border-radius: 3px;
|
||||
font-size: 0.8em;
|
||||
font-weight: bold;
|
||||
color: #3e7b3e;
|
||||
background-color: #e5f2e5;
|
||||
border: 1px solid #c6e0c6;
|
||||
}
|
||||
Reference in new issue
Block a user