Files
redmine_qbo_calendar/app/controllers/customer_appointments_controller.rb
T
Claude 73115da2b9 Fix permissions, holiday, hours, visibility and scheduling bugs
- customer_options is now covered by the add/edit permissions, so
  non-admin staff get the vehicle/estimate dropdowns
- create_issues is now a POST member route with its own permission,
  checks add_issues on the target project, no longer redirects to a
  missing route, and has a button on the appointment page
- "Last" week-of-month holidays (e.g. Memorial Day) now match every year
- Cancelled and Call Out appointments no longer count toward hours
- Calendar only shows appointments to users with View customer
  appointments, and only loads those near the displayed month
- due_date skips weekends and holidays, matching the calendar layout
- Subjects keep their casing; only the first letter is capitalized

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
2026-10-28 17:14:13 -04:00

162 lines
5.6 KiB
Ruby

#The MIT License (MIT)
#
#Copyright (c) 2026 rick barrette
#
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
#
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
#
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO CustomerAppointment SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
class CustomerAppointmentsController < ApplicationController
before_action :require_login
before_action :find_project, except: [:index]
before_action :find_appointment, only: [ :show, :edit, :update, :destroy, :create_issues ]
# This tells Redmine to check global permissions for the current controller/action
before_action :authorize_global
helper :projects
def customer_options
customer = Customer.find_by(id: params[:customer_id])
render json: {
vehicles: customer&.vehicles&.map { |v| { id: v.id, name: v.name } } || [],
estimates: customer&.estimates&.map { |e| { id: e.id, name: e.name } } || []
}
end
# Creates one issue per "Labor" line on the appointment's QBO estimate.
def create_issues
# Same fallback order as CustomerAppointment#create_issues_from_labor_lines
target_project = @project || @appointment.project || Project.first
# The user must also be allowed to add issues to the project they'll be created in
return deny_access unless target_project && User.current.allowed_to?(:add_issues, target_project)
created_issues = @appointment.create_issues_from_labor_lines(project: target_project, author: User.current)
if created_issues.any?
flash[:notice] = l(:notice_appointment_issues_created, count: created_issues.size)
else
flash[:error] = l(:error_no_labor_lines_found)
end
redirect_to customer_appointment_path(@appointment)
end
def index
if params[:project_id]
@project = Project.find(params[:project_id])
@appointments = CustomerAppointment.where(project: @project).where('date >= ?', Time.zone.now.beginning_of_day).order(:date)
else
@appointments = CustomerAppointment.where('date >= ?', Time.zone.now.beginning_of_day).order(:date)
end
end
# Lists past appointments, optionally filtered by customer, status and date range.
def history
@customer = Customer.find_by(id: params[:customer_id]) if params[:customer_id].present?
@status = params[:status].presence
@from = parse_date(params[:from])
@to = parse_date(params[:to])
scope = CustomerAppointment
.includes(:customer, :vehicle, :user)
.where('date < ?', Time.zone.now.beginning_of_day)
scope = scope.where(customer_id: @customer.id) if @customer
scope = scope.where(status: @status) if @status
scope = scope.where('date >= ?', @from.in_time_zone.beginning_of_day) if @from
scope = scope.where('date <= ?', @to.in_time_zone.end_of_day) if @to
@appointment_count = scope.count
@appointment_pages = Paginator.new(@appointment_count, per_page_option, params[:page])
@appointments = scope
.order(date: :desc)
.offset(@appointment_pages.offset)
.limit(@appointment_pages.per_page)
end
def show
@appointment = CustomerAppointment.find(params[:id])
end
def new
@appointment = CustomerAppointment.new
@appointment.project = @project
@appointment.date = (params[:start_date].to_date + 9.hours) if params[:start_date].present?
@appointment.customer_id = params[:customer_id] if params[:customer_id].present?
end
def create
@appointment = CustomerAppointment.new(appointment_params)
@appointment.project = @project
if @appointment.save
flash[:notice] = l(:notice_successful_create)
redirect_to customer_appointment_path( @appointment )
else
render :new, status: :unprocessable_entity
end
end
def edit
end
def update
if @appointment.update( appointment_params )
flash[:notice] = l(:notice_successful_update)
redirect_to customer_appointment_path( @appointment )
else
render :edit, status: :unprocessable_entity
end
end
def destroy
@appointment.destroy
flash[:notice] = l(:notice_successful_delete)
redirect_to issues_calendar_path
end
private
def appointment_params
params
.require(:customer_appointment)
.permit(
:subject,
:customer_id,
:phone,
:vehicle_id,
:description,
:status,
:user_id,
:date,
:estimated_hours,
:estimate_id,
:duration
)
end
def parse_date(value)
Date.parse(value) if value.present?
rescue ArgumentError
nil
end
def find_project
@project = Project.find(params[:project_id]) if params[:project_id].present?
end
def find_appointment
@appointment = CustomerAppointment.find(params[:id])
rescue
render_404
end
def log(msg)
Rails.logger.info "[CustomerAppointmentsController] #{msg}"
end
end