Fix permissions, holiday, hours, visibility and scheduling bugs

- customer_options is now covered by the add/edit permissions, so
  non-admin staff get the vehicle/estimate dropdowns
- create_issues is now a POST member route with its own permission,
  checks add_issues on the target project, no longer redirects to a
  missing route, and has a button on the appointment page
- "Last" week-of-month holidays (e.g. Memorial Day) now match every year
- Cancelled and Call Out appointments no longer count toward hours
- Calendar only shows appointments to users with View customer
  appointments, and only loads those near the displayed month
- due_date skips weekends and holidays, matching the calendar layout
- Subjects keep their casing; only the first letter is capitalized

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
Claude committed 2026-10-28 17:14:13 -04:00
1 parent 21538ad95b
commit 73115da2b9
10 files changed
+130 -17

No files matched your search

+4 -2
View File
@@ -31,9 +31,11 @@ Redmine::Plugin.register :redmine_qbo_calendar do
# Global Permissions
permission :view_customer_appointments, { customer_appointments: [:index, :show, :history] }, global: true
permission :add_customer_appointments, { customer_appointments: [:new, :create] }, global: true
permission :edit_customer_appointments, { customer_appointments: [:edit, :update] }, global: true
# customer_options feeds the vehicle/estimate dropdowns on the new and edit forms
permission :add_customer_appointments, { customer_appointments: [:new, :create, :customer_options] }, global: true
permission :edit_customer_appointments, { customer_appointments: [:edit, :update, :customer_options] }, global: true
permission :delete_customer_appointments, { customer_appointments: [:destroy] }, global: true
permission :create_customer_appointment_issues, { customer_appointments: [:create_issues] }, global: true
# Register top menu items
menu :top_menu, :calendar, { controller: :calendars, action: :show }, caption: :label_calendar, if: Proc.new {User.current.logged?}