From 31356ac3fb7d9b13b9e1d42dada6af45127c4c4a Mon Sep 17 00:00:00 2001 From: Rick Barrette Date: Mon, 2 Nov 2026 20:22:52 -0500 Subject: [PATCH] Appointment statuses in the plugin settings; call-outs as their own entry Statuses (name, colour, counts toward hours, order) are set up on the plugin's settings page instead of being hard-coded. Appointments keep a fixed key, so renaming is safe; removing a status in use asks which status to move its appointments to (done on save by a SettingsController hook). Colours come from the settings everywhere statuses show, which also fixes Cancelled never being coloured (cancelled/canceled mismatch). Call-outs (an employee off work) are their own kind of entry (event_type 'call_out') with an employee, date, days and notes, added from a button on each calendar day. They sit at the top of the day in red stripes and never count toward hours. Migration 004 converts Call_Out appointments. Co-Authored-By: Claude Opus 5.5 --- README.md | 2 + .../customer_appointments_controller.rb | 11 +- app/models/customer_appointment.rb | 59 +++-- app/views/common/_calendar.html.erb | 38 +-- .../_calendar_event.html.erb | 17 +- .../customer_appointments/_form.html.erb | 21 +- .../customer_appointments/_list.html.erb | 2 +- .../_list_simple.html.erb | 6 +- .../customer_appointments/_tooltip.html.erb | 6 +- app/views/customer_appointments/edit.html.erb | 4 +- .../customer_appointments/history.html.erb | 8 +- app/views/customer_appointments/new.html.erb | 4 +- app/views/customer_appointments/show.html.erb | 34 +-- .../my/blocks/_upcoming_appointments.html.erb | 9 +- app/views/settings/_qbo_calendar.html.erb | 128 ++++++++++ assets/stylesheets/customer_appointments.css | 225 ++++-------------- config/locales/en.yml | 28 +++ .../004_convert_call_out_appointments.rb | 25 ++ init.rb | 6 +- lib/redmine_qbo_calendar.rb | 1 + .../appointment_status.rb | 114 +++++++++ .../patches/application_helper_patch.rb | 9 + .../patches/settings_controller_patch.rb | 31 +++ 23 files changed, 536 insertions(+), 252 deletions(-) create mode 100644 app/views/settings/_qbo_calendar.html.erb create mode 100644 db/migrate/004_convert_call_out_appointments.rb create mode 100644 lib/redmine_qbo_calendar/appointment_status.rb create mode 100644 lib/redmine_qbo_calendar/patches/settings_controller_patch.rb diff --git a/README.md b/README.md index 02562dd..d432289 100644 --- a/README.md +++ b/README.md @@ -32,6 +32,8 @@ Add appointments to the redmine calanedar with the abiltiy to attach a QBO custo * An appointment's hours can't be less than its estimate's labor hours (the quantities of its lines with redmine_qbo's labor products/services). Picking an estimate raises the hours to match. * The appointment page lists the issues linked to its estimate, and **Create Issues from Estimate** opens redmine_qbo's Create issues page with the appointment's dates, technician and vehicle. * Estimate pages in redmine_qbo get an **Add appointment** link. Other plugins can add to the new appointment through the `:qbo_calendar_appointment_params, { customer:, estimate_id:, custom_fields: }` hook (e.g. redmine_qbo_vehicles: the vehicle with the estimate's VIN). +* **Appointment statuses** are set up in the plugin's settings (Administration › Plugins › Configure): name, colour, whether the time counts toward the calendar's hours, and order (the first is the default). Renaming a status keeps its appointments; removing one in use asks which status to move them to. Statuses that don't count hours (e.g. Cancelled) stay on the calendar, crossed out. +* **Call-outs**: an employee off work, added with the button next to each day's add button. They show at the top of the day in red stripes, have no customer or status, and never count toward hours. Upgrading (migration 004) turns appointments with the old Call_Out status into call-outs. --- diff --git a/app/controllers/customer_appointments_controller.rb b/app/controllers/customer_appointments_controller.rb index be7da5b..6c2dad4 100644 --- a/app/controllers/customer_appointments_controller.rb +++ b/app/controllers/customer_appointments_controller.rb @@ -51,7 +51,12 @@ class CustomerAppointmentsController < ApplicationController .includes(:customer, :vehicle, :user) .where('date < ?', Time.zone.now.beginning_of_day) scope = scope.where(customer_id: @customer.id) if @customer - scope = scope.where(status: @status) if @status + # The status filter also offers call-outs, which have no status + if @status == CustomerAppointment::CALL_OUT + scope = scope.where(event_type: CustomerAppointment::CALL_OUT) + elsif @status + scope = scope.where(status: @status).where(event_type: [nil, '']) + end scope = scope.where('date >= ?', @from.in_time_zone.beginning_of_day) if @from scope = scope.where('date <= ?', @to.in_time_zone.end_of_day) if @to @@ -72,6 +77,9 @@ class CustomerAppointmentsController < ApplicationController def new @appointment = CustomerAppointment.new @appointment.project = @project + # The calendar's "call-out" link makes an employee's call-out instead of a customer appointment + @appointment.event_type = CustomerAppointment::CALL_OUT if params[:event_type] == CustomerAppointment::CALL_OUT + @appointment.status = RedmineQboCalendar::AppointmentStatus.default.key unless @appointment.call_out? @appointment.date = (params[:start_date].to_date + 9.hours) if params[:start_date].present? @appointment.customer_id = params[:customer_id] if params[:customer_id].present? prefill_estimate_and_vehicle @@ -137,6 +145,7 @@ class CustomerAppointmentsController < ApplicationController :vehicle_id, :description, :status, + :event_type, :user_id, :date, :estimated_hours, diff --git a/app/models/customer_appointment.rb b/app/models/customer_appointment.rb index 6583378..f4492a9 100644 --- a/app/models/customer_appointment.rb +++ b/app/models/customer_appointment.rb @@ -22,6 +22,11 @@ class CustomerAppointment < ActiveRecord::Base validates :subject, presence: true validates :date, presence: true + # A call-out is about the employee who's off (checked when set, so older call-outs without one still save) + validates :user, presence: true, if: -> { call_out? && (new_record? || will_save_change_to_user_id?) } + + # Call-outs have no customer side; appointments get the default status when none is chosen + before_validation :prepare_entry # Prevent scheduling on non-working days or holidays validate :validate_working_day @@ -32,25 +37,32 @@ class CustomerAppointment < ActiveRecord::Base # Capitalize the first letter only; titleize mangled vehicle names and acronyms (JL -> Jl, LED -> Led) normalizes :subject, with: ->(subject) { subject.strip.sub(/\A[a-z]/, &:upcase) } - STATUSES = %w[ - Scheduled - Checked_In - In_Progress - Ready - Completed - Cancelled - Call_Out - ] + # An employee off work (sick, a day off): shown on the calendar, but not an appointment with a customer + CALL_OUT = 'call_out' - # Statuses whose time should not count toward scheduled hours totals - NON_SCHEDULED_STATUSES = %w[ - Cancelled - Call_Out - ] + # The statuses set up in the plugin settings (see RedmineQboCalendar::AppointmentStatus) + def self.statuses + RedmineQboCalendar::AppointmentStatus.all + end - # False for cancelled / call-out appointments, which stay on the calendar but free up their hours + # Status keys, for other plugins' settings (e.g. redmine_qbo_reminders' "statuses that get reminders") + def self.status_options + statuses.map { |s| [s.name, s.key] } + end + + def call_out? + event_type == CALL_OUT + end + + # This appointment's status from the settings; nil for call-outs, which have none + def status_record + return nil if call_out? + RedmineQboCalendar::AppointmentStatus.find(status) || RedmineQboCalendar::AppointmentStatus.default + end + + # False for call-outs and statuses like Cancelled, which stay on the calendar but free up their hours def counts_toward_hours? - !NON_SCHEDULED_STATUSES.include?(status.to_s) + !call_out? && status_record.counts_hours? end # Cast datetime to Date for Redmine Calendar compatibility @@ -97,6 +109,21 @@ class CustomerAppointment < ActiveRecord::Base Rails.logger.info "[CustomerAppointment] #{msg}" end + def prepare_entry + if call_out? + self.customer = nil + self.vehicle = nil + self.estimate = nil + self.status = nil + self.estimated_hours = 0 + self.subject = I18n.t(:label_call_out_subject, name: user.name) if subject.blank? && user + else + self.event_type = nil + self.status = RedmineQboCalendar::AppointmentStatus.default.key if status.blank? + end + self.description = description.to_s + end + # Checked when the estimate or the hours change, so changing just the status (the quick status buttons) # never fails on an older appointment def validate_hours_cover_estimate diff --git a/app/views/common/_calendar.html.erb b/app/views/common/_calendar.html.erb index 55b6b4b..fe4f132 100644 --- a/app/views/common/_calendar.html.erb +++ b/app/views/common/_calendar.html.erb @@ -102,11 +102,8 @@ end %> -<%# Calendar Status Legend Key %> -<% - # Collect status keys from CustomerAppointment enum - statuses = CustomerAppointment::STATUSES -%> +<%# Calendar Status Legend Key: the statuses set up in the plugin settings, then call-outs %> +<% statuses = CustomerAppointment.statuses %> <% if statuses.any? %>
@@ -114,12 +111,14 @@ <%= l(:label_legend, default: 'Legend') %>: - <% statuses.each do |status_key| %> - - <%= status_key.humanize %> + <% statuses.each do |status| %> + + <%= status.name %> <% end %> + + <%= l(:label_call_out) %> +
<% end %> @@ -189,14 +188,17 @@ standard_events = only_appointments ? [] : calendar.events_on(day).reject { |e| e.is_a?(CustomerAppointment) } matching_appointments = all_appointments.select { |app| appointment_occurs_on.call(app, day) } + # Call-outs first (who's off that day), then everything else by time day_events = (standard_events + matching_appointments).sort_by do |event| - if event.is_a?(CustomerAppointment) && event.date.present? - event.date.strftime('%H:%M:%S') - elsif event.respond_to?(:start_date) && event.start_date.present? - event.start_date.to_time.strftime('%H:%M:%S') - else - '00:00:00' - end + call_out = event.is_a?(CustomerAppointment) && event.call_out? ? 0 : 1 + time = if event.is_a?(CustomerAppointment) && event.date.present? + event.date.strftime('%H:%M:%S') + elsif event.respond_to?(:start_date) && event.start_date.present? + event.start_date.to_time.strftime('%H:%M:%S') + else + '00:00:00' + end + [call_out, time] end day_total_hours = day_events.sum { |event| calculate_event_hours.call(event, day) } @@ -258,6 +260,10 @@ new_customer_appointment_path(start_date: day), class: 'icon-only icon-add', title: l(:label_appointment_new, default: 'New Appointment') %> + <%= link_to new_customer_appointment_path(start_date: day, event_type: CustomerAppointment::CALL_OUT), + class: 'calendar-add-call-out', title: l(:label_new_call_out) do %> + + <% end %> <% end %> <% end %> diff --git a/app/views/customer_appointments/_calendar_event.html.erb b/app/views/customer_appointments/_calendar_event.html.erb index 47c2568..7e56f9b 100644 --- a/app/views/customer_appointments/_calendar_event.html.erb +++ b/app/views/customer_appointments/_calendar_event.html.erb @@ -22,7 +22,11 @@ end %> -<%= tag.div class: ['appointment-block', 'tooltip', appointment.status.to_s.parameterize] do %> +<% + status = appointment.status_record + css = ['appointment-block', 'tooltip', (appointment.call_out? ? 'call-out' : status.key.parameterize), ('no-hours' if status && !status.counts_hours?)] +%> +<%= tag.div class: css.compact, style: status&.style do %>
@@ -51,9 +55,14 @@ (Day <%= day_number %> of <%= duration %>) <% end %> - - <%= number_with_precision(appointment.estimated_hours.to_f, precision: 1) %>h - + <%# Call-outs don't use hours %> + <% if appointment.call_out? %> + + <% else %> + + <%= number_with_precision(appointment.estimated_hours.to_f, precision: 1) %>h + + <% end %> <%# Row 3: Details %> diff --git a/app/views/customer_appointments/_form.html.erb b/app/views/customer_appointments/_form.html.erb index b1d0df6..48979be 100644 --- a/app/views/customer_appointments/_form.html.erb +++ b/app/views/customer_appointments/_form.html.erb @@ -4,6 +4,21 @@ <%= error_messages_for @appointment %>
+ <%= f.hidden_field :event_type %> + <% if @appointment.call_out? %> + <%# An employee off work: no customer, vehicle, estimate, hours or status %> +

+ + <%= f.collection_select :user_id, User.active.sorted, :id, :name, { include_blank: true }, { label: false } %> +

+ +

+ <%= f.text_field :subject, style: "width: 95%;", placeholder: l(:text_call_out_subject_placeholder) %> +

+ +

<%= f.datetime_local_field :date %>

+

<%= f.number_field :duration, step: 1, size: 6, label: :label_duration %>

+ <% else %>

<%= f.text_field :subject, required: true, style: "width: 95%;" %>

@@ -33,7 +48,11 @@

<%= f.number_field :estimated_hours, step: 1, size: 6 %>

<%= f.number_field :duration, step: 1, size: 6, label: :label_duration %>

-

<%= f.select :status, CustomerAppointment::STATUSES, label: :field_status %>

+ <%# The statuses set up in the plugin settings, plus a removed one this appointment still has %> + <% status_options = CustomerAppointment.status_options %> + <% status_options += [[@appointment.status_record.name, @appointment.status]] if @appointment.status.present? && !@appointment.status_record.known? %> +

<%= f.select :status, status_options, label: :field_status %>

+ <% end %>

<%= f.text_area :description, diff --git a/app/views/customer_appointments/_list.html.erb b/app/views/customer_appointments/_list.html.erb index 6bb1726..7b85e86 100644 --- a/app/views/customer_appointments/_list.html.erb +++ b/app/views/customer_appointments/_list.html.erb @@ -60,7 +60,7 @@ -<%= appointment.status %> +<%= appointment_status_badge(appointment) %> diff --git a/app/views/customer_appointments/_list_simple.html.erb b/app/views/customer_appointments/_list_simple.html.erb index 6142a03..1a7c798 100644 --- a/app/views/customer_appointments/_list_simple.html.erb +++ b/app/views/customer_appointments/_list_simple.html.erb @@ -19,11 +19,7 @@ <%= link_to appointment.user unless appointment.user.nil? %> <%= format_date(appointment.date) %> - <% if appointment.status.present? %> - - <%= appointment.status.to_s.humanize %> - - <% end %> + <%= appointment_status_badge(appointment) %> <% end %> diff --git a/app/views/customer_appointments/_tooltip.html.erb b/app/views/customer_appointments/_tooltip.html.erb index 548b14a..063616b 100644 --- a/app/views/customer_appointments/_tooltip.html.erb +++ b/app/views/customer_appointments/_tooltip.html.erb @@ -4,7 +4,7 @@

- <%= appointment.status.to_s.humanize %> + <%= appointment.call_out? ? l(:label_call_out) : appointment.status_record.name %>

@@ -38,7 +38,7 @@ <% if appointment.user %> - + <% end %> + <% unless appointment.call_out? %> + <% end %> diff --git a/app/views/customer_appointments/edit.html.erb b/app/views/customer_appointments/edit.html.erb index f335eb6..0796512 100644 --- a/app/views/customer_appointments/edit.html.erb +++ b/app/views/customer_appointments/edit.html.erb @@ -1,3 +1,3 @@ -

<%=l(:label_edit_appointment)%>

+

<%= l(@appointment.call_out? ? :label_edit_call_out : :label_edit_appointment) %>

-<%= render "form" %> \ No newline at end of file +<%= render "form" %> diff --git a/app/views/customer_appointments/history.html.erb b/app/views/customer_appointments/history.html.erb index 6b67e71..993a1d3 100644 --- a/app/views/customer_appointments/history.html.erb +++ b/app/views/customer_appointments/history.html.erb @@ -35,7 +35,7 @@ <%= select_tag :status, - options_for_select(CustomerAppointment::STATUSES.map { |s| [s.humanize, s] }, @status), + options_for_select(CustomerAppointment.status_options + [[l(:label_call_out_plural), CustomerAppointment::CALL_OUT]], @status), include_blank: l(:label_all_statuses) %> @@ -80,11 +80,7 @@ <% end %> diff --git a/app/views/customer_appointments/new.html.erb b/app/views/customer_appointments/new.html.erb index 1477291..2c7dbdc 100644 --- a/app/views/customer_appointments/new.html.erb +++ b/app/views/customer_appointments/new.html.erb @@ -1,3 +1,3 @@ -

<%=l(:label_new_appointment)%>

+

<%= l(@appointment.call_out? ? :label_new_call_out : :label_new_appointment) %>

-<%= render "form" %> \ No newline at end of file +<%= render "form" %> diff --git a/app/views/customer_appointments/show.html.erb b/app/views/customer_appointments/show.html.erb index 1dd68ff..e6b361e 100644 --- a/app/views/customer_appointments/show.html.erb +++ b/app/views/customer_appointments/show.html.erb @@ -8,7 +8,7 @@ <%= l(:label_appointment_history) %> <% end %> <% end %> - <% if User.current.allowed_to?(:add_customer_appointments, nil, global: true) %> + <% if !@appointment.call_out? && User.current.allowed_to?(:add_customer_appointments, nil, global: true) %> <%= link_to new_issue_path(issue: { customer_id: @appointment.customer_id, vehicle_id: @appointment.vehicle_id, estimate_id: @appointment.estimate_id }), target: :_blank do %> <%= l(:label_new_issue) %> <% end %> @@ -53,19 +53,15 @@ -<% if User.current.allowed_to?(:edit_customer_appointments, nil, global: true) %> - <%# Quick Status Action Buttons %> - <% - statuses = CustomerAppointment::STATUSES - current_status = @appointment.status.to_s.parameterize.underscore - %> +<%# Quick status buttons; call-outs have no status %> +<% if !@appointment.call_out? && User.current.allowed_to?(:edit_customer_appointments, nil, global: true) %>
<%= l(:label_change_status, default: 'Change Status:') %> - <% statuses.reject { |s| s == current_status }.each do |status_key| %> - <%= link_to status_key.humanize, - customer_appointment_path(@appointment, customer_appointment: { status: status_key }), + <% CustomerAppointment.statuses.reject { |s| s.key == @appointment.status_record.key }.each do |status| %> + <%= link_to status.name, + customer_appointment_path(@appointment, customer_appointment: { status: status.key }), method: :patch, - class: "quick-status-btn status-#{status_key.parameterize}" %> + class: 'quick-status-btn', style: status.style %> <% end %>
<% end %> @@ -74,6 +70,13 @@
+ <% if @appointment.call_out? %> + <%# A call-out is about the employee who's off, not a customer %> +
+
<%= l(:label_employee) %>:
+
<%= link_to_user(@appointment.user) %>
+
+ <% else %>
<%= l(:label_customer, default: 'Customer') %>:
<%= link_to_if @appointment.customer, @appointment.customer&.name, @appointment.customer %>
@@ -92,15 +95,14 @@
<%= link_to @appointment.estimate, @appointment.estimate, target: "_blank" %>
<% end %>
+ <% end %>
<%= l(:field_status) %>:
- - <%= @appointment.status.to_s.humanize %> - + <%= appointment_status_badge(@appointment) %>
@@ -109,18 +111,22 @@ <%= @appointment.date ? @appointment.date.strftime('%I:%M %p') : '-' %>
+ <% unless @appointment.call_out? %>
<%= l(:field_user) %>:
<%= link_to_user(@appointment.user) %>
+ <% end %>
<%= l(:label_duration, default: 'Duration') %>:
<%= @appointment.duration %> <%= l(:label_days) %>
+ <% unless @appointment.call_out? %>
<%= l(:field_estimated_hours) %>:
<%= @appointment.estimated_hours %> <%= l(:label_hours) %>
+ <% end %>
diff --git a/app/views/my/blocks/_upcoming_appointments.html.erb b/app/views/my/blocks/_upcoming_appointments.html.erb index bf335c3..1645c66 100644 --- a/app/views/my/blocks/_upcoming_appointments.html.erb +++ b/app/views/my/blocks/_upcoming_appointments.html.erb @@ -66,8 +66,7 @@ <% expanded_appointments.each do |item| %> <% appt = item[:appointment] %> - <% status_slug = appt.status.to_s.parameterize %> - + <% end %> diff --git a/app/views/settings/_qbo_calendar.html.erb b/app/views/settings/_qbo_calendar.html.erb new file mode 100644 index 0000000..bd27cd6 --- /dev/null +++ b/app/views/settings/_qbo_calendar.html.erb @@ -0,0 +1,128 @@ +<% + statuses = RedmineQboCalendar::AppointmentStatus.all + # How many appointments use each status: removing one in use asks where to move them + in_use = CustomerAppointment.where(event_type: nil).group(:status).count + status_row = lambda do |index, status| + count = status ? in_use[status.key].to_i : 0 + name = "settings[statuses][#{index}]" + content_tag(:tr, class: 'appointment-status-row', data: { in_use: count }) do + safe_join([ + content_tag(:td, sprite_icon('reorder'), class: 'appointment-status-handle', title: l(:label_drag_to_reorder_status)), + content_tag(:td, safe_join([ + hidden_field_tag("#{name}[key]", status&.key, id: nil), + text_field_tag("#{name}[name]", status&.name, id: nil, size: 24, class: 'appointment-status-name', + 'aria-label': l(:field_name)) + ])), + content_tag(:td, color_field_tag("#{name}[color]", status&.color || '#1fc0ff', id: nil, + class: 'appointment-status-color', 'aria-label': l(:field_color))), + content_tag(:td, safe_join([ + hidden_field_tag("#{name}[counts_hours]", '0', id: nil), + check_box_tag("#{name}[counts_hours]", '1', status.nil? || status.counts_hours?, id: nil, + 'aria-label': l(:label_status_counts_hours)) + ]), class: 'appointment-status-hours'), + content_tag(:td, content_tag(:span, status&.name || l(:label_new_status), class: 'status-badge appointment-status-preview', + style: "--status-color: #{status&.color || '#1fc0ff'}")), + content_tag(:td, count.positive? ? l(:label_status_in_use, count: count) : '', class: 'appointment-status-count'), + content_tag(:td, link_to(sprite_icon('del', l(:button_delete)), '#', class: 'icon-only icon-del appointment-status-remove', + title: l(:button_delete)), class: 'buttons') + ]) + end + end +%> + +
+ <%= l(:label_appointment_statuses) %> +

<%= l(:text_appointment_statuses) %>

+ +
<%= l(:label_technician) %><%= l(appointment.call_out? ? :label_employee : :label_technician) %> <%= avatar(appointment.user, size: 16) %> <%= link_to appointment.user %> @@ -74,10 +74,12 @@
<%= l(:label_estimated_hours) %> <%= number_with_precision(appointment.estimated_hours, precision: 1) %> hrs
<%= l(:label_duration) %><%= link_to_user(appointment.user) if appointment.user %> <%= appointment.duration %> <%= l(:label_days) %> - <% if appointment.status.present? %> - - <%= appointment.status.to_s.humanize %> - - <% end %> + <%= appointment_status_badge(appointment) %>
<%= link_to appt.subject, customer_appointment_path(appt) %> <% if item[:total_days] > 1 %> @@ -84,11 +83,7 @@ <%= format_date(item[:date]) %> - <% if appt.status.present? %> - - <%= appt.status.to_s.humanize %> - - <% end %> + <%= appointment_status_badge(appt, css: 'badge status-badge') %>
+ + + + + + + + + + + + + <% statuses.each_with_index do |status, index| %> + <%= status_row.call(index, status) %> + <% end %> + +
<%= l(:field_name) %><%= l(:field_color) %><%= l(:label_status_counts_hours) %><%= l(:label_preview) %>
+ + + +

+ <%= link_to sprite_icon('add', l(:button_add_status)), '#', id: 'appointment-status-add', class: 'icon icon-add' %> +

+

<%= l(:text_call_outs_not_statuses) %>

+ + +<%= javascript_tag do %> + $(function () { + var $body = $('#appointment-statuses'); + $body.sortable({ handle: '.appointment-status-handle', axis: 'y' }); + + // The preview badge follows the name and colour + $body.on('input', '.appointment-status-name, .appointment-status-color', function () { + var $row = $(this).closest('tr'); + var $preview = $row.find('.appointment-status-preview'); + $preview.text($row.find('.appointment-status-name').val() || <%= raw l(:label_new_status).to_json %>); + $preview[0].style.setProperty('--status-color', $row.find('.appointment-status-color').val()); + }); + + $('#appointment-status-add').on('click', function (e) { + e.preventDefault(); + var html = $('#appointment-status-template').html().replace(/NEW_STATUS/g, 'new' + Date.now()); + $body.append(html); + $body.find('tr:last .appointment-status-name').focus(); + }); + + // Removing a status its appointments use: its row becomes a choice of status to move them to (done when + // the settings are saved), or keeping it (shown grey). Undo puts the row back. + $body.on('click', '.appointment-status-remove', function (e) { + e.preventDefault(); + var $row = $(this).closest('tr'); + var count = parseInt($row.data('in-use'), 10) || 0; + var key = $row.find('input[name$="[key]"]').val(); + if (!count || !key) { $row.remove(); return; } + + var $select = $('