Drop the leftover settings page

The labor products/services and the issues-from-estimates defaults are set in redmine_qbo only.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
This commit is contained in:
Claude committed 2026-10-31 08:21:19 -04:00
1 parent 13e8c07c0d
commit 1502a939c9
6 files changed
+5 -15

No files matched your search

+1 -1
View File
@@ -29,7 +29,7 @@ This plugin allows for adding customer appointment capability to the Redmine cal
Add appointments to the redmine calanedar with the abiltiy to attach a QBO customer, QBO Vehicle, QBO Estimate, ect. Add appointments to the redmine calanedar with the abiltiy to attach a QBO customer, QBO Vehicle, QBO Estimate, ect.
* An appointment's hours can't be less than its estimate's labor hours (the lines matching redmine_qbo's estimate item codes). Picking an estimate raises the hours to match. * An appointment's hours can't be less than its estimate's labor hours (the quantities of its lines with redmine_qbo's labor products/services). Picking an estimate raises the hours to match.
* The appointment page lists the issues linked to its estimate, and **Create Issues from Estimate** opens redmine_qbo's Create issues page with the appointment's dates, technician and vehicle. * The appointment page lists the issues linked to its estimate, and **Create Issues from Estimate** opens redmine_qbo's Create issues page with the appointment's dates, technician and vehicle.
* Estimate pages in redmine_qbo get an **Add appointment** link. * Estimate pages in redmine_qbo get an **Add appointment** link.
@@ -24,7 +24,7 @@ class CustomerAppointmentsController < ApplicationController
} }
end end
# The estimate's labor hours (redmine_qbo's item codes), so the form can make sure the # The estimate's labor hours (redmine_qbo's labor products/services), so the form can make sure the
# appointment's hours aren't less # appointment's hours aren't less
def estimate_hours def estimate_hours
estimate = Estimate.find_by(id: params[:estimate_id]) estimate = Estimate.find_by(id: params[:estimate_id])
+1 -1
View File
@@ -81,7 +81,7 @@ class CustomerAppointment < ActiveRecord::Base
end end
# The estimate's labor hours rounded up to whole hours (appointment hours are whole numbers): the # The estimate's labor hours rounded up to whole hours (appointment hours are whole numbers): the
# quantities of its lines whose item matches redmine_qbo's item codes (e.g. Labor). 0 if the # quantities of its lines with redmine_qbo's labor products/services (e.g. Labor). 0 if the
# estimate can't be read from QuickBooks. # estimate can't be read from QuickBooks.
def self.estimate_labor_hours(estimate) def self.estimate_labor_hours(estimate)
return 0 if estimate.nil? return 0 if estimate.nil?
@@ -1,5 +0,0 @@
<%# The issues-from-estimate settings moved to redmine_qbo %>
<p>
<%= l(:text_estimate_issue_settings_moved) %>
<%= link_to l(:label_redmine_qbo_settings), plugin_settings_path(id: 'redmine_qbo') %>
</p>
-2
View File
@@ -88,5 +88,3 @@ en:
title_customer_appointments: Customer Appointments title_customer_appointments: Customer Appointments
error_hours_less_than_estimate: "The hours can't be less than the %{hours} labor hours on estimate #%{estimate}" error_hours_less_than_estimate: "The hours can't be less than the %{hours} labor hours on estimate #%{estimate}"
label_estimate_issues: "Issues for estimate #%{estimate}" label_estimate_issues: "Issues for estimate #%{estimate}"
label_redmine_qbo_settings: "Redmine QBO settings (Billing)"
text_estimate_issue_settings_moved: "Creating issues from estimates moved to redmine_qbo: the item codes, default project and default tracker are set there."
+2 -5
View File
@@ -19,11 +19,8 @@ Redmine::Plugin.register :redmine_qbo_calendar do
author_url 'https://barrettefabrication.com' author_url 'https://barrettefabrication.com'
requires_redmine version_or_higher: '7.0.0' requires_redmine version_or_higher: '7.0.0'
# Item codes: which QBO estimate items can become issues (e.g. Labor, Alignments) # No settings of its own: labor products/services and the issues-from-estimates defaults are set in
# The issues-from-estimate settings moved to redmine_qbo, which reads these old values until its # redmine_qbo's plugin settings
# own are saved, so they're still registered here
settings default: { 'item_codes' => "Labor", 'default_tracker_id' => '', 'default_project_id' => '' },
partial: 'settings/qbo_calendar_settings'
# Add Holidays index to the Redmine Administration Menu # Add Holidays index to the Redmine Administration Menu
menu :admin_menu, :holidays, { controller: 'holidays', action: 'index' }, caption: :label_holiday_plural, html: { class: 'icon icon-list' } menu :admin_menu, :holidays, { controller: 'holidays', action: 'index' }, caption: :label_holiday_plural, html: { class: 'icon icon-list' }