mirror of
https://github.com/rickbarrette/redmine_qbo.git
synced 2026-11-17 18:20:36 -05:00
QuickBooks only requires an item's name, but the local Item required a description and a rate, so services such as Labor (often with neither) failed validation and were silently skipped by the sync. Name is now the only requirement; a missing description syncs as blank and a missing rate as 0. Product/service pickers and the labor setting list sellable items only (no Categories or Bundles). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BiwYMjhoQvL7XsKKfRz4pM
106 lines
3.4 KiB
Ruby
106 lines
3.4 KiB
Ruby
#The MIT License (MIT)
|
|
#
|
|
#Copyright (c) 2026 rick barrette
|
|
#
|
|
#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
|
|
#
|
|
#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
|
|
#
|
|
#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
|
|
|
|
class ItemsController < ApplicationController
|
|
layout 'admin'
|
|
menu_item :redmine_qbo_items
|
|
|
|
# The item catalog is pushed to QuickBooks, so managing it is admin-only. The autocomplete feeds the
|
|
# line item form on issues and is allowed with the "Add line items" or "Edit line items" permission.
|
|
before_action :require_admin, except: :autocomplete
|
|
before_action :authorize_global, only: :autocomplete
|
|
before_action :find_item, only: [:show, :edit, :update, :destroy]
|
|
|
|
# Used for autocomplete form
|
|
def autocomplete
|
|
term = ActiveRecord::Base.sanitize_sql_like(params[:q].to_s)
|
|
|
|
items = Item.where("description LIKE :t OR name LIKE :t OR sku LIKE :t", t: "%#{term}%")
|
|
.merge(Item.sellable)
|
|
.order(:description)
|
|
.limit(20)
|
|
|
|
render json: items.map { |i|
|
|
{ id: i.id, name: i.name, sku: i.sku, description: i.description, price: i.unit_price }
|
|
}
|
|
end
|
|
|
|
def create
|
|
@item = Item.new(item_params)
|
|
|
|
if @item.save
|
|
redirect_to item_path(@item), notice: l(:notice_successful_create)
|
|
else
|
|
render :new, status: :unprocessable_entity
|
|
end
|
|
rescue => e
|
|
log "Unexpected error creating item: #{e.message}"
|
|
|
|
# Regex now matches across line breaks
|
|
existing_id = e.message[/Duplicate Name Exists Error:[\s\S]*Id=(\d+)/, 1]&.to_i
|
|
|
|
if existing_id
|
|
flash[:error] = "Name already exists. Redirecting to existing item."
|
|
redirect_to item_path(existing_id)
|
|
else
|
|
flash[:error] = e.message
|
|
redirect_to new_item_path
|
|
end
|
|
end
|
|
|
|
def destroy
|
|
@item.destroy
|
|
redirect_to items_path, notice: l(:notice_successful_delete)
|
|
end
|
|
|
|
def edit
|
|
end
|
|
|
|
def index
|
|
@items = Item.order(:name)
|
|
end
|
|
|
|
def new
|
|
@item = Item.new
|
|
end
|
|
|
|
def show
|
|
end
|
|
|
|
def sync
|
|
Item.sync
|
|
redirect_back fallback_location: home_path, flash: { notice: I18n.t(:label_syncing) }
|
|
end
|
|
|
|
def update
|
|
if @item.update(item_params)
|
|
redirect_to item_path(@item), notice: l(:notice_successful_update)
|
|
else
|
|
render :edit, status: :unprocessable_entity
|
|
end
|
|
end
|
|
|
|
private
|
|
|
|
def find_item
|
|
@item = Item.find(params[:id])
|
|
rescue ActiveRecord::RecordNotFound
|
|
render_404
|
|
end
|
|
|
|
def item_params
|
|
params.require(:item).permit(:name, :description, :sku, :unit_price, :active, :account_id, :type, :taxable)
|
|
end
|
|
|
|
def log(msg)
|
|
Rails.logger.info "[ItemsController] #{msg}"
|
|
end
|
|
|
|
end |