Refactored view hooks

app/controllers/customers_controller.rb

@@ -110,7 +110,7 @@ class CustomersController < ApplicationController
     begin
       @customer = Customer.find_by_id(params[:id])
       if @customer.update(allowed_params)
-        flash[:notice] = tv :notice_customer_updated
+        flash[:notice] = t :notice_customer_updated
         redirect_to @customer
       else
         redirect_to edit_customer_path

app/controllers/qbo_controller.rb

@@ -92,10 +92,10 @@ class QboController < ApplicationController
           data = params.as_json
         end
         # Process the information
-        entities = data['eventNotifications'][0]['dataChangeEvent'][:entities]
+        entities = data['eventNotifications'][0]['dataChangeEvent']['entities']
         entities.each do |entity|
-          id = entity[:id].to_i
+          id = entity['id'].to_i
-          name = entity[:name]
+          name = entity['name']
         
           logger.info "Casting #{name.constantize} to obj"
 
@@ -106,7 +106,7 @@ class QboController < ApplicationController
           obj.destroy(entity['deletedId']) if entity['deletedId']
           
           #Check to see if we are deleting a record
-          if entity[:operation].eql? "Delete"
+          if entity['operation'].eql? "Delete"
             obj.destroy(id)
           #if not then update!
           else

app/helpers/auth_helper.rb

@@ -13,6 +13,7 @@ module AuthHelper
   def require_user
     return unless session[:token].nil?
     if !User.current.logged?
+      flash[:error] = t :notice_forbidden
       render_403
     end
   end
@@ -27,6 +28,7 @@ module AuthHelper
   
   def check_permission(permission)
     if !allowed_to?(permission)
+      flash[:error] = t :notice_forbidden
       render_403
     end
   end
@@ -34,6 +36,7 @@ module AuthHelper
   
   def global_check_permission(permission)
     if !globaly_allowed_to?(permission)
+      flash[:error] = t :notice_forbidden
       render_403
     end
   end

app/views/customers/_actions.html.erb

@@ -1,9 +1,9 @@
-<%= link_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to "Customer Details", "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank %>
+<%= button_to t(:label_appointment), "https://calendar.google.com/calendar/render?action=TEMPLATE&text=#{@customer.name}+-&details=#{ link_to t(:customer_details), "https://#{Setting.host_name}#{customer_path @customer.id}"}%0A#{@customer.primary_phone}&dates=#{Time.now.strftime("%Y%m%d")}T090000/#{Time.now.strftime("%Y%m%d")}T170000", target: :_blank, method: :get %>
 
 <br/>
 <br/>
 
-<%= link_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank %>
+<%= button_to t(:label_create_estimate), "https://qbo.intuit.com/app/estimate?nameId=#{@customer.id}", target: :_blank, method: :get %>
 
 <br/>
 <br/>

app/views/customers/show.html.erb

@@ -27,12 +27,12 @@
         <div class="splitcontent">
           <div class="splitcontentleft">
             <h4><%=t(:estimates)%>:</h4>
-            <%= render partial: 'estimates/list', locals: {customer: @customer} %>
+            <%= render partial: 'estimates/list', locals: {estimates: @customer.estimates} %>
           </div>
 
           <div class="splitcontentleft">
             <h4><%=t(:label_invoices)%>:</h4>
-            <%= render partial: 'invoices/list', locals: {customer: @customer} %>
+            <%= render partial: 'invoices/list', locals: {invoices: @customer.invoices} %>
           </div>
         </div>
 

app/views/estimates/_list.html.erb

@@ -1,6 +1,6 @@
-<% if @customer.present? %>
+<% unless estimates.empty? %>
 
-  <% @customer.estimates.order(id: :desc).each do |estimate| %>
+  <% estimates.sort.reverse.each do |estimate| %>
     <div class="row">
       <b><%= link_to "##{estimate.doc_number}", estimate_path(estimate), target: :_blank %></b> <%= estimate.txn_date %>
     </div>

app/views/invoices/_list.html.erb

@@ -1,24 +1,23 @@
-<% if @customer.present? %>
+<% unless invoices.empty? %>
 
   <%= form_with(url: invoice_path, method: :get) do |form| %>
 
-    <% if @customer.invoices.count > 1 %>
+    <% if invoices.count > 1 %>
       <div class="form-check">
         <%= check_box_tag "select-all-invoices", "1", false, id: "select-all-invoices" %>
         <%= label_tag "select-all-invoices", t(:label_select_all) %>
       </div>
-
       <hr>
     <% end %>
 
-    <% @customer.invoices.order(id: :desc).each do |invoice| %>
+    <% invoices.sort.reverse.each do |invoice| %>
       <div class="row">
-        <%= check_box_tag "invoice_ids[]", invoice.id, false, class: "invoice-checkbox"  %>
+        <%= check_box_tag "invoice_ids[]", invoice.id, false, class: "invoice-checkbox" if invoices.count > 1 %>
         <b><%= link_to "##{invoice.doc_number}", invoice_path(invoice), target: :_blank %></b> <%= invoice.txn_date %>
       </div>
     <% end %>
 
-    <% if @customer.invoices.count > 1 %>
+    <% if invoices.count > 1 %>
       <%= form.submit t(:button_bulk_pdf) %>
     <% end %>
   <% end %>

app/views/qbo/_footer.html.erb

@@ -0,0 +1,3 @@
+"<div id='footer' align='center'>
+    <b><%=I18n.translate(:label_last_sync)%>: </b> <%=Qbo.last_sync if Qbo.exists?%>
+</div>"

config/locales/en.yml

@@ -98,4 +98,5 @@ en:
   notice_invoice_updated: "Invoice updated in Quickbooks"
   notice_invoice_not_found: "Invoice not found"
   notice_forbidden: "You do not have permission to access this resource"
-  notice_issue_not_found: "Issue not found"
+  notice_issue_not_found: "Issue not found"
+  customer_details: "Customer Details"

init.rb

@@ -13,8 +13,8 @@ Redmine::Plugin.register :redmine_qbo do
   # About
   name 'Redmine QBO plugin'
   author 'Rick Barrette'
-  description 'This is a plugin for Redmine to intergrate with Quickbooks Online to allow for seamless intergration CRM and invoicing of completed issues'
+  description 'A pluging for Redmine to connect with QuickBooks Online to create Time Activity Entries for billable hours logged when an Issue is closed'
-  version '2026.1.7'
+  version '2026.1.9'
   url 'https://github.com/rickbarrette/redmine_qbo'
   author_url 'https://barrettefabrication.com'
   settings default: {empty: true}, partial: 'qbo/settings'

lib/hooks/header_footer_hook_listener.rb

@@ -1,19 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module Hooks
-
-  class HeaderFooterHookListener < Redmine::Hook::ViewListener
-    def view_layouts_base_body_bottom(context = {})
-      return "<div id='footer' align='center'><b>#{I18n.translate(:label_last_sync)}: </b> #{Qbo.last_sync if Qbo.exists?}</div>"
-    end
-  end
-
-end

lib/hooks/issues_save_hook_listener.rb

@@ -1,36 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module Hooks
-
-  class IssuesSaveHookListener < Redmine::Hook::ViewListener
-
-    # Called Before Issue Saved
-    def controller_issues_edit_before_save(context={})
-      return context[:issue].subject = context[:issue].subject.titleize
-    end
-
-    def controller_issues_new_before_save(context={})
-      return context[:issue].subject = context[:issue].subject.titleize
-    end
-
-    # Called After Issue Saved
-    def controller_issues_edit_after_save(context={})
-      issue = context[:issue]
-      begin
-        issue.bill_time if issue.status.is_closed?
-      rescue
-        # TODO flash[:error] = "Unable to bill, check QBO Auth"
-      end
-    end
-
-  end
-
-end

lib/hooks/view_hook_listener.rb

@@ -12,8 +12,16 @@ module Hooks
 
   class ViewHookListener < Redmine::Hook::ViewListener
 
+    # Load the javascript to support the autocomplete forms
+    def view_layouts_base_html_head(context = {})
+      js = javascript_include_tag 'application.js', plugin: :redmine_qbo
+      js += javascript_include_tag 'autocomplete-rails.js', plugin: :redmine_qbo
+      js += javascript_include_tag 'checkbox_controller.js', plugin: :redmine_qbo
+      return js
+    end
+
     render_on :view_layouts_base_sidebar, partial: "qbo/sidebar"
-    
+    render_on :view_layouts_base_body_bottom, partial: "qbo/footer"
   end
 
 end

lib/hooks/view_layouts_hook_listener.rb

@@ -1,25 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-module Hooks
-
-  class ViewLayoutsHookListener < Redmine::Hook::ViewListener
-
-    # Load the javascript to support the autocomplete forms
-    def view_layouts_base_html_head(context = {})
-      js = javascript_include_tag 'application.js', plugin: :redmine_qbo
-      js += javascript_include_tag 'autocomplete-rails.js', plugin: :redmine_qbo
-      js += javascript_include_tag 'checkbox_controller.js', plugin: :redmine_qbo
-      return js
-    end
-
-  end
-
-end

lib/patches/issue_patch.rb

@@ -12,9 +12,9 @@ require_dependency 'issue'
 
 module Patches
 
-
   # Patches Redmine's Issues dynamically.
-  # Adds a relationships
+  # Adds relationships for customers, estimates, invoices, customer_tokens
+  # Adds before and after save hooks
   module IssuePatch
 
     def self.included(base) # :nodoc:
@@ -28,6 +28,8 @@ module Patches
         belongs_to :customer_token, primary_key: :id
         belongs_to :estimate, primary_key: :id
         has_and_belongs_to_many :invoices
+        before_save :titlize_subject
+        after_save :bill_time
       end
       
     end
@@ -40,61 +42,62 @@ module Patches
       
       # Create billable time entries
       def bill_time
-      
+        logger.debug "QBO: Billing time for issue ##{id} - #{subject}"
-        # Check to see if we have everything we need to bill the customer
+        return unless  status.is_closed?
         return if assigned_to.nil?
         return unless Qbo.first 
         return unless customer 
 
-        # Get unbilled time entries
+        Thread.new do
-        spent_time = time_entries.where(billed: [false, nil])
+          spent_time = time_entries.where(billed: [false, nil])
-        spent_hours ||= spent_time.sum(:hours) || 0
+          spent_hours ||= spent_time.sum(:hours) || 0
-        
-        if spent_hours > 0 then
           
-          # Prepare to create a new Time Activity
+          if spent_hours > 0 then
-          qbo = Qbo.first
-          qbo.perform_authenticated_request do |access_token|
-            time_service = Quickbooks::Service::TimeActivity.new(company_id: qbo.realm_id, access_token: access_token)
-            item_service = Quickbooks::Service::Item.new(company_id: qbo.realm_id, access_token: access_token)
-            time_entry = Quickbooks::Model::TimeActivity.new
-    
-            # Lets total up each activity before billing.
-            # This will simpify the invoicing with a single billable time entry per time activity
-            h = Hash.new(0)
-            spent_time.each do |entry|
-              h[entry.activity.name] += entry.hours
-              # update time entries billed status
-              entry.billed = true
-              entry.save
-            end
             
-            # Now letes upload our totals for each activity as their own billable time entry
+            # Prepare to create a new Time Activity
-            h.each do |key, val|
+            qbo = Qbo.first
+            qbo.perform_authenticated_request do |access_token|
+              time_service = Quickbooks::Service::TimeActivity.new(company_id: qbo.realm_id, access_token: access_token)
+              item_service = Quickbooks::Service::Item.new(company_id: qbo.realm_id, access_token: access_token)
+              time_entry = Quickbooks::Model::TimeActivity.new
+      
+              # Lets total up each activity before billing.
+              # This will simpify the invoicing with a single billable time entry per time activity
+              h = Hash.new(0)
+              spent_time.each do |entry|
+                h[entry.activity.name] += entry.hours
+                # update time entries billed status
+                entry.billed = true
+                entry.save
+              end
               
-              # Convert float spent time to hours and minutes
+              # Now letes upload our totals for each activity as their own billable time entry
-              hours = val.to_i
+              h.each do |key, val|
-              minutesDecimal = (( val - hours) * 60)
+                
-              minutes = minutesDecimal.to_i
+                # Convert float spent time to hours and minutes
+                hours = val.to_i
+                minutesDecimal = (( val - hours) * 60)
+                minutes = minutesDecimal.to_i
 
-              # Lets match the activity to an qbo item
+                # Lets match the activity to an qbo item
-              item = item_service.query("SELECT * FROM Item WHERE Name = '#{key}' ").first
+                item = item_service.query("SELECT * FROM Item WHERE Name = '#{key}' ").first
-              next if item.nil?
+                next if item.nil?
-              
+                
-              # Create the new billable time entry and upload it
+                # Create the new billable time entry and upload it
-              time_entry.description = "#{tracker} ##{id}: #{subject} #{"(Partial @ #{done_ratio}%)" if not closed?}"
+                time_entry.description = "#{tracker} ##{id}: #{subject} #{"(Partial @ #{done_ratio}%)" if not closed?}"
-              time_entry.employee_id = assigned_to.employee_id 
+                time_entry.employee_id = assigned_to.employee_id 
-              time_entry.customer_id = customer_id
+                time_entry.customer_id = customer_id
-              time_entry.billable_status = "Billable"
+                time_entry.billable_status = "Billable"
-              time_entry.hours = hours
+                time_entry.hours = hours
-              time_entry.minutes = minutes
+                time_entry.minutes = minutes
-              time_entry.name_of = "Employee"
+                time_entry.name_of = "Employee"
-              time_entry.txn_date = Date.today
+                time_entry.txn_date = Date.today
-              time_entry.hourly_rate = item.unit_price
+                time_entry.hourly_rate = item.unit_price
-              time_entry.item_id = item.id 
+                time_entry.item_id = item.id 
-              time_entry.start_time = start_date
+                time_entry.start_time = start_date
-              time_entry.end_time = Time.now
+                time_entry.end_time = Time.now
-              time_service.create(time_entry)
+                time_service.create(time_entry)
+              end
             end
           end
         end
@@ -106,6 +109,11 @@ module Patches
       CustomerToken.get_token self
     end
     
+    # Titleize the subject before save
+    def titlize_subject
+      self.subject = self.subject.titleize
+    end
+    
   end  
 
   # Add module to Issue

test/functional/estimate_controller_test.rb

@@ -1,8 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class EstimateControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/functional/invoice_controller_test.rb

@@ -1,8 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class InvoiceControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/functional/qbo_controller_test.rb

@@ -1,18 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboControllerTest < ActionController::TestCase
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/test_helper.rb

@@ -1,2 +0,0 @@
-# Load the Redmine helper
-require File.expand_path(File.dirname(__FILE__) + '/../../../test/test_helper')

test/unit/customer_token_test.rb

@@ -1,9 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class CustomerTokenTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/unit/qbo_customers_test.rb

@@ -1,19 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboCustomersTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/unit/qbo_employee_test.rb

@@ -1,9 +0,0 @@
-require File.expand_path('../../test_helper', __FILE__)
-
-class EmployeeTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end

test/unit/qbo_test.rb

@@ -1,19 +0,0 @@
-#The MIT License (MIT)
-#
-#Copyright (c) 2016 - 2026 rick barrette
-#
-#Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions:
-#
-#The above copyright notice and this permission notice shall be included in all copies or substantial portions of the Software.
-#
-#THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
-
-require File.expand_path('../../test_helper', __FILE__)
-
-class QboTest < ActiveSupport::TestCase
-
-  # Replace this with your real tests.
-  def test_truth
-    assert true
-  end
-end